From 3ee75e61a56e333c6fe7d408be0e853a70c99f9f Mon Sep 17 00:00:00 2001 From: Newbyte Date: Fri, 20 Dec 2024 15:35:56 +0100 Subject: [PATCH] pmb.parse.arguments: Type hint and remove unused arguments from add_kernel_arg() (MR 2514) Presumably, args and kwargs are just here to retain compatibility with add_argument() from argparse.ArgumentParser, but they aren't actually used and consequently only give the illusion of compatibility. Just remove them to simplify the function signature. --- pmb/parse/arguments.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pmb/parse/arguments.py b/pmb/parse/arguments.py index c7a16603..f9bb2789 100644 --- a/pmb/parse/arguments.py +++ b/pmb/parse/arguments.py @@ -820,7 +820,9 @@ def add_packages_arg(subparser, name="packages", *args, **kwargs): arg.completer = package_completer # type: ignore[attr-defined] -def add_kernel_arg(subparser, name="package", nargs="?", *args, **kwargs): +def add_kernel_arg( + subparser: argparse.ArgumentParser, name: str = "package", nargs: int | str = "?" +) -> None: arg = subparser.add_argument( name, nargs=nargs, help="kernel package (e.g. linux-postmarketos-allwinner)" )