From 3ef25e1467f95cef8c76fcc783361c6584d020b2 Mon Sep 17 00:00:00 2001 From: Newbyte Date: Tue, 28 Jan 2025 12:03:45 +0100 Subject: [PATCH] pmb.netboot: Use NonBugError for nonexistent rootfs code path (MR 2540) We fully expect to reach this code path within normal use of pmbootstrap. It's not a bug if we get here. As such, use NonBugError to indicate that and clean up the output. --- pmb/netboot/__init__.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pmb/netboot/__init__.py b/pmb/netboot/__init__.py index e8774ef3..72ae5d84 100644 --- a/pmb/netboot/__init__.py +++ b/pmb/netboot/__init__.py @@ -2,6 +2,7 @@ # SPDX-License-Identifier: GPL-3.0-or-later from pmb.core.context import get_context from pmb.helpers import logging +from pmb.helpers.exceptions import NonBugError from pathlib import Path import socket import time @@ -24,7 +25,7 @@ def start_nbd_server(device: str, replace: bool, ip: str = "172.16.42.2", port: if not (chroot / rootfs_path).exists() or replace: rootfs_path2 = Path("/home/pmos/rootfs") / f"{device}.img" if not (chroot / rootfs_path2).exists(): - raise RuntimeError( + raise NonBugError( "The rootfs has not been generated yet, please run 'pmbootstrap install' first." ) if replace and not pmb.helpers.cli.confirm(