Administration/pmbootstrap-meow
2
0
Fork 0
forked from Mirror/pmbootstrap
Code Pull requests Activity Actions

Revert "install: openrc: fix installing alpine-base early"

Browse source 
This reverts commit 6eb8cab84d.

This is a problematic way to solve the issue. We want to eventually
allow people to migrate from openrc, and having alpine-base in the
world file is an issue. Moreover, a package that runs rc-update
and doesn't depend on openrc simply has a packaging bug. This is
something that is documented, and should be generally fixed
(https://gitlab.postmarketos.org/postmarketOS/pmaports/-/issues/2097).
If we manage to detect more issues, we should fix them in packaging
instead, like with
https://gitlab.postmarketos.org/postmarketOS/pmaports/-/merge_requests/6474

Part-of: https://gitlab.postmarketos.org/postmarketOS/pmbootstrap/-/merge_requests/2593
This commit is contained in:
Pablo Correa Gómez 2025-05-05 21:58:17 +02:00
parent b982e45c8d
commit 496d1b657d
No known key found for this signature in database
GPG key ID: 5AE7F5513E0885CB
1 changed files with 0 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
pmb/install/_install.py
View file

@ -1389,10 +1389,6 @@ def create_device_rootfs(args: PmbArgs, step: int, steps: int) -> None:
# when services are installed later # when services are installed later
if pmb.config.other.is_systemd_selected(context.config): if pmb.config.other.is_systemd_selected(context.config):
pmb.chroot.apk.install(["postmarketos-base-systemd"], chroot) pmb.chroot.apk.install(["postmarketos-base-systemd"], chroot)
else:
# Install alpine-base (which pulls in openrc related packages) early,
# so postinst scripts can run rc-update
pmb.chroot.apk.install(["alpine-base"], chroot)
# Install all packages to device rootfs chroot (and rebuild the initramfs, # Install all packages to device rootfs chroot (and rebuild the initramfs,
# because that doesn't always happen automatically yet, e.g. when the user # because that doesn't always happen automatically yet, e.g. when the user