Administration/pmbootstrap-meow
2
0
Fork 0
forked from Mirror/pmbootstrap
Code Pull requests Activity Actions

pmb.commands.pull: Remove bool return type from run() (MR 2490)

Browse source 
This is the only command to return a bool from run rather than None, and
this return type doesn't seem to get used anywhere, so let's just remove
it.
This commit is contained in:
Newbyte 2024-11-16 14:26:10 +01:00
parent 8d1ff21e9e
commit 5d1a2ebd39
No known key found for this signature in database
GPG key ID: 5AE7F5513E0885CB
1 changed files with 2 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
pmb/commands/pull.py
View file

@ -12,14 +12,14 @@ class Pull(commands.Command):
def __init__(self) -> None: def __init__(self) -> None:
pass pass
def run(self) -> bool: def run(self) -> None:
failed = [] failed = []
for repo in pmb.config.git_repos.keys(): for repo in pmb.config.git_repos.keys():
if pmb.helpers.git.pull(repo) < 0: if pmb.helpers.git.pull(repo) < 0:
failed.append(repo) failed.append(repo)
if not failed: if not failed:
return True return
logging.info("---") logging.info("---")
logging.info("WARNING: failed to update: " + ", ".join(failed)) logging.info("WARNING: failed to update: " + ", ".join(failed))
@ -35,4 +35,3 @@ class Pull(commands.Command):
for name_repo in failed: for name_repo in failed:
logging.info(f"* {pmb.helpers.git.get_path(name_repo)}") logging.info(f"* {pmb.helpers.git.get_path(name_repo)}")
logging.info("---") logging.info("---")
return False