From 67254b62c490952cbe9c5b85d2f143380ee52490 Mon Sep 17 00:00:00 2001 From: Robert Yang Date: Sat, 2 Feb 2019 17:30:49 -0500 Subject: [PATCH] static code analysis: make it pass flake8 3.7.4 (!1748) Test with flake8: *.py ./test/check_checksums.py:13:13: E117 over-indented ./pmb/config/init.py:97:8: F632 use ==/!= to compare str, bytes, and int literals ./pmb/parse/arguments.py:229:13: E117 over-indented --- pmb/config/init.py | 2 +- pmb/parse/arguments.py | 2 +- test/check_checksums.py | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pmb/config/init.py b/pmb/config/init.py index 5e43355c..1c4c2186 100644 --- a/pmb/config/init.py +++ b/pmb/config/init.py @@ -94,7 +94,7 @@ def ask_for_keymaps(args, device): options = info["keymaps"].split(' ') logging.info("Available keymaps for device (" + str(len(options)) + "): " + ", ".join(options)) - if args.keymap is "": + if args.keymap == "": args.keymap = options[0] while True: diff --git a/pmb/parse/arguments.py b/pmb/parse/arguments.py index 9cf4b0d8..0d8f5a7f 100644 --- a/pmb/parse/arguments.py +++ b/pmb/parse/arguments.py @@ -226,7 +226,7 @@ def arguments_kconfig(subparser): check.add_argument("--arch", choices=arch_choices, dest="arch") check_package = check.add_argument("package", default="", nargs='?') if argcomplete: - check_package.completer = kernel_completer + check_package.completer = kernel_completer # "pmbootstrap kconfig edit" edit = sub.add_parser("edit", help="edit kernel aport config") diff --git a/test/check_checksums.py b/test/check_checksums.py index fa1756ae..a116d575 100755 --- a/test/check_checksums.py +++ b/test/check_checksums.py @@ -10,8 +10,8 @@ def get_changed_files(): raw = subprocess.check_output(['git', 'diff', '--name-only', 'master...{}'.format(branch)]) except (KeyError, subprocess.CalledProcessError): - raw = subprocess.check_output(['git', 'diff', '--name-only', - 'HEAD~1']) + raw = subprocess.check_output(['git', 'diff', '--name-only', + 'HEAD~1']) return raw.decode().splitlines()