Administration/pmbootstrap-meow
2
0
Fork 0
forked from Mirror/pmbootstrap
Code Pull requests Activity Actions

pmb.chroot.apk.install: fix empty install messages (MR 2185)

Browse source 
Previously pmbootstrap would only show the packages that are about to be
installed. In case all packages were already installed, this would lead
to weird empty install messages:

  (rootfs_asus-me176c) install

Show all packages that we want to install, even if they are already
installed in the given chroot.

  (rootfs_asus-me176c) install device-asus-me176c
This commit is contained in:
Oliver Smith 2022-05-29 11:25:49 +02:00
parent 6a74109154
commit 7b09cc7546
No known key found for this signature in database
GPG key ID: 5AE7F5513E0885CB
1 changed files with 1 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

9
pmb/chroot/apk.py
View file

@ -236,17 +236,10 @@ def install(args, packages, suffix="native", build=True):
if package.startswith("-"):
raise ValueError(f"Invalid package name: {package}")
# Readable install message without dependencies
packages_installed = installed(args, suffix)
message = f"({suffix}) install"
for pkgname in packages:
if pkgname not in packages_installed:
message += f" {pkgname}"
logging.info(message)
to_add_local = packages_get_locally_built_apks(args, to_add, arch)
to_add_no_deps, _ = packages_split_to_add_del(packages)
logging.info(f"({suffix}) install {' '.join(to_add_no_deps)}")
install_run_apk(args, to_add_no_deps, to_add_local, to_del, suffix)