From 95d68d8854faba21aa6761da1c0de801e86109db Mon Sep 17 00:00:00 2001 From: Caleb Connolly Date: Tue, 2 Jul 2024 14:26:31 +0200 Subject: [PATCH] helpers: args: improve please_i_really_need_args() logging (MR 2344) dumping a stack trace directly to the console is not nice, keep it to the log file. Signed-off-by: Caleb Connolly --- pmb/helpers/args.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pmb/helpers/args.py b/pmb/helpers/args.py index dae11901..7a5ee342 100644 --- a/pmb/helpers/args.py +++ b/pmb/helpers/args.py @@ -3,6 +3,7 @@ import pmb.config from pmb.core.context import Context from pmb.core.pkgrepo import pkgrepo_default_path +from pmb.helpers import logging from pmb.types import PmbArgs import pmb.helpers.git import pmb.helpers.args @@ -159,6 +160,6 @@ def init(args: PmbArgs) -> PmbArgs: def please_i_really_need_args() -> PmbArgs: import traceback - traceback.print_stack() - print("FIXME: retrieved args where it shouldn't be needed!") + traceback.print_stack(file=logging.logfd) + logging.warning("FIXME: retrieved args where it shouldn't be needed!") return __args