Administration/pmbootstrap-meow
2
0
Fork 0
forked from Mirror/pmbootstrap
Code Pull requests Activity Actions

core: chroot: validate name for rootfs chroot (MR 2332)

Browse source 
Make sure we get a valid name in the rootfs type chroot.

Signed-off-by: Caleb Connolly <caleb@postmarketos.org>
This commit is contained in:
Caleb Connolly 2024-06-23 21:07:24 +02:00 • committed by Oliver Smith
parent 35eff91564
commit 9daa888f0f
No known key found for this signature in database
GPG key ID: 5AE7F5513E0885CB
1 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
pmb/core/chroot.py
View file

@ -70,6 +70,10 @@ class Chroot:
if self.__type == ChrootType.IMAGE and not Path(self.__name).exists(): if self.__type == ChrootType.IMAGE and not Path(self.__name).exists():
raise ValueError(f"Image file '{self.__name}' does not exist") raise ValueError(f"Image file '{self.__name}' does not exist")
# rootfs suffixes must have a valid device name
if self.__type == ChrootType.ROOTFS and (len(self.__name) < 3 or "-" not in self.__name):
raise ValueError(f"Invalid device name: '{self.__name}'")
def __str__(self) -> str: def __str__(self) -> str:
if len(self.__name) > 0 and self.type != ChrootType.IMAGE: if len(self.__name) > 0 and self.type != ChrootType.IMAGE:
return f"{self.__type.value}_{self.__name}" return f"{self.__type.value}_{self.__name}"