Administration/pmbootstrap-meow
2
0
Fork 0
forked from Mirror/pmbootstrap
Code Pull requests Activity Actions

pmb: Split devices by category during codename selection

Browse source 
This also reworks list_codenames() somewhat. The option to show archived
devices is removed as it never actually was used. It should be easy to
restore if someone is interested.

Closes https://gitlab.postmarketos.org/postmarketOS/pmbootstrap/-/issues/2558

Part-of: https://gitlab.postmarketos.org/postmarketOS/pmbootstrap/-/merge_requests/2549
This commit is contained in:
Newbyte 2025-02-11 18:51:40 +01:00 • committed by Oliver Smith
parent a9c3628297
commit cd672222c4
No known key found for this signature in database
GPG key ID: 5AE7F5513E0885CB
3 changed files with 173 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

23
pmb/config/init.py
View file

@ -497,11 +497,24 @@ def ask_for_device(context: Context) -> tuple[str, bool, str]:
if not pmb.helpers.cli.confirm(default=True):
continue
else:
# Archived devices can be selected, but are not displayed
devices = sorted(pmb.helpers.devices.list_codenames(vendor, archived=False))
# Remove "vendor-" prefixes from device list
codenames = [x.split("-", 1)[1] for x in devices]
logging.info(f"Available codenames ({len(codenames)}): " + ", ".join(codenames))
device_list = "Devices are categorised as follows, from best to worst:\n"
styles = pmb.config.styles
for category in pmb.helpers.devices.DeviceCategory.shown():
device_list += f"* {category.color()}{str(category).capitalize()}{styles['END']}: {category.explain()}.\n"
device_entries = pmb.helpers.devices.list_codenames(vendor)
# Sort devices alphabetically.
device_entries = sorted(
device_entries, key=pmb.helpers.devices.DeviceEntry.codename_without_vendor
)
device_count = len(device_entries)
device_list += f"\nAvailable devices by codename ({device_count}): "
device_strings = []
for device_entry in device_entries:
codenames.append(device_entry.codename_without_vendor())
device_strings.append(str(device_entry))
device_list += ", ".join(device_strings)
logging.info(device_list)
if current_vendor != vendor:
current_codename = ""