Fix #824: Refactor pmb/build/package.py (make depends work like in abuild) (#935)

* Rename pmb/build/package.py to pmb/build/_package.py, so we can
  access the functions it contains in testcases, and still use
  pmb.build.package()
* Refactor the entire file. Instead of one big function that does
  too many things, we have many small ones now, that are tested
  in the testsuite and easier to modify
* Whenever building a package, pmbootstrap does not only build and
  install the "makedepends" (like we did before), now it does the
  same for the "depends". That's required to be compatible with
  abuild. The old behavior can still be used with 'pmbootstrap
  build --ignore-depends'.
* Because of that change, noarch packages can no longer be built in
  the native chroot if we need them for a foreign chroot. A device-
  package depending on a kernel would pull in the same kernel for
  the native architecture otherwise.
* Running 'pmbootstrap build device-...' without '--ignore-depends'
  and without a matching '--arch' displays a note that explains
  this change to the user and tells how to use it instead.
* Noarch packages no longer get symlinked. That was only
  implemented for packages built in the native chroot, and now that
  is not always the case anymore. Symlinking these packages creates
  packages with broken dependencies anyway (e.g.
  device-samsung-i9100 can't be installed in x86_64, because
  linux-samsung-i9100 is armhf only).
* Rename "carch" to "arch" wherever used. Naming it "carch"
  sometimes is confusing with no benefit.
* Add a testcase for the aarch64 qemu workaround (because it failed
  first and I needed to know for sure if it is working again).
* Improved some verbose logging, which helped with development of
  this feature.
* Removed the old "build" test case (which was disabled in
  testcases_fast.sh) as the new "build_package" test case covers its
  functionallity.
* Only build indexes if the packages folder exists for that arch (Travis
  couldn't run a test case otherwise)

pmb/build/other.py

@@ -246,60 +246,22 @@ def index_repo(args, arch=None):
         paths = glob.glob(args.work + "/packages/*")
 
     for path in paths:
-        path_arch = os.path.basename(path)
-        path_repo_chroot = "/home/pmos/packages/pmos/" + path_arch
-        logging.debug("(native) index " + path_arch + " repository")
-        commands = [
-            ["apk", "-q", "index", "--output", "APKINDEX.tar.gz_",
-             "--rewrite-arch", path_arch, "*.apk"],
-            ["abuild-sign", "APKINDEX.tar.gz_"],
-            ["mv", "APKINDEX.tar.gz_", "APKINDEX.tar.gz"]
-        ]
-        for command in commands:
-            pmb.chroot.user(args, command, working_dir=path_repo_chroot)
-        pmb.parse.apkindex.clear_cache(args, args.work + path +
-                                       "/APKINDEX.tar.gz")
-
-
-def symlink_noarch_packages(args):
-    """
-    All noarch packages from the native architecture folder (x86_64 usually)
-    get symlinked to all other architectures.
-    """
-    # Create the arch folders
-    architectures = pmb.config.build_device_architectures
-    logging.debug("Symlink noarch-packages to " + ", ".join(architectures))
-    for arch in architectures:
-        arch_folder = "/mnt/pmbootstrap-packages/" + arch
-        arch_folder_outside = args.work + "/packages/" + arch
-        if not os.path.exists(arch_folder_outside):
-            pmb.chroot.user(args, ["mkdir", "-p", arch_folder])
-
-    # Create an APKINDEX *without* replaced architectures (that is much
-    # faster than reading each apk file with Python!)
-    index = "/tmp/APKINDEX_without_replaced_archs"
-    index_outside = args.work + "/chroot_native" + index
-    pmb.chroot.user(args, ["apk", "-q", "index", "--output", index, "*.apk"],
-                    working_dir="/mnt/pmbootstrap-packages/" + args.arch_native)
-
-    # Iterate over noarch packages
-    for package, data in pmb.parse.apkindex.parse(args, index_outside).items():
-        if data["arch"] != "noarch":
-            continue
-
-        # Create missing symlinks
-        apk_file = data["pkgname"] + "-" + data["version"] + ".apk"
-        for arch in architectures:
-            if os.path.exists(args.work + "/packages/" + arch + "/" + apk_file):
-                continue
-            arch_folder = "/mnt/pmbootstrap-packages/" + arch
-            source = "../" + args.arch_native + "/" + apk_file
-            pmb.chroot.user(args, ["ln", "-sf", source, "."],
-                            working_dir=arch_folder)
-
-    # Rewrite indexes
-    for arch in architectures:
-        index_repo(args, arch)
+        if os.path.exists(path):
+            path_arch = os.path.basename(path)
+            path_repo_chroot = "/home/pmos/packages/pmos/" + path_arch
+            logging.debug("(native) index " + path_arch + " repository")
+            commands = [
+                ["apk", "-q", "index", "--output", "APKINDEX.tar.gz_",
+                 "--rewrite-arch", path_arch, "*.apk"],
+                ["abuild-sign", "APKINDEX.tar.gz_"],
+                ["mv", "APKINDEX.tar.gz_", "APKINDEX.tar.gz"]
+            ]
+            for command in commands:
+                pmb.chroot.user(args, command, working_dir=path_repo_chroot)
+        else:
+            logging.debug("NOTE: Can't build index for non-existing path: " +
+                          path)
+        pmb.parse.apkindex.clear_cache(args, path + "/APKINDEX.tar.gz")
 
 
 def ccache_stats(args, arch):