forked from Mirror/pmbootstrap
`pmbootstrap pkgrel_bump --auto` automatically increases the pkgrel for packages linking against libraries, which don't exist anymore (because the soname has been changed). The feature is explained in detail in The previous implementation did not detect soname breakage, when a subpackage linked against a certain library, but the main package did not (e.g. `qt5-qtbase-mysql` and `qt5-qtbase`). This was, because we iterated over the aports/* to find the packages to be checked. To fix this, we are iterating over the packages found in the APKINDEX files instead (of both the locally compiled packages and the downloaded index from the pmOS mirror). Details: * `pmb/helpers/pkgrel_bump.py`: * Rewrite `auto_apkindex_package()` to act upon a given parsed `aport` and `apk` (from the index) instead of finding the `apk` dict by itself (we need it earlier anyway). * Rewrite `auto()` to iterate over APKINDEX files instead of aports * Skip packages already found, so the `pkgrel` does not get increased multiple times when the same package was found in multipe index files. * Put the package name at the beginning of the log messages to make them more readable * testdata: Create a new `testsubpkg` aport, where only the subpackage links against `testlib` * Adjust testing code to test everything with `testsubpkg` as well. NOTE: This makes the command a bit slower, but we could improve performance again by smart caching of `pmb.parse.apkindex.depends()`. This could come in a future PR, the important part here is that the command is bug-free again with this fix.
174 lines
6.5 KiB
Python
174 lines
6.5 KiB
Python
"""
|
|
Copyright 2018 Oliver Smith
|
|
|
|
This file is part of pmbootstrap.
|
|
|
|
pmbootstrap is free software: you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation, either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
pmbootstrap is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with pmbootstrap. If not, see <http://www.gnu.org/licenses/>.
|
|
"""
|
|
|
|
"""
|
|
This file tests pmb.helper.pkgrel_bump
|
|
"""
|
|
|
|
import glob
|
|
import os
|
|
import pytest
|
|
import sys
|
|
|
|
# Import from parent directory
|
|
pmb_src = os.path.realpath(os.path.join(os.path.dirname(__file__) + "/.."))
|
|
sys.path.append(pmb_src)
|
|
import pmb.helpers.pkgrel_bump
|
|
import pmb.helpers.logging
|
|
|
|
|
|
@pytest.fixture
|
|
def args(request):
|
|
import pmb.parse
|
|
sys.argv = ["pmbootstrap.py", "chroot"]
|
|
args = pmb.parse.arguments()
|
|
args.log = args.work + "/log_testsuite.txt"
|
|
pmb.helpers.logging.init(args)
|
|
request.addfinalizer(args.logfd.close)
|
|
return args
|
|
|
|
|
|
def pmbootstrap(args, tmpdir, parameters, zero_exit=True):
|
|
"""
|
|
Helper function for running pmbootstrap inside the fake work folder (created
|
|
by setup() below) with the binary repo disabled and with the testdata
|
|
configured as aports.
|
|
|
|
:param parameters: what to pass to pmbootstrap, e.g. ["build", "testlib"]
|
|
:param zero_exit: expect pmbootstrap to exit with 0 (no error)
|
|
"""
|
|
# Run pmbootstrap
|
|
aports = tmpdir + "/_aports"
|
|
config = tmpdir + "/_pmbootstrap.cfg"
|
|
|
|
try:
|
|
pmb.helpers.run.user(args, ["./pmbootstrap.py", "--work=" + tmpdir,
|
|
"--mirror-pmOS=", "--aports=" + aports,
|
|
"--config=" + config] + parameters,
|
|
working_dir=pmb_src)
|
|
|
|
# Verify that it exits as desired
|
|
except Exception as exc:
|
|
if zero_exit:
|
|
raise RuntimeError("pmbootstrap failed") from exc
|
|
else:
|
|
return
|
|
if not zero_exit:
|
|
raise RuntimeError("Expected pmbootstrap to fail, but it did not!")
|
|
|
|
|
|
def setup_work(args, tmpdir):
|
|
"""
|
|
Create fake work folder in tmpdir with everything symlinked except for the
|
|
built packages. The aports testdata gets copied to the tempfolder as
|
|
well, so it can be modified during testing.
|
|
"""
|
|
# Clean the chroots, and initialize the build chroot in the native chroot.
|
|
# We do this before creating the fake work folder, because then all packages
|
|
# are still present.
|
|
os.chdir(pmb_src)
|
|
pmb.helpers.run.user(args, ["./pmbootstrap.py", "-y", "zap"])
|
|
pmb.helpers.run.user(args, ["./pmbootstrap.py", "build_init"])
|
|
pmb.helpers.run.user(args, ["./pmbootstrap.py", "shutdown"])
|
|
|
|
# Link everything from work (except for "packages") to the tmpdir
|
|
for path in glob.glob(args.work + "/*"):
|
|
if os.path.basename(path) != "packages":
|
|
pmb.helpers.run.user(args, ["ln", "-s", path, tmpdir + "/"])
|
|
|
|
# Copy testdata and selected device aport
|
|
for folder in ["device", "main"]:
|
|
pmb.helpers.run.user(args, ["mkdir", "-p", args.aports, tmpdir +
|
|
"/_aports/" + folder])
|
|
pmb.helpers.run.user(args, ["cp", "-r", args.aports + "/device/device-" +
|
|
args.device, tmpdir + "/_aports/device"])
|
|
for pkgname in ["testlib", "testapp", "testsubpkg"]:
|
|
pmb.helpers.run.user(args, ["cp", "-r",
|
|
"test/testdata/pkgrel_bump/aports/" + pkgname,
|
|
tmpdir + "/_aports/main/" + pkgname])
|
|
|
|
# Empty packages folder
|
|
pmb.helpers.run.user(args, ["mkdir", "-p", tmpdir + "/packages"])
|
|
pmb.helpers.run.user(args, ["chmod", "777", tmpdir + "/packages"])
|
|
|
|
# Copy over the pmbootstrap config, disable timestamp based rebuilds
|
|
pmb.helpers.run.user(args, ["cp", args.config, tmpdir +
|
|
"/_pmbootstrap.cfg"])
|
|
|
|
|
|
def verify_pkgrels(args, tmpdir, pkgrel_testlib, pkgrel_testapp,
|
|
pkgrel_testsubpkg):
|
|
"""
|
|
Verify the pkgrels of the three test APKBUILDs ("testlib", "testapp",
|
|
"testsubpkg").
|
|
"""
|
|
args.cache["apkbuild"] = {}
|
|
mapping = {"testlib": pkgrel_testlib,
|
|
"testapp": pkgrel_testapp,
|
|
"testsubpkg": pkgrel_testsubpkg}
|
|
for pkgname, pkgrel in mapping.items():
|
|
# APKBUILD path
|
|
path = tmpdir + "/_aports/main/" + pkgname + "/APKBUILD"
|
|
|
|
# Parse and verify
|
|
apkbuild = pmb.parse.apkbuild(args, path)
|
|
assert pkgrel == int(apkbuild["pkgrel"])
|
|
|
|
|
|
def test_pkgrel_bump_high_level(args, tmpdir):
|
|
# Tempdir setup
|
|
tmpdir = str(tmpdir)
|
|
setup_work(args, tmpdir)
|
|
|
|
# Let pkgrel_bump exit normally
|
|
pmbootstrap(args, tmpdir, ["build", "testlib", "testapp", "testsubpkg"])
|
|
pmbootstrap(args, tmpdir, ["pkgrel_bump", "--dry", "--auto"])
|
|
verify_pkgrels(args, tmpdir, 0, 0, 0)
|
|
|
|
# Increase soname (testlib soname changes with the pkgrel)
|
|
pmbootstrap(args, tmpdir, ["pkgrel_bump", "testlib"])
|
|
verify_pkgrels(args, tmpdir, 1, 0, 0)
|
|
pmbootstrap(args, tmpdir, ["build", "testlib"])
|
|
pmbootstrap(args, tmpdir, ["pkgrel_bump", "--dry", "--auto"])
|
|
verify_pkgrels(args, tmpdir, 1, 0, 0)
|
|
|
|
# Delete package with previous soname (--auto-dry exits with >0 now)
|
|
pmb.helpers.run.root(args, ["rm", tmpdir + "/packages/" +
|
|
args.arch_native + "/testlib-1.0-r0.apk"])
|
|
pmbootstrap(args, tmpdir, ["index"])
|
|
pmbootstrap(args, tmpdir, ["pkgrel_bump", "--dry", "--auto"], False)
|
|
verify_pkgrels(args, tmpdir, 1, 0, 0)
|
|
|
|
# Bump pkgrel and build testapp/testsubpkg
|
|
pmbootstrap(args, tmpdir, ["pkgrel_bump", "--auto"])
|
|
verify_pkgrels(args, tmpdir, 1, 1, 1)
|
|
pmbootstrap(args, tmpdir, ["build", "testapp", "testsubpkg"])
|
|
|
|
# After rebuilding, pkgrel_bump --auto-dry exits with 0
|
|
pmbootstrap(args, tmpdir, ["pkgrel_bump", "--dry", "--auto"])
|
|
verify_pkgrels(args, tmpdir, 1, 1, 1)
|
|
|
|
# Test running with specific package names
|
|
pmbootstrap(args, tmpdir, ["pkgrel_bump", "invalid_package_name"], False)
|
|
pmbootstrap(args, tmpdir, ["pkgrel_bump", "--dry", "testlib"], False)
|
|
verify_pkgrels(args, tmpdir, 1, 1, 1)
|
|
|
|
# Clean up
|
|
pmbootstrap(args, tmpdir, ["shutdown"])
|
|
pmb.helpers.run.root(args, ["rm", "-rf", tmpdir])
|