From 00c55d7fb5f7ea7dda9f8e5c250cabed5e1173e1 Mon Sep 17 00:00:00 2001 From: Bruce Luckcuck Date: Sun, 14 Apr 2019 11:30:57 -0400 Subject: [PATCH] Adjust dmin limit logic Previously dmin values would reset to 0 if the user decreased the D value below the current setting for dmin on a given axis. Now adjust the max for the dmin value to be D - 1 and set the dmin value to that. Prevents unexpected resets of dmin to 0 when adjusting the D gains. --- src/js/tabs/pid_tuning.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/js/tabs/pid_tuning.js b/src/js/tabs/pid_tuning.js index 319b293e..61449ede 100644 --- a/src/js/tabs/pid_tuning.js +++ b/src/js/tabs/pid_tuning.js @@ -357,11 +357,12 @@ TABS.pid_tuning.initialize = function (callback) { var dValue = parseInt(dElement.val()); var dMinValue = parseInt(dMinElement.val()); - if (dMinValue >= dValue) { - dMinElement.val(0); + var dMinLimit = dValue > 0 ? dValue - 1 : 0; + if (dMinValue > dMinLimit) { + dMinElement.val(dMinLimit); } - dMinElement.attr("max", dValue > 0? dValue - 1 : 0); + dMinElement.attr("max", dMinLimit); } $('.pid_tuning .ROLL input[name="d"]').change(function() {