From ce4ed0b544cf09b5345e5f8212a8efccd69f497c Mon Sep 17 00:00:00 2001 From: Volodymyr Moskalyk Date: Sat, 14 Oct 2017 17:30:08 +0200 Subject: [PATCH 1/3] Hide Motor PWM Speed Separated from PID Speed when DSHOT selected --- tabs/configuration.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tabs/configuration.js b/tabs/configuration.js index df4bd1d5..d92099ea 100644 --- a/tabs/configuration.js +++ b/tabs/configuration.js @@ -309,16 +309,19 @@ TABS.configuration.initialize = function (callback, scrollPosition) { esc_protocol_e.val(PID_ADVANCED_CONFIG.fast_pwm_protocol + 1); esc_protocol_e.change(function () { + //hide not used setting for DSHOT protocol if ($(this).val() - 1 >= self.DSHOT_PROTOCOL_MIN_VALUE) { $('div.minthrottle').hide(); $('div.maxthrottle').hide(); $('div.mincommand').hide(); + $('div.checkboxPwm').hide(); $('div.digitalIdlePercent').show(); } else { $('div.minthrottle').show(); $('div.maxthrottle').show(); $('div.mincommand').show(); + $('div.checkboxPwm').show(); $('div.digitalIdlePercent').hide(); } From 97212afccb8ba4d9110cc898206774819202975d Mon Sep 17 00:00:00 2001 From: Volodymyr Moskalyk Date: Sun, 15 Oct 2017 09:33:41 +0200 Subject: [PATCH 2/3] Hide Motor PWM Speed Separated from PID Speed when DSHOT selected --- tabs/configuration.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tabs/configuration.js b/tabs/configuration.js index d92099ea..5db538c7 100644 --- a/tabs/configuration.js +++ b/tabs/configuration.js @@ -315,6 +315,8 @@ TABS.configuration.initialize = function (callback, scrollPosition) { $('div.maxthrottle').hide(); $('div.mincommand').hide(); $('div.checkboxPwm').hide(); + //disable unsyncedPWMSwitch to hide Motor PWM frequency input + $('input[id="unsyncedPWMSwitch"]').prop('checked', false).change() $('div.digitalIdlePercent').show(); } else { From 819c4c8a980e23c03a59b4e5c6c0fbc91dd3de0a Mon Sep 17 00:00:00 2001 From: Volodymyr Moskalyk Date: Sun, 15 Oct 2017 15:55:31 +0200 Subject: [PATCH 3/3] Hide Motor PWM Speed Separated from PID Speed when DSHOT selected --- tabs/configuration.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tabs/configuration.js b/tabs/configuration.js index 5db538c7..7f7e19cf 100644 --- a/tabs/configuration.js +++ b/tabs/configuration.js @@ -315,8 +315,7 @@ TABS.configuration.initialize = function (callback, scrollPosition) { $('div.maxthrottle').hide(); $('div.mincommand').hide(); $('div.checkboxPwm').hide(); - //disable unsyncedPWMSwitch to hide Motor PWM frequency input - $('input[id="unsyncedPWMSwitch"]').prop('checked', false).change() + $('div.unsyncedpwmfreq').hide(); $('div.digitalIdlePercent').show(); } else { @@ -324,6 +323,8 @@ TABS.configuration.initialize = function (callback, scrollPosition) { $('div.maxthrottle').show(); $('div.mincommand').show(); $('div.checkboxPwm').show(); + //trigger change unsyncedPWMSwitch to show/hide Motor PWM freq input + $("input[id='unsyncedPWMSwitch']").change(); $('div.digitalIdlePercent').hide(); }