1
0
Fork 0
mirror of https://github.com/betaflight/betaflight-configurator.git synced 2025-07-24 00:35:26 +03:00

Added warning for problematic setpoint transition values.

This commit is contained in:
mikeller 2018-06-05 00:34:20 +12:00
parent ba968fe940
commit 4699e580cf
4 changed files with 28 additions and 5 deletions

View file

@ -1258,6 +1258,9 @@
"pidTuningDtermSetpointHelp": { "pidTuningDtermSetpointHelp": {
"message": "This parameter determines the stick accelerating effect within derivative component.<br> Value of 0 equals to old Measuemenent method where D only tracks gyro, while value of 1 equals to old Error method with equal gyro and stick tracking ratio.<br> Lower value equals to slower/smoother stick response, while higher value provides more stick acceleration response.<br> Note that RC interpolation is recommended to be enabled with higher values to prevent control kicks making noise." "message": "This parameter determines the stick accelerating effect within derivative component.<br> Value of 0 equals to old Measuemenent method where D only tracks gyro, while value of 1 equals to old Error method with equal gyro and stick tracking ratio.<br> Lower value equals to slower/smoother stick response, while higher value provides more stick acceleration response.<br> Note that RC interpolation is recommended to be enabled with higher values to prevent control kicks making noise."
}, },
"pidTuningDtermSetpointTransitionWarning": {
"message": "<span class=\"message-negative\"><strong>Warning:<\/strong> The use of a D Setpoint transition between 0 and 0.1 is highly discouraged. Doing so will lead to a 'jump' around the midpoint of the sticks.<\/span>"
},
"pidTuningProportional": { "pidTuningProportional": {
"message": "Proportional" "message": "Proportional"
}, },

View file

@ -111,11 +111,11 @@ input[type="number"]::-webkit-inner-spin-button {
} }
.message-positive { .message-positive {
color: #ffbb00; color: #ffbb00 !important;
} }
.message-negative { .message-negative {
color: red; color: red !important;
} }
.headerbar { .headerbar {

View file

@ -685,10 +685,23 @@ TABS.pid_tuning.initialize = function (callback) {
var dtermTransitionNumberElement = $('input[name="dtermSetpointTransition-number"]'); var dtermTransitionNumberElement = $('input[name="dtermSetpointTransition-number"]');
var dtermTransitionRangeElement = $('input[name="dtermSetpointTransition-range"]'); var dtermTransitionRangeElement = $('input[name="dtermSetpointTransition-range"]');
var dtermTransitionWarningElement = $('#pid-tuning .dtermSetpointTransitionWarning');
function checkUpdateDtermTransitionWarning(value) {
if (value > 0 && value < 0.1) {
dtermTransitionWarningElement.show();
} else {
dtermTransitionWarningElement.hide();
}
}
checkUpdateDtermTransitionWarning(dtermTransitionNumberElement.val());
dtermTransitionNumberElement.change(function () { dtermTransitionNumberElement.change(function () {
checkUpdateDtermTransitionWarning($(this).val());
dtermTransitionRangeElement.val($(this).val()); dtermTransitionRangeElement.val($(this).val());
}); });
dtermTransitionRangeElement.change(function () { dtermTransitionRangeElement.change(function () {
checkUpdateDtermTransitionWarning($(this).val());
dtermTransitionNumberElement.val($(this).val()); dtermTransitionNumberElement.val($(this).val());
}); });

View file

@ -314,10 +314,16 @@
<span i18n="pidTuningDtermSetpointTransition"></span> <span i18n="pidTuningDtermSetpointTransition"></span>
</label> </label>
<div class="helpicon cf_tip" i18n_title="pidTuningDtermSetpointTransitionHelp"></div> <div class="helpicon cf_tip" i18n_title="pidTuningDtermSetpointTransitionHelp"></div>
</div> </div>
</td> </td>
</tr> </tr>
<td style="height:30px;"><input type="checkbox" id="vbatpidcompensation" class="toggle" /></td> <tr class="dtermSetpointTransitionWarning">
<td colspan="3">
<span i18n="pidTuningDtermSetpointTransitionWarning"></span>
</td>
</tr>
<tr>
<td style="height:30px;"><input type="checkbox" id="vbatpidcompensation" class="toggle" /></td>
<td colspan="2"> <td colspan="2">
<div> <div>
<label for="vbatpidcompensation"> <label for="vbatpidcompensation">
@ -326,6 +332,7 @@
<div class="helpicon cf_tip" i18n_title="pidTuningVbatPidCompensationHelp"></div> <div class="helpicon cf_tip" i18n_title="pidTuningVbatPidCompensationHelp"></div>
</div> </div>
</td> </td>
</tr>
</table> </table>
</div> </div>