1
0
Fork 0
mirror of https://github.com/betaflight/betaflight-configurator.git synced 2025-07-17 21:35:33 +03:00

Fix tcp boot

This commit is contained in:
Mark Haslinghuis 2020-10-29 00:28:29 +01:00
parent 71586c914a
commit 545ec324c0
5 changed files with 235 additions and 243 deletions

View file

@ -211,18 +211,6 @@ const chromeapiSerial = {
chromeCallbackWithError(`SERIAL (adapted from Cordova): ${error}`, callback(info)); chromeCallbackWithError(`SERIAL (adapted from Cordova): ${error}`, callback(info));
}); });
}, },
getControlSignals: function(connectionId, callback) {
// Not supported yet
console.warn('chrome.serial.getControlSignals not supported yet');
chromeCallbackWithSuccess({}, callback);
},
setControlSignals: function(connectionId, signals, callback) {
// Not supported yet
console.warn('chrome.serial.setControlSignals not supported yet');
chromeCallbackWithSuccess({
result: false,
}, callback);
},
// update: function() { }, // update: function() { },
// getConnections: function() { }, // getConnections: function() { },
// flush: function() { }, // flush: function() { },

View file

@ -112,7 +112,8 @@ function closeSerial() {
bufView[3] = 0x74; // t bufView[3] = 0x74; // t
bufView[4] = 0x0D; // enter bufView[4] = 0x0D; // enter
chrome.serial.send(connectionId, bufferOut, function () { const sendFn = (serial.connectionType === 'serial' ? chrome.serial.send : chrome.sockets.tcp.send);
sendFn(connectionId, bufferOut, function () {
console.log('Send exit'); console.log('Send exit');
}); });
@ -139,16 +140,12 @@ function closeSerial() {
bufView[5 + 16] = checksum; bufView[5 + 16] = checksum;
chrome.serial.send(connectionId, bufferOut, function () { sendFn(connectionId, bufferOut, function () {
chrome.serial.disconnect(connectionId, function (result) { serial.disconnect();
console.log(`SERIAL: Connection closed - ${result}`);
});
}); });
}, 100); }, 100);
} else if (connectionId) { } else if (connectionId) {
chrome.serial.disconnect(connectionId, function (result) { serial.disconnect();
console.log(`SERIAL: Connection closed - ${result}`);
});
} }
} }

View file

@ -137,16 +137,22 @@ PortHandler.detectPort = function(currentPorts) {
const newPorts = self.array_difference(currentPorts, self.initialPorts); const newPorts = self.array_difference(currentPorts, self.initialPorts);
if (newPorts.length) { if (newPorts.length) {
// pick last_used_port for manual tcp auto-connect or detect and select new port for serial
currentPorts = self.updatePortSelect(currentPorts); currentPorts = self.updatePortSelect(currentPorts);
console.log(`PortHandler - Found: ${JSON.stringify(newPorts)}`); console.log(`PortHandler - Found: ${JSON.stringify(newPorts)}`);
// select / highlight new port, if connected -> select connected port
if (GUI.connected_to) { ConfigStorage.get('last_used_port', function (result) {
self.portPickerElement.val(GUI.connected_to); if (result.last_used_port) {
if (result.last_used_port.includes('tcp')) {
self.portPickerElement.val('manual');
} else if (newPorts.length === 1) { } else if (newPorts.length === 1) {
self.portPickerElement.val(newPorts[0].path); self.portPickerElement.val(newPorts[0].path);
} else if (newPorts.length > 1) { } else if (newPorts.length > 1) {
self.selectPort(currentPorts); self.selectPort(currentPorts);
} }
}
});
// auto-connect if enabled // auto-connect if enabled
if (GUI.auto_connect && !GUI.connecting_to && !GUI.connected_to) { if (GUI.auto_connect && !GUI.connecting_to && !GUI.connected_to) {
// start connect procedure. We need firmware flasher protection over here // start connect procedure. We need firmware flasher protection over here

View file

@ -1,9 +1,8 @@
'use strict'; 'use strict';
var serial = { const serial = {
connected: false, connected: false,
connectionId: false, connectionId: false,
openRequested: false,
openCanceled: false, openCanceled: false,
bitrate: 0, bitrate: 0,
bytesReceived: 0, bytesReceived: 0,
@ -11,16 +10,14 @@ var serial = {
failed: 0, failed: 0,
connectionType: 'serial', // 'serial' or 'tcp' connectionType: 'serial', // 'serial' or 'tcp'
connectionIP: '127.0.0.1', connectionIP: '127.0.0.1',
connectionPort: 2323, connectionPort: 5761,
transmitting: false, transmitting: false,
outputBuffer: [], outputBuffer: [],
logHead: 'SERIAL: ',
connect: function (path, options, callback) { connect: function (path, options, callback) {
var self = this; const self = this;
var testUrl = path.match(/^tcp:\/\/([A-Za-z0-9\.-]+)(?:\:(\d+))?$/) const testUrl = path.match(/^tcp:\/\/([A-Za-z0-9\.-]+)(?:\:(\d+))?$/);
if (testUrl) { if (testUrl) {
self.connectTcp(testUrl[1], testUrl[2], options, callback); self.connectTcp(testUrl[1], testUrl[2], options, callback);
} else { } else {
@ -28,24 +25,17 @@ var serial = {
} }
}, },
connectSerial: function (path, options, callback) { connectSerial: function (path, options, callback) {
var self = this; const self = this;
self.openRequested = true;
self.connectionType = 'serial'; self.connectionType = 'serial';
self.logHead = 'SERIAL: ';
chrome.serial.connect(path, options, function (connectionInfo) { chrome.serial.connect(path, options, function (connectionInfo) {
if (chrome.runtime.lastError) { if (connectionInfo && !self.openCanceled && !self.checkChromeRunTimeError()) {
console.error(chrome.runtime.lastError.message);
}
if (connectionInfo && !self.openCanceled) {
self.connected = true; self.connected = true;
self.connectionId = connectionInfo.connectionId; self.connectionId = connectionInfo.connectionId;
self.bitrate = connectionInfo.bitrate; self.bitrate = connectionInfo.bitrate;
self.bytesReceived = 0; self.bytesReceived = 0;
self.bytesSent = 0; self.bytesSent = 0;
self.failed = 0; self.failed = 0;
self.openRequested = false;
self.onReceive.addListener(function log_bytesReceived(info) { self.onReceive.addListener(function log_bytesReceived(info) {
self.bytesReceived += info.data.byteLength; self.bytesReceived += info.data.byteLength;
@ -59,23 +49,15 @@ var serial = {
self.getInfo(function (info) { self.getInfo(function (info) {
if (info) { if (info) {
if (!info.paused) { if (!info.paused) {
console.log('SERIAL: Connection recovered from last onReceiveError'); console.log(`${self.connectionType}: connection recovered from last onReceiveError`);
self.failed = 0; self.failed = 0;
} else { } else {
console.log('SERIAL: Connection did not recover from last onReceiveError, disconnecting'); console.log(`${self.connectionType}: connection did not recover from last onReceiveError, disconnecting`);
GUI.log(i18n.getMessage('serialUnrecoverable')); GUI.log(i18n.getMessage('serialUnrecoverable'));
self.errorHandler(info.error, 'receive');
if (GUI.connected_to || GUI.connecting_to) {
$('a.connect').click();
} else {
self.disconnect();
}
} }
} else { } else {
if (chrome.runtime.lastError) { self.checkChromeRunTimeError();
console.error(chrome.runtime.lastError.message);
}
} }
}); });
}); });
@ -91,17 +73,12 @@ var serial = {
if (info) { if (info) {
if (info.paused) { if (info.paused) {
// assume unrecoverable, disconnect // assume unrecoverable, disconnect
console.log('SERIAL: Connection did not recover from ' + self.error + ' condition, disconnecting'); console.log(`${self.connectionType}: connection did not recover from ${self.error} condition, disconnecting`);
GUI.log(i18n.getMessage('serialUnrecoverable')); GUI.log(i18n.getMessage('serialUnrecoverable'));
self.errorHandler(info.error, 'receive');
if (GUI.connected_to || GUI.connecting_to) {
$('a.connect').click();
} else {
self.disconnect();
}
} }
else { else {
console.log('SERIAL: Connection recovered from ' + self.error + ' condition'); console.log(`${self.connectionType}: connection recovered from ${self.error} condition`);
} }
} }
}); });
@ -121,151 +98,123 @@ var serial = {
case 'disconnected': case 'disconnected':
case 'device_lost': case 'device_lost':
default: default:
console.log("serial disconnecting: " + info.error); self.errorHandler(info.error, 'receive');
FC.CONFIG.armingDisabled = false;
FC.CONFIG.runawayTakeoffPreventionDisabled = false;
if (GUI.connected_to || GUI.connecting_to) {
$('a.connect').click();
} else {
self.disconnect();
}
break; break;
} }
}); });
console.log('SERIAL: Connection opened with ID: ' + connectionInfo.connectionId + ', Baud: ' + connectionInfo.bitrate); console.log(`${self.connectionType}: connection opened with ID: ${connectionInfo.connectionId} , Baud: ${connectionInfo.bitrate}`);
if (callback) callback(connectionInfo); if (callback) {
} else if (connectionInfo && self.openCanceled) { callback(connectionInfo);
}
} else {
if (connectionInfo && self.openCanceled) {
// connection opened, but this connect sequence was canceled // connection opened, but this connect sequence was canceled
// we will disconnect without triggering any callbacks // we will disconnect without triggering any callbacks
self.connectionId = connectionInfo.connectionId; self.connectionId = connectionInfo.connectionId;
console.log('SERIAL: Connection opened with ID: ' + connectionInfo.connectionId + ', but request was canceled, disconnecting'); console.log(`${self.connectionType}: connection opened with ID: ${connectionInfo.connectionId} , but request was canceled, disconnecting`);
// some bluetooth dongles/dongle drivers really doesn't like to be closed instantly, adding a small delay // some bluetooth dongles/dongle drivers really doesn't like to be closed instantly, adding a small delay
setTimeout(function initialization() { setTimeout(function initialization() {
self.openRequested = false;
self.openCanceled = false; self.openCanceled = false;
self.disconnect(function resetUI() { self.disconnect(function resetUI() {
if (callback) callback(false); console.log(`${self.connectionType}: connect sequence was cancelled, disconnecting...`);
}); });
}, 150); }, 150);
} else if (self.openCanceled) { } else if (self.openCanceled) {
// connection didn't open and sequence was canceled, so we will do nothing // connection didn't open and sequence was canceled, so we will do nothing
console.log('SERIAL: Connection didn\'t open and request was canceled'); console.log(`${self.connectionType}: connection didn\'t open and request was canceled`);
self.openRequested = false;
self.openCanceled = false; self.openCanceled = false;
if (callback) callback(false);
} else { } else {
self.openRequested = false; console.log(`${self.connectionType}: failed to open serial port`);
console.log('SERIAL: Failed to open serial port'); }
if (callback) callback(false); if (callback) {
callback(false);
}
} }
}); });
}, },
connectTcp: function (ip, port, options, callback) { connectTcp: function (ip, port, options, callback) {
var self = this; const self = this;
self.openRequested = true;
self.connectionIP = ip; self.connectionIP = ip;
self.connectionPort = port || 2323; self.connectionPort = port || 5761;
self.connectionPort = parseInt(self.connectionPort); self.connectionPort = parseInt(self.connectionPort);
self.connectionType = 'tcp'; self.connectionType = 'tcp';
self.logHead = 'SERIAL-TCP: ';
console.log('connect to raw tcp:', ip + ':' + port) chrome.sockets.tcp.create({
chrome.sockets.tcp.create({}, function(createInfo) { persistent: false,
console.log('chrome.sockets.tcp.create', createInfo) name: 'Betaflight',
if (createInfo && !self.openCanceled) { bufferSize: 65535,
}, function(createInfo) {
if (createInfo && !self.openCanceled || !self.checkChromeRunTimeError()) {
self.connectionId = createInfo.socketId; self.connectionId = createInfo.socketId;
self.bitrate = 115200; // fake self.bitrate = 115200; // fake
self.bytesReceived = 0; self.bytesReceived = 0;
self.bytesSent = 0; self.bytesSent = 0;
self.failed = 0; self.failed = 0;
self.openRequested = false;
}
chrome.sockets.tcp.connect(createInfo.socketId, self.connectionIP, self.connectionPort, function (result){ chrome.sockets.tcp.connect(createInfo.socketId, self.connectionIP, self.connectionPort, function (result) {
if (chrome.runtime.lastError) { if (result === 0 || !self.checkChromeRunTimeError()) {
console.error('onConnectedCallback', chrome.runtime.lastError.message); chrome.sockets.tcp.setNoDelay(createInfo.socketId, true, function (noDelayResult) {
} if (noDelayResult === 0 || !self.checkChromeRunTimeError()) {
console.log('onConnectedCallback', result)
if(result == 0) {
self.connected = true;
chrome.sockets.tcp.setNoDelay(createInfo.socketId, true, function (noDelayResult){
if (chrome.runtime.lastError) {
console.error('setNoDelay', chrome.runtime.lastError.message);
}
console.log('setNoDelay', noDelayResult)
if(noDelayResult != 0) {
self.openRequested = false;
console.log(self.logHead + 'Failed to setNoDelay');
}
self.onReceive.addListener(function log_bytesReceived(info) { self.onReceive.addListener(function log_bytesReceived(info) {
if (info.socketId != self.connectionId) return;
self.bytesReceived += info.data.byteLength; self.bytesReceived += info.data.byteLength;
}); });
self.onReceiveError.addListener(function watch_for_on_receive_errors(info) { self.onReceiveError.addListener(function watch_for_on_receive_errors(info) {
console.error(info); if (info.socketId !== self.connectionId) return;
if (info.socketId != self.connectionId) return;
// TODO: better error handle
// error code: https://cs.chromium.org/chromium/src/net/base/net_error_list.h?sq=package:chromium&l=124
switch (info.resultCode) {
case -100: // CONNECTION_CLOSED
case -102: // CONNECTION_REFUSED
if (GUI.connected_to || GUI.connecting_to) {
$('a.connect').click();
} else {
self.disconnect();
}
break;
if (self.connectionType === 'tcp' && info.resultCode < 0) {
self.errorHandler(info.resultCode, 'receive');
} }
}); });
self.connected = true;
console.log(self.logHead + 'Connection opened with ID: ' + createInfo.socketId + ', url: ' + self.connectionIP + ':' + self.connectionPort); console.log(`${self.connectionType}: connection opened with ID ${createInfo.socketId} , url: ${self.connectionIP}:${self.connectionPort}`);
if (callback) callback(createInfo); if (callback) {
callback(createInfo);
}
}
}); });
} else { } else {
self.openRequested = false; console.log(`${self.connectionType}: failed to connect with result ${result}`);
console.log(self.logHead + 'Failed to connect'); if (callback) {
if (callback) callback(false); callback(false);
}
} }
}); });
}
}); });
}, },
disconnect: function (callback) { disconnect: function (callback) {
var self = this; const self = this;
self.connected = false; self.connected = false;
if (self.connectionId) {
self.emptyOutputBuffer(); self.emptyOutputBuffer();
if (self.connectionId) {
// remove listeners // remove listeners
for (var i = (self.onReceive.listeners.length - 1); i >= 0; i--) { for (let i = (self.onReceive.listeners.length - 1); i >= 0; i--) {
self.onReceive.removeListener(self.onReceive.listeners[i]); self.onReceive.removeListener(self.onReceive.listeners[i]);
} }
for (var i = (self.onReceiveError.listeners.length - 1); i >= 0; i--) { for (let i = (self.onReceiveError.listeners.length - 1); i >= 0; i--) {
self.onReceiveError.removeListener(self.onReceiveError.listeners[i]); self.onReceiveError.removeListener(self.onReceiveError.listeners[i]);
} }
var disconnectFn = (self.connectionType == 'serial') ? chrome.serial.disconnect : chrome.sockets.tcp.close; if (self.connectionType === 'tcp') {
disconnectFn(this.connectionId, function (result) { chrome.sockets.tcp.disconnect(self.connectionId, function () {
if (chrome.runtime.lastError) { self.checkChromeRunTimeError();
console.error(chrome.runtime.lastError.message); console.log(`${self.connectionType}: disconnecting socket.`);
});
} }
result = result || self.connectionType == 'tcp' const disconnectFn = (self.connectionType === 'serial') ? chrome.serial.disconnect : chrome.sockets.tcp.close;
if (result) { disconnectFn(self.connectionId, function (result) {
console.log(self.logHead + 'Connection with ID: ' + self.connectionId + ' closed, Sent: ' + self.bytesSent + ' bytes, Received: ' + self.bytesReceived + ' bytes'); self.checkChromeRunTimeError();
} else {
console.log(self.logHead + 'Failed to close connection with ID: ' + self.connectionId + ' closed, Sent: ' + self.bytesSent + ' bytes, Received: ' + self.bytesReceived + ' bytes'); result = result || self.connectionType === 'tcp';
} console.log(`${self.connectionType}: ${result ? 'closed' : 'failed to close'} connection with ID: ${self.connectionId}, Sent: ${self.bytesSent} bytes, Received: ${self.bytesReceived} bytes`);
self.connectionId = false; self.connectionId = false;
self.bitrate = 0; self.bitrate = 0;
@ -292,61 +241,46 @@ var serial = {
}); });
}, },
getInfo: function (callback) { getInfo: function (callback) {
var chromeType = (this.connectionType == 'serial') ? chrome.serial : chrome.sockets.tcp; const chromeType = (this.connectionType === 'serial') ? chrome.serial : chrome.sockets.tcp;
chromeType.getInfo(this.connectionId, callback); chromeType.getInfo(this.connectionId, callback);
}, },
getControlSignals: function (callback) {
if (this.connectionType == 'serial') chrome.serial.getControlSignals(this.connectionId, callback);
},
setControlSignals: function (signals, callback) {
if (this.connectionType == 'serial') chrome.serial.setControlSignals(this.connectionId, signals, callback);
},
send: function (data, callback) { send: function (data, callback) {
var self = this; const self = this;
this.outputBuffer.push({'data': data, 'callback': callback}); self.outputBuffer.push({'data': data, 'callback': callback});
function send() { function _send() {
// store inside separate variables in case array gets destroyed // store inside separate variables in case array gets destroyed
var data = self.outputBuffer[0].data, const _data = self.outputBuffer[0].data;
callback = self.outputBuffer[0].callback; const _callback = self.outputBuffer[0].callback;
if (!self.connected) { if (!self.connected) {
console.log('attempting to send when disconnected'); console.log(`${self.connectionType}: attempting to send when disconnected`);
if (callback) callback({ if (_callback) {
_callback({
bytesSent: 0, bytesSent: 0,
error: 'undefined' error: 'undefined',
}); });
}
return; return;
} }
var sendFn = (self.connectionType == 'serial') ? chrome.serial.send : chrome.sockets.tcp.send; const sendFn = (self.connectionType === 'serial') ? chrome.serial.send : chrome.sockets.tcp.send;
sendFn(self.connectionId, data, function (sendInfo) { sendFn(self.connectionId, _data, function (sendInfo) {
self.checkChromeRunTimeError();
if (sendInfo === undefined) { if (sendInfo === undefined) {
console.log('undefined send error'); console.log('undefined send error');
if (callback) callback({ if (_callback) {
_callback({
bytesSent: 0, bytesSent: 0,
error: 'undefined' error: 'undefined',
}); });
}
return; return;
} }
// tcp send error if (self.connectionType === 'tcp' && sendInfo.resultCode < 0) {
if (self.connectionType == 'tcp' && sendInfo.resultCode < 0) { self.errorHandler(sendInfo.resultCode, 'send');
var error = 'system_error';
// TODO: better error handle
// error code: https://cs.chromium.org/chromium/src/net/base/net_error_list.h?sq=package:chromium&l=124
switch (sendInfo.resultCode) {
case -100: // CONNECTION_CLOSED
case -102: // CONNECTION_REFUSED
error = 'disconnected';
break;
}
if (callback) callback({
bytesSent: 0,
error: error
});
return; return;
} }
@ -354,9 +288,11 @@ var serial = {
self.bytesSent += sendInfo.bytesSent; self.bytesSent += sendInfo.bytesSent;
// fire callback // fire callback
if (callback) callback(sendInfo); if (_callback) {
_callback(sendInfo);
}
// remove data for current transmission form the buffer // remove data for current transmission from the buffer
self.outputBuffer.shift(); self.outputBuffer.shift();
// if there is any data in the queue fire send immediately, otherwise stop trasmitting // if there is any data in the queue fire send immediately, otherwise stop trasmitting
@ -370,32 +306,32 @@ var serial = {
counter++; counter++;
} }
console.log(self.logHead + 'Send buffer overflowing, dropped: ' + counter + ' entries'); console.log(`${self.connectionType}: send buffer overflowing, dropped: ${counter} ${entries}`);
} }
send(); _send();
} else { } else {
self.transmitting = false; self.transmitting = false;
} }
}); });
} }
if (!this.transmitting) { if (!self.transmitting) {
this.transmitting = true; self.transmitting = true;
send(); _send();
} }
}, },
onReceive: { onReceive: {
listeners: [], listeners: [],
addListener: function (function_reference) { addListener: function (function_reference) {
var chromeType = (serial.connectionType == 'serial') ? chrome.serial : chrome.sockets.tcp; const chromeType = (serial.connectionType === 'serial') ? chrome.serial : chrome.sockets.tcp;
chromeType.onReceive.addListener(function_reference); chromeType.onReceive.addListener(function_reference);
this.listeners.push(function_reference); this.listeners.push(function_reference);
}, },
removeListener: function (function_reference) { removeListener: function (function_reference) {
var chromeType = (serial.connectionType == 'serial') ? chrome.serial : chrome.sockets.tcp; const chromeType = (serial.connectionType === 'serial') ? chrome.serial : chrome.sockets.tcp;
for (var i = (this.listeners.length - 1); i >= 0; i--) { for (let i = (this.listeners.length - 1); i >= 0; i--) {
if (this.listeners[i] == function_reference) { if (this.listeners[i] == function_reference) {
chromeType.onReceive.removeListener(function_reference); chromeType.onReceive.removeListener(function_reference);
@ -409,13 +345,13 @@ var serial = {
listeners: [], listeners: [],
addListener: function (function_reference) { addListener: function (function_reference) {
var chromeType = (serial.connectionType == 'serial') ? chrome.serial : chrome.sockets.tcp; const chromeType = (serial.connectionType === 'serial') ? chrome.serial : chrome.sockets.tcp;
chromeType.onReceiveError.addListener(function_reference); chromeType.onReceiveError.addListener(function_reference);
this.listeners.push(function_reference); this.listeners.push(function_reference);
}, },
removeListener: function (function_reference) { removeListener: function (function_reference) {
var chromeType = (serial.connectionType == 'serial') ? chrome.serial : chrome.sockets.tcp; const chromeType = (serial.connectionType === 'serial') ? chrome.serial : chrome.sockets.tcp;
for (var i = (this.listeners.length - 1); i >= 0; i--) { for (let i = (this.listeners.length - 1); i >= 0; i--) {
if (this.listeners[i] == function_reference) { if (this.listeners[i] == function_reference) {
chromeType.onReceiveError.removeListener(function_reference); chromeType.onReceiveError.removeListener(function_reference);
@ -428,5 +364,57 @@ var serial = {
emptyOutputBuffer: function () { emptyOutputBuffer: function () {
this.outputBuffer = []; this.outputBuffer = [];
this.transmitting = false; this.transmitting = false;
},
errorHandler: function (result, direction) {
const self = this;
self.connected = false;
FC.CONFIG.armingDisabled = false;
FC.CONFIG.runawayTakeoffPreventionDisabled = false;
let message = 'error: UNDEFINED';
if (self.connectionType === 'tcp') {
switch (result){
case -15:
// connection is lost, cannot write to it anymore, preventing further disconnect attempts
message = 'error: ERR_SOCKET_NOT_CONNECTED';
console.log(`${self.connectionType}: ${direction} ${message}: ${result}`);
self.connectionId = false;
return;
case -21:
message = 'error: NETWORK_CHANGED';
break;
case -100:
message = 'error: CONNECTION_CLOSED';
break;
case -102:
message = 'error: CONNECTION_REFUSED';
break;
case -105:
message = 'error: NAME_NOT_RESOLVED';
break;
case -106:
message = 'error: INTERNET_DISCONNECTED';
break;
case -109:
message = 'error: ADDRESS_UNREACHABLE';
break;
} }
}
console.log(`${self.connectionType}: ${direction} ${message}: ${result}`);
if (GUI.connected_to || GUI.connecting_to) {
$('a.connect').click();
} else {
self.disconnect();
}
},
checkChromeRunTimeError: function () {
// must be called after each chrome API call
if (chrome.runtime.lastError) {
console.error(chrome.runtime.lastError.message);
return true;
}
return false;
},
}; };

View file

@ -63,7 +63,7 @@ function initializeSerialBackend() {
$('select#baud').hide(); $('select#baud').hide();
} else if (portName !== '0') { } else if (portName !== '0') {
if (!clicks) { if (!clicks) {
console.log(`Connecting to: ${portName}`); console.log(`${serial.connectionType}: connecting to: ${portName}`);
GUI.connecting_to = portName; GUI.connecting_to = portName;
// lock port select & baud while we are connecting / connected // lock port select & baud while we are connecting / connected
@ -216,8 +216,20 @@ function onOpen(openInfo) {
// reset connecting_to // reset connecting_to
GUI.connecting_to = false; GUI.connecting_to = false;
GUI.log(i18n.getMessage('serialPortOpened', serial.connectionType === 'serial' ? [serial.connectionId] : [openInfo.socketId]));
GUI.log(i18n.getMessage('serialPortOpened', [openInfo.connectionId])); // save selected port with chrome.storage if the port differs
ConfigStorage.get('last_used_port', function (result) {
if (result.last_used_port) {
if (result.last_used_port !== GUI.connected_to) {
// last used port doesn't match the one found in local db, we will store the new one
ConfigStorage.set({'last_used_port': GUI.connected_to});
}
} else {
// variable isn't stored yet, saving
ConfigStorage.set({'last_used_port': GUI.connected_to});
}
});
serial.onReceive.addListener(read_serial); serial.onReceive.addListener(read_serial);
@ -226,7 +238,7 @@ function onOpen(openInfo) {
FC.resetState(); FC.resetState();
mspHelper = new MspHelper(); mspHelper = new MspHelper();
MSP.listen(mspHelper.process_data.bind(mspHelper)); MSP.listen(mspHelper.process_data.bind(mspHelper));
console.log(`Requesting configuration data`);
// request configuration data // request configuration data
MSP.send_message(MSPCodes.MSP_API_VERSION, false, false, function () { MSP.send_message(MSPCodes.MSP_API_VERSION, false, false, function () {
analytics.setFlightControllerData(analytics.DATA.API_VERSION, FC.CONFIG.apiVersion); analytics.setFlightControllerData(analytics.DATA.API_VERSION, FC.CONFIG.apiVersion);
@ -799,14 +811,15 @@ function reinitialiseConnection(originatorTab, callback) {
// caveat: Timeouts set with `GUI.timeout_add()` are removed on disconnect. // caveat: Timeouts set with `GUI.timeout_add()` are removed on disconnect.
} else { } else {
GUI.timeout_add('waiting_for_bootup', function waiting_for_bootup() { GUI.timeout_add('waiting_for_bootup', function waiting_for_bootup() {
if (callback) {
callback();
}
MSP.send_message(MSPCodes.MSP_STATUS, false, false, function() { MSP.send_message(MSPCodes.MSP_STATUS, false, false, function() {
GUI.log(i18n.getMessage('deviceReady')); GUI.log(i18n.getMessage('deviceReady'));
originatorTab.initialize(false, $('#content').scrollTop()); originatorTab.initialize(false, $('#content').scrollTop());
}); });
if (callback) {
callback();
}
}, 1500); // 1500 ms seems to be just the right amount of delay to prevent data request timeouts }, 1500); // 1500 ms seems to be just the right amount of delay to prevent data request timeouts
} }
} }