From 5d8958a9a0ae537dd7da1710cf22f28f13910000 Mon Sep 17 00:00:00 2001 From: Kyle K Date: Sun, 21 Jul 2019 00:37:10 +0000 Subject: [PATCH] Fix storage key name for caching the jenkins builds list. Due to regular quotes being used in `jenkins_loader.js` instead of backticks the current JobsData is cached as "${viewUrl}JobsData" "${viewUrl}JobsLastUpdate" Instead of something like: "https://ci.betaflight.tech/view/Firmware_JobsData" "https://ci.betaflight.tech/view/Firmware_JobsLastUpdate" Another idea would be to do "jenkinsJobsData" and "jenkinsJobsLastUpdate" to match with the other cache keys I've chosen to add an underscore in between the URL and the rest of the key to make it easier to look at. --- src/js/jenkins_loader.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/js/jenkins_loader.js b/src/js/jenkins_loader.js index 209fb642..e550b7ce 100644 --- a/src/js/jenkins_loader.js +++ b/src/js/jenkins_loader.js @@ -13,8 +13,8 @@ JenkinsLoader.prototype.loadJobs = function (viewName, callback) { var self = this; var viewUrl = `${self._url}/view/${viewName}`; - var jobsDataTag = '${viewUrl}JobsData'; - var cacheLastUpdateTag = '${viewUrl}JobsLastUpdate'; + var jobsDataTag = `${viewUrl}_JobsData`; + var cacheLastUpdateTag = `${viewUrl}_JobsLastUpdate`; var wrappedCallback = jobs => { self._jobs = jobs;