From c2d8d7225e60dbada5782b38e05e7f1000b0b862 Mon Sep 17 00:00:00 2001 From: Asizon <43983086+Asizon@users.noreply.github.com> Date: Mon, 16 Mar 2020 13:00:36 +0100 Subject: [PATCH 1/2] AG Gain default value to 3.5 add msp rule Improving function --- src/js/tabs/pid_tuning.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/js/tabs/pid_tuning.js b/src/js/tabs/pid_tuning.js index 77fd10b9..88049b92 100644 --- a/src/js/tabs/pid_tuning.js +++ b/src/js/tabs/pid_tuning.js @@ -181,7 +181,13 @@ TABS.pid_tuning.initialize = function (callback) { antiGravitySwitch.change(function() { var checked = $(this).is(':checked'); if (checked) { - $('.antigravity input[name="itermAcceleratorGain"]').val(Math.max(ADVANCED_TUNING.itermAcceleratorGain / 1000, 1.1)); + let itermAcceleratorGain = ADVANCED_TUNING.itermAcceleratorGain / 1000; + if (semver.gte(CONFIG.apiVersion, "1.43.0")) { + itermAcceleratorGain = Math.max(itermAcceleratorGain, 3.5); + } else { + itermAcceleratorGain = Math.max(itermAcceleratorGain, 1.1); + } + $('.antigravity input[name="itermAcceleratorGain"]').val(itermAcceleratorGain); $('.antigravity .suboption').show(); if (ADVANCED_TUNING.antiGravityMode == 0) { $('.antigravity .antiGravityThres').hide(); From 46e3f51d2b17ee5848693a7848803200b394fdce Mon Sep 17 00:00:00 2001 From: Asizon <43983086+Asizon@users.noreply.github.com> Date: Tue, 17 Mar 2020 10:03:28 +0100 Subject: [PATCH 2/2] More Clear --- src/js/tabs/pid_tuning.js | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/js/tabs/pid_tuning.js b/src/js/tabs/pid_tuning.js index 88049b92..85d44eec 100644 --- a/src/js/tabs/pid_tuning.js +++ b/src/js/tabs/pid_tuning.js @@ -181,12 +181,8 @@ TABS.pid_tuning.initialize = function (callback) { antiGravitySwitch.change(function() { var checked = $(this).is(':checked'); if (checked) { - let itermAcceleratorGain = ADVANCED_TUNING.itermAcceleratorGain / 1000; - if (semver.gte(CONFIG.apiVersion, "1.43.0")) { - itermAcceleratorGain = Math.max(itermAcceleratorGain, 3.5); - } else { - itermAcceleratorGain = Math.max(itermAcceleratorGain, 1.1); - } + const MAX_ACCELERATOR_GAIN = semver.gte(CONFIG.apiVersion, "1.43.0") ? 3.5 : 1.1; + const itermAcceleratorGain = Math.max(ADVANCED_TUNING.itermAcceleratorGain / 1000, MAX_ACCELERATOR_GAIN); $('.antigravity input[name="itermAcceleratorGain"]').val(itermAcceleratorGain); $('.antigravity .suboption').show(); if (ADVANCED_TUNING.antiGravityMode == 0) {