Mirror/betaflight-configurator
1
0
Fork 0
mirror of https://github.com/betaflight/betaflight-configurator.git synced 2025-07-25 09:15:49 +03:00
Code Issues Wiki Activity

fix : Global click handler is (re)bound once per field – memory-leak & duplicate callback risk

Browse source
This commit is contained in:
Syahmi Zul 2025-06-14 02:55:51 +08:00
parent aeeda5755f
commit 94b7d301a0
1 changed files with 7 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/js/tabs/osd.js
View file

@ -3625,8 +3625,7 @@ osd.initialize = function (callback) {
};
// Hide all menus function
const hideAllMenus = () => {
$(".osd-context-menu").removeClass("show");
$(".osd-position-grid").removeClass("show");
$(".osd-context-menu, .osd-position-grid").removeClass("show");
};
// Event handlers
let menuTimeout;
@ -3664,8 +3663,12 @@ osd.initialize = function (callback) {
$(this).removeClass("show");
});
// Global click handler to close menus
globalMenuClickHandler = hideAllMenus;
$(document).on("click", globalMenuClickHandler);
if (!globalMenuClickHandler) {
globalMenuClickHandler = () => {
hideAllMenus();
};
$(document).on("click", globalMenuClickHandler);
}
// Make field container relative positioned to contain the absolute positioned menu
$field.css("position", "relative");
// Append all elements