From 024531f8298d1e7083e5f38529a99016ccc77c00 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rodrigo=20P=C3=A9rez?= <rp@qmd.cl>
Date: Tue, 5 Jul 2016 05:50:18 -0400
Subject: [PATCH 1/3] Adds target and firmware version selects to firmware
 flasher tab

Fix for #40
Removed unnecessary request to GitHub API
---
 _locales/en/messages.json  |  16 +++-
 tabs/firmware_flasher.html |  10 ++-
 tabs/firmware_flasher.js   | 176 +++++++++++++++----------------------
 3 files changed, 91 insertions(+), 111 deletions(-)

diff --git a/_locales/en/messages.json b/_locales/en/messages.json
index 340db640..9ea35bd1 100755
--- a/_locales/en/messages.json
+++ b/_locales/en/messages.json
@@ -1366,8 +1366,11 @@
     "firmwareFlasherNoReboot": {
         "message": "No reboot sequence"
     },
-    "firmwareFlasherOnlineReleasesDescription": {
-        "message": "Available online firmware releases - Select the correct firmware appropriate for your board."
+    "firmwareFlasherOnlineSelectBoardDescription": {
+        "message": "Select your board to see available online firmware releases - Select the correct firmware appropriate for your board."
+    },
+    "firmwareFlasherOnlineSelectFirmwareVersionDescription": {
+        "message": "Select firmware version for your board."
     },
     "firmwareFlasherNoRebootDescription": {
         "message": "Enable if you powered your FC while the bootloader pins are jumpered or have your FC's BOOT button pressed."
@@ -1405,6 +1408,15 @@
     "firmwareFlasherOptionLabelSelectFirmware": {
         "message": "Choose a Firmware / Board"
     },
+    "firmwareFlasherOptionLabelSelectBoard": {
+        "message": "Choose a Board"
+    },
+    "firmwareFlasherOptionLabelSelectFirmwareVersion": {
+        "message": "Choose a Firmware version"
+    },
+    "firmwareFlasherOptionLabelSelectFirmwareVersionFor": {
+        "message": "Choose a Firmware version for"
+    },
     "firmwareFlasherButtonLoadLocal": {
         "message": "Load Firmware [Local]"
     },
diff --git a/tabs/firmware_flasher.html b/tabs/firmware_flasher.html
index 6085b794..57b9bc86 100755
--- a/tabs/firmware_flasher.html
+++ b/tabs/firmware_flasher.html
@@ -4,10 +4,16 @@
             <div class="spacer">
                 <table class="cf_table" style="margin-top: 10px;">
                     <tr>
-                        <td><select name="release">
+                        <td><select name="board">
                                 <option value="0">Loading ...</option>
                         </select></td>
-                        <td><span class="description" i18n="firmwareFlasherOnlineReleasesDescription"></span></td>
+                        <td><span class="description" i18n="firmwareFlasherOnlineSelectBoardDescription"></span></td>
+                    </tr>
+                    <tr>
+                        <td><select name="firmware_version">
+                                <option value="0">Loading ...</option>
+                        </select></td>
+                        <td><span class="description" i18n="firmwareFlasherOnlineSelectFirmwareVersionDescription"></span></td>
                     </tr>
                     <tr>
                         <td><label> <input class="updating toggle" type="checkbox" /> <span
diff --git a/tabs/firmware_flasher.js b/tabs/firmware_flasher.js
index 42626d58..603c00f3 100755
--- a/tabs/firmware_flasher.js
+++ b/tabs/firmware_flasher.js
@@ -34,15 +34,25 @@ TABS.firmware_flasher.initialize = function (callback) {
             buildFirmwareOptions();
         });
 
-        var buildFirmwareOptions = function(){
-            var releases_e = $('select[name="release"]').empty();
-            var showDevReleases = ($('input.show_development_releases').is(':checked'));
-            releases_e.append($("<option value='0'>{0}</option>".format(chrome.i18n.getMessage('firmwareFlasherOptionLabelSelectFirmware'))));
+        var buildBoardOptions = function(){
+
+            var boards_e = $('select[name="board"]').empty();
+            var showDevReleases = ($('input.show_development_releases').is(':checked'));
+            boards_e.append($("<option value='0'>{0}</option>".format(chrome.i18n.getMessage('firmwareFlasherOptionLabelSelectBoard'))));
+
+            var versions_e = $('select[name="firmware_version"]').empty();
+            versions_e.append($("<option value='0'>{0}</option>".format(chrome.i18n.getMessage('firmwareFlasherOptionLabelSelectFirmwareVersion'))));
+
+            var releases = {};
+
+            TABS.firmware_flasher.releasesData.forEach(function(release){
+
+                var versionFromTagExpression = /v?(.*)/;
+                var matchVersionFromTag = versionFromTagExpression.exec(release.tag_name);
+                var version = matchVersionFromTag[1];
 
-            var releaseDescriptors = [];
-            TABS.firmware_flasher.releases.forEach(function(release){
                 release.assets.forEach(function(asset){
-                    var targetFromFilenameExpression = /w*_(.*)\.(.*)/;
+                    var targetFromFilenameExpression = /betaflight_([\d.]+)?_?([^.]+)\.(.*)/;
                     var match = targetFromFilenameExpression.exec(asset.name);
 
                     if (!showDevReleases && release.prerelease) {
@@ -53,26 +63,21 @@ TABS.firmware_flasher.initialize = function (callback) {
                         return;
                     }
 
-                    var target = match[1].replace("_", " ");
-                    var format = match[2];
+                    var target = match[2];
+                    var format = match[3];
 
                     if (format != 'hex') {
                         return;
                     }
 
                     var date = new Date(release.published_at);
-                    var formattedDate = "{0}-{1}-{2} {3}:{4}".format(
-                            date.getFullYear(),
-                            date.getMonth() + 1,
-                            date.getDate(),
-                            date.getUTCHours(),
-                            date.getMinutes()
-                    );
+                    var formattedDate = ("0" + date.getDate()).slice(-2) + "-" + ("0"+(date.getMonth()+1)).slice(-2) + "-" +
+    date.getFullYear() + " " + ("0" + date.getHours()).slice(-2) + ":" + ("0" + date.getMinutes()).slice(-2);
 
                     var descriptor = {
                         "releaseUrl": release.html_url,
                         "name"      : semver.clean(release.name),
-                        "version"   : release.name,
+                        "version"   : version,
                         "url"       : asset.browser_download_url,
                         "file"      : asset.name,
                         "target"    : target,
@@ -81,71 +86,56 @@ TABS.firmware_flasher.initialize = function (callback) {
                         "status"    : release.prerelease ? "release-candidate" : "stable"
                     };
 
-                    releaseDescriptors.push(descriptor);
+                    if (typeof releases[target] === "undefined") {
+                        releases[target] = [];
+                        var select_e =
+                                $("<option value='{0}'>{0}</option>".format(
+                                        descriptor.target
+                                )).data('summary', descriptor);
+
+                        boards_e.append(select_e);
+                    }
+                    releases[target].push(descriptor);
                 });
             });
-
-            releaseDescriptors.sort(function(o1,o2){
-                // compare versions descending
-                var oo1 = o1.version.replace(/[^0-9]+/g, "");
-                var oo2 = o2.version.replace(/[^0-9]+/g, "");
-                var cmpVal = (oo2<oo1?-1:(oo2>oo1?1:0));
-                if (cmpVal == 0){
-                    // compare target names ascending
-                    cmpVal = (o1.target<o2.target?-1:(o1.target>o2.target?1:0));
-                }
-                return cmpVal;
-            });
-
-            var optionIndex = 1;
-            releaseDescriptors.forEach(function(descriptor){
-                var select_e =
-                        $("<option value='{0}'>{1} {2} ({3})</option>".format(
-                                descriptor.name,
-                                descriptor.target,
-                                descriptor.date,
-                                descriptor.status
-                        )).data('summary', descriptor);
-
-                releases_e.append(select_e);
-            });
-        };
-
-
-        var processReleases = function (releases){
-            var promises = [];
-            releases.forEach(function(release){
-                var promise = Q.defer();
-                promises.push(promise);
-                $.get(release.assets_url).
-                done(function(assets){
-                            release.assets = assets;
-                            promise.resolve(assets);
-                        }
-                ).
-                fail(function(reason){
-                            promise.reject(reason);
-                        }
-                );
-            });
-
-            Q.all(promises).then(function(){
-                buildFirmwareOptions();
-            })
-        };
-
-        $.get('https://api.github.com/repos/betaflight/betaflight/releases', function (releases){
-            processReleases(releases);
             TABS.firmware_flasher.releases = releases;
+        };
+
+        $.get('https://api.github.com/repos/betaflight/betaflight/releases', function (releasesData){
+            TABS.firmware_flasher.releasesData = releasesData;
+            buildBoardOptions();
 
             // bind events
-            $('select[name="release"]').change(function() {
+            $('select[name="board"]').change(function() {
+                
+                $("a.load_remote_file").addClass('disabled');
+                var target = $(this).val();
+
                 if (!GUI.connect_lock) {
                     $('.progress').val(0).removeClass('valid invalid');
                     $('span.progressLabel').text(chrome.i18n.getMessage('firmwareFlasherLoadFirmwareFile'));
                     $('div.git_info').slideUp();
                     $('div.release_info').slideUp();
                     $('a.flash_firmware').addClass('disabled');
+
+                    var versions_e = $('select[name="firmware_version"]').empty();
+                    if(target == 0) {
+                        versions_e.append($("<option value='0'>{0}</option>".format(chrome.i18n.getMessage('firmwareFlasherOptionLabelSelectFirmwareVersion'))));
+                    } else {
+                        versions_e.append($("<option value='0'>{0} {1}</option>".format(chrome.i18n.getMessage('firmwareFlasherOptionLabelSelectFirmwareVersionFor'), target)));
+                    }
+
+                    TABS.firmware_flasher.releases[target].forEach(function(descriptor) {
+                        var select_e =
+                                $("<option value='{0}'>{0} - {1} - {2} ({3})</option>".format(
+                                        descriptor.version,
+                                        descriptor.target,
+                                        descriptor.date,
+                                        descriptor.status
+                                )).data('summary', descriptor);
+
+                        versions_e.append(select_e);
+                    });
                 }
             });
 
@@ -156,7 +146,6 @@ TABS.firmware_flasher.initialize = function (callback) {
             $('select[name="release"]').empty().append('<option value="0">Offline</option>');
         });
 
-
         // UI Hooks
         $('a.load_file').click(function () {
             chrome.fileSystem.chooseEntry({type: 'openFile', accepts: [{extensions: ['hex']}]}, function (fileEntry) {
@@ -212,7 +201,9 @@ TABS.firmware_flasher.initialize = function (callback) {
         /**
          * Lock / Unlock the firmware download button according to the firmware selection dropdown.
          */
-        $('select[name="release"]').change(function(evt){
+        $('select[name="firmware_version"]').change(function(evt){
+            $('div.release_info').slideUp();
+            $('a.flash_firmware').addClass('disabled');
             if (evt.target.value=="0") {
                 $("a.load_remote_file").addClass('disabled');
             }
@@ -223,7 +214,7 @@ TABS.firmware_flasher.initialize = function (callback) {
 
         $('a.load_remote_file').click(function (evt) {
 
-            if ($('select[name="release"]').val() == "0") {
+            if ($('select[name="firmware_version"]').val() == "0") {
                 GUI.log("<b>No firmware selected to load</b>");
                 return;
             }
@@ -241,38 +232,10 @@ TABS.firmware_flasher.initialize = function (callback) {
 
                         $('a.flash_firmware').removeClass('disabled');
 
-                        if (summary.commit) {
-                            $.get('https://api.github.com/repos/betaflight/betaflight/commits/' + summary.commit, function (data) {
-                                var data = data,
-                                    d = new Date(data.commit.author.date),
-                                    offset = d.getTimezoneOffset() / 60,
-                                    date;
-
-                                date = d.getFullYear() + '.' + ('0' + (d.getMonth() + 1)).slice(-2) + '.' + ('0' + (d.getDate())).slice(-2);
-                                date += ' @ ' + ('0' + d.getHours()).slice(-2) + ':' + ('0' + d.getMinutes()).slice(-2);
-                                date += (offset > 0) ? ' GMT+' + offset : ' GMT' + offset;
-
-                                $('div.git_info .committer').text(data.commit.author.name);
-                                $('div.git_info .date').text(date);
-                                $('div.git_info .hash').text(data.sha.slice(0, 7)).prop('href', 'https://api.github.com/betaflight/betaflight/commit/' + data.sha);
-
-                                $('div.git_info .message').text(data.commit.message);
-
-                                $('div.git_info').slideDown();
-                            });
-                        }
-
                         $('div.release_info .target').text(summary.target);
-
-                        var status_e = $('div.release_info .status');
-                        if (summary.status == 'release-candidate') {
-                            $('div.release_info .status').html(chrome.i18n.getMessage('firmwareFlasherReleaseStatusReleaseCandidate')).show();
-                        } else {
-                            status_e.hide();
-                        }
-
-                        $('div.release_info .name').text(summary.name).prop('href', summary.releaseUrl);
+                        $('div.release_info .name').text(summary.version).prop('href', summary.releaseUrl);
                         $('div.release_info .date').text(summary.date);
+                        $('div.release_info .status').text(summary.status);
                         $('div.release_info .file').text(summary.file).prop('href', summary.url);
 
                         var formattedNotes = summary.notes.trim('\r').replace(/\r/g, '<br />');
@@ -291,8 +254,7 @@ TABS.firmware_flasher.initialize = function (callback) {
                 $('a.flash_firmware').addClass('disabled');
             }
 
-            var summary = $('select[name="release"] option:selected').data('summary');
-
+            var summary = $('select[name="firmware_version"] option:selected').data('summary');
             if (summary) { // undefined while list is loading or while running offline
                 $.get(summary.url, function (data) {
                     process_hex(data, summary);
@@ -357,7 +319,7 @@ TABS.firmware_flasher.initialize = function (callback) {
         });
 
         $(document).on('click', 'span.progressLabel a.save_firmware', function () {
-            chrome.fileSystem.chooseEntry({type: 'saveFile', suggestedName: 'baseflight', accepts: [{extensions: ['hex']}]}, function (fileEntry) {
+            chrome.fileSystem.chooseEntry({type: 'saveFile', suggestedName: 'betaflight', accepts: [{extensions: ['hex']}]}, function (fileEntry) {
                 if (chrome.runtime.lastError) {
                     console.error(chrome.runtime.lastError.message);
                     return;

From 02982378e0698c6137d0b8a4c568a30563d584ee Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rodrigo=20P=C3=A9rez?= <rp@qmd.cl>
Date: Tue, 5 Jul 2016 16:44:08 -0400
Subject: [PATCH 2/3] Sort boards list

---
 tabs/firmware_flasher.js | 55 ++++++++++++++++++++++++++++------------
 1 file changed, 39 insertions(+), 16 deletions(-)

diff --git a/tabs/firmware_flasher.js b/tabs/firmware_flasher.js
index 603c00f3..5d112541 100755
--- a/tabs/firmware_flasher.js
+++ b/tabs/firmware_flasher.js
@@ -44,6 +44,27 @@ TABS.firmware_flasher.initialize = function (callback) {
             versions_e.append($("<option value='0'>{0}</option>".format(chrome.i18n.getMessage('firmwareFlasherOptionLabelSelectFirmwareVersion'))));
 
             var releases = {};
+            var unsortedReleases = {};
+            var sortedTargets = [];
+            var unsortedTargets = [];
+            TABS.firmware_flasher.releasesData.forEach(function(release){
+                release.assets.forEach(function(asset){
+                    var targetFromFilenameExpression = /betaflight_([\d.]+)?_?([^.]+)\.(.*)/;
+                    var match = targetFromFilenameExpression.exec(asset.name);
+
+                    if ((!showDevReleases && release.prerelease) || !match) {
+                        return;
+                    }
+                    var target = match[2];
+                    if($.inArray(target, unsortedTargets) == -1) {
+                        unsortedTargets.push(target);
+                    }
+                });
+                sortedTargets = unsortedTargets.sort();
+            });
+            sortedTargets.forEach(function(release) {
+                releases[release] = [];
+            });
 
             TABS.firmware_flasher.releasesData.forEach(function(release){
 
@@ -55,11 +76,7 @@ TABS.firmware_flasher.initialize = function (callback) {
                     var targetFromFilenameExpression = /betaflight_([\d.]+)?_?([^.]+)\.(.*)/;
                     var match = targetFromFilenameExpression.exec(asset.name);
 
-                    if (!showDevReleases && release.prerelease) {
-                        return;
-                    }
-
-                    if (!match) {
+                    if ((!showDevReleases && release.prerelease) || !match) {
                         return;
                     }
 
@@ -76,7 +93,7 @@ TABS.firmware_flasher.initialize = function (callback) {
 
                     var descriptor = {
                         "releaseUrl": release.html_url,
-                        "name"      : semver.clean(release.name),
+                        "name"      : version,
                         "version"   : version,
                         "url"       : asset.browser_download_url,
                         "file"      : asset.name,
@@ -85,19 +102,25 @@ TABS.firmware_flasher.initialize = function (callback) {
                         "notes"     : release.body,
                         "status"    : release.prerelease ? "release-candidate" : "stable"
                     };
-
-                    if (typeof releases[target] === "undefined") {
-                        releases[target] = [];
-                        var select_e =
-                                $("<option value='{0}'>{0}</option>".format(
-                                        descriptor.target
-                                )).data('summary', descriptor);
-
-                        boards_e.append(select_e);
-                    }
                     releases[target].push(descriptor);
                 });
             });
+            var selectTargets = [];
+            Object.keys(releases)
+                .sort()
+                .forEach(function(target, i) {
+                    var descriptors = releases[target];
+                    descriptors.forEach(function(descriptor){
+                        if($.inArray(target, selectTargets) == -1) {
+                            selectTargets.push(target);
+                            var select_e =
+                                    $("<option value='{0}'>{0}</option>".format(
+                                            descriptor.target
+                                    )).data('summary', descriptor);
+                            boards_e.append(select_e);
+                        }
+                    });
+                });
             TABS.firmware_flasher.releases = releases;
         };
 

From aeb909228efd223aa7289bf3dfb6d37b260d779c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rodrigo=20P=C3=A9rez?= <rp@qmd.cl>
Date: Tue, 5 Jul 2016 16:58:17 -0400
Subject: [PATCH 3/3] Unused var

---
 tabs/firmware_flasher.js | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tabs/firmware_flasher.js b/tabs/firmware_flasher.js
index 5d112541..c50682e1 100755
--- a/tabs/firmware_flasher.js
+++ b/tabs/firmware_flasher.js
@@ -44,7 +44,6 @@ TABS.firmware_flasher.initialize = function (callback) {
             versions_e.append($("<option value='0'>{0}</option>".format(chrome.i18n.getMessage('firmwareFlasherOptionLabelSelectFirmwareVersion'))));
 
             var releases = {};
-            var unsortedReleases = {};
             var sortedTargets = [];
             var unsortedTargets = [];
             TABS.firmware_flasher.releasesData.forEach(function(release){