Mirror/betaflight-configurator
1
0
Fork 0
mirror of https://github.com/betaflight/betaflight-configurator.git synced 2025-07-19 06:15:13 +03:00
Code Issues Wiki Activity

Add tuning slider analytics

Browse source
This commit is contained in:
IvoFPV 2019-09-13 10:22:03 +02:00
parent 8b7f0353e5
commit d2fe165bce
2 changed files with 27 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

29
src/js/tabs/pid_tuning.js
View file

@ -11,6 +11,7 @@ TABS.pid_tuning = {
SETPOINT_WEIGHT_RANGE_HIGH: 20, SETPOINT_WEIGHT_RANGE_HIGH: 20,
SETPOINT_WEIGHT_RANGE_LEGACY: 2.54, SETPOINT_WEIGHT_RANGE_LEGACY: 2.54,
activeSubtab: 'pid', activeSubtab: 'pid',
analyticsChanges: {},
}; };
TABS.pid_tuning.initialize = function (callback) { TABS.pid_tuning.initialize = function (callback) {
@ -1434,6 +1435,8 @@ TABS.pid_tuning.initialize = function (callback) {
// filter and tuning sliders // filter and tuning sliders
TuningSliders.initialize(); TuningSliders.initialize();
self.analyticsChanges = {};
// UNSCALED non expert slider constrain values // UNSCALED non expert slider constrain values
const NON_EXPERT_SLIDER_MAX = 1.25; const NON_EXPERT_SLIDER_MAX = 1.25;
const NON_EXPERT_SLIDER_MIN = 0.7; const NON_EXPERT_SLIDER_MIN = 0.7;
@ -1490,6 +1493,7 @@ TABS.pid_tuning.initialize = function (callback) {
TuningSliders.ResponseSliderValue = scaledValue; TuningSliders.ResponseSliderValue = scaledValue;
} }
TuningSliders.calculateNewPids(); TuningSliders.calculateNewPids();
self.analyticsChanges['PidTuningSliders'] = "On";
}); });
$('#tuningMasterSlider, #tuningPDRatioSlider, #tuningPDGainSlider, #tuningResponseSlider').mousedown(function() { $('#tuningMasterSlider, #tuningPDRatioSlider, #tuningPDGainSlider, #tuningResponseSlider').mousedown(function() {
// adjust step for more smoothness above 1x on mousedown // adjust step for more smoothness above 1x on mousedown
@ -1531,6 +1535,7 @@ TABS.pid_tuning.initialize = function (callback) {
if ($('input[id="useIntegratedYaw"]').is(':checked')) { if ($('input[id="useIntegratedYaw"]').is(':checked')) {
$('input[id="useIntegratedYaw"]').prop('checked', true).click(); $('input[id="useIntegratedYaw"]').prop('checked', true).click();
} }
self.analyticsChanges['PidTuningSliders'] = "On";
}); });
// filter slider inputs // filter slider inputs
@ -1547,9 +1552,11 @@ TABS.pid_tuning.initialize = function (callback) {
if (slider.is('#tuningGyroFilterSlider')) { if (slider.is('#tuningGyroFilterSlider')) {
TuningSliders.gyroFilterSliderValue = scaledValue; TuningSliders.gyroFilterSliderValue = scaledValue;
TuningSliders.calculateNewGyroFilters(); TuningSliders.calculateNewGyroFilters();
self.analyticsChanges['GyroFilterTuningSlider'] = "On";
} else if (slider.is('#tuningDTermFilterSlider')) { } else if (slider.is('#tuningDTermFilterSlider')) {
TuningSliders.dtermFilterSliderValue = scaledValue; TuningSliders.dtermFilterSliderValue = scaledValue;
TuningSliders.calculateNewDTermFilters(); TuningSliders.calculateNewDTermFilters();
self.analyticsChanges['DTermFilterTuningSlider'] = "On";
} }
}); });
$('#tuningGyroFilterSlider, #tuningDTermFilterSlider').mouseup(function() { $('#tuningGyroFilterSlider, #tuningDTermFilterSlider').mouseup(function() {
@ -1576,21 +1583,34 @@ TABS.pid_tuning.initialize = function (callback) {
$('input[id="gyroLowpassEnabled"]').prop('checked', true).click(); $('input[id="gyroLowpassEnabled"]').prop('checked', true).click();
$('input[id="gyroLowpass2Enabled"]').prop('checked', false).click(); $('input[id="gyroLowpass2Enabled"]').prop('checked', false).click();
TuningSliders.resetGyroFilterSlider(); TuningSliders.resetGyroFilterSlider();
self.analyticsChanges['GyroFilterTuningSlider'] = "On";
} }
if (TuningSliders.filterDTermSliderUnavailable) { if (TuningSliders.filterDTermSliderUnavailable) {
$('input[id="dtermLowpassDynEnabled"]').prop('checked', false).click(); $('input[id="dtermLowpassDynEnabled"]').prop('checked', false).click();
$('input[id="dtermLowpassEnabled"]').prop('checked', true).click(); $('input[id="dtermLowpassEnabled"]').prop('checked', true).click();
$('input[id="dtermLowpass2Enabled"]').prop('checked', false).click(); $('input[id="dtermLowpass2Enabled"]').prop('checked', false).click();
TuningSliders.resetDTermFilterSlider(); TuningSliders.resetDTermFilterSlider();
self.analyticsChanges['DTermFilterTuningSlider'] = "On";
} }
}); });
// update on pid table inputs // update on pid table inputs
$('#pid_main input').on('input', () => TuningSliders.updatePidSlidersDisplay()); $('#pid_main input').on('input', function() {
TuningSliders.updatePidSlidersDisplay();
self.analyticsChanges['PidTuningSliders'] = "Off";
});
// update on filter value or type changes // update on filter value or type changes
$('.pid_filter input, .pid_filter select').on('input', () => TuningSliders.updateFilterSlidersDisplay()); $('.pid_filter input, .pid_filter select').on('input', function() {
TuningSliders.updateFilterSlidersDisplay();
if (TuningSliders.filterGyroSliderUnavailable) {
self.analyticsChanges['GyroFilterTuningSlider'] = "Off";
}
if (TuningSliders.filterDTermSliderUnavailable) {
self.analyticsChanges['DTermFilterTuningSlider'] = "Off";
}
});
// update on filter switch changes // update on filter switch changes
$('.inputSwitch input').change(() => TuningSliders.updateFilterSlidersDisplay()); $('.inputSwitch input').change(() => $('.pid_filter input').trigger('input'));
$('.tuningHelp').hide(); $('.tuningHelp').hide();
} else { } else {
@ -1645,6 +1665,9 @@ TABS.pid_tuning.initialize = function (callback) {
GUI.log(i18n.getMessage('pidTuningEepromSaved')); GUI.log(i18n.getMessage('pidTuningEepromSaved'));
}); });
analytics.sendChangeEvents(analytics.EVENT_CATEGORIES.FLIGHT_CONTROLLER, self.analyticsChanges);
self.analyticsChanges = {};
}); });
// Setup model for rates preview // Setup model for rates preview