clean up some more code smells

duplicated CSS selectors

extraneous code.

src/css/tabs/adjustments.css

@@ -21,6 +21,7 @@
 .tab-adjustments .adjustments {
     width: 100%;
     border-spacing: 0px;
+    background-color: #e4e4e4;
 }
 
 .tab-adjustments td {
@@ -56,10 +57,6 @@
     background-color: #f4f4f4;
 }
 
-.tab-adjustments .adjustments {
-    background-color: #e4e4e4;
-}
-
 .tab-adjustments .adjustment select {
     /* outline: 1px solid silver; */
     border-radius: 3px;

src/css/tabs/cli.css

@@ -97,6 +97,9 @@
     border-radius: 5px;
     max-height: 50%;
     overflow: auto;
+    list-style: none;
+    padding: 0;
+    margin: 0;
 }
 
 .cli-textcomplete-dropdown::-webkit-scrollbar {
@@ -121,12 +124,6 @@
     background-color: rgb(255, 187, 0);
 }
 
-.cli-textcomplete-dropdown {
-    list-style: none;
-    padding: 0;
-    margin: 0;
-}
-
 .cli-textcomplete-dropdown a:hover {
     cursor: pointer;
 }

src/css/tabs/configuration.css

@@ -17,7 +17,7 @@
 }
 
 .tab-configuration table td {
-    padding-left: 5px;
+    padding: 5px 3px;
     border-bottom: 1px solid var(--subtleAccent);
 }
 
@@ -26,10 +26,6 @@
     width: 55px;
 }
 
-.tab-configuration table td {
-    padding: 5px 3px;
-}
-
 .tab-configuration table thead tr:first-child {
     background-color: #ececec;
 }

src/css/tabs/failsafe.css

@@ -16,6 +16,16 @@
 .tab-failsafe .number {
     margin-bottom: 5px;
     clear: left;
+    padding-bottom: 5px;
+    border-bottom: 1px solid var(--subtleAccent);
+    width: 100%;
+    float: left;
+}
+
+.tab-failsafe .number:last-child {
+    border-bottom: none;
+    padding-bottom: 0;
+    margin-bottom: 0;
 }
 
 .tab-failsafe .number input {
@@ -149,19 +159,6 @@
     width: calc(100% - 20px);
 }
 
-.tab-failsafe .number {
-    padding-bottom: 5px;
-    border-bottom: 1px solid var(--subtleAccent);
-    width: 100%;
-    float: left;
-}
-
-.tab-failsafe .number:last-child {
-    border-bottom: none;
-    padding-bottom: 0;
-    margin-bottom: 0;
-}
-
 .tab-failsafe .gui_box_titlebar {
     margin-bottom: 0;
 }
@@ -293,6 +290,3 @@
     min-width: 80px;
 }
 
-@media only screen and (max-width: 1055px) , only screen and (max-device-width: 1055px) {
-
-}

src/css/tabs/firmware_flasher.css

@@ -1,6 +1,7 @@
 .tab-firmware_flasher .info {
     padding: 2px 18px;
     position: relative;
+    flex-grow: 100;
 }
 
 .tab-firmware_flasher .info .progressLabel {
@@ -22,10 +23,6 @@
     float: none;
 }
 
-.tab-firmware_flasher .info {
-    flex-grow: 100;
-}
-
 .tab-firmware_flasher .info .progressLabel a {
     color: white;
 }
@@ -54,9 +51,6 @@
     height: 26px;
     border-radius: 5px;
     border: 1px solid var(--subtleAccent);
-}
-
-.tab-firmware_flasher .info .progress {
     -webkit-appearance: none;
 }
 

src/css/tabs/receiver.css

@@ -191,6 +191,7 @@
 
 .tab-receiver .tunings table td {
     border-right: 1px solid var(--subtleAccent);
+    padding: 1px;
 }
 
 .tab-receiver .tunings table td:first-child {
@@ -202,10 +203,6 @@
     border-right: 0px;
 }
 
-.tab-receiver .tunings table td {
-    padding: 1px;
-}
-
 .tab-receiver .tunings table input {
     width: calc(100% - 8px);
     border: 1px solid var(--subtleAccent);

src/js/ConfigInserter.js

@@ -43,8 +43,6 @@ function getCustomDefaultsArea(firmware) {
         return;
     }
 
-    var result = {};
-
     result.startAddress = readUint32(firmware, index);
     result.endAddress = readUint32(firmware, index);
 

src/js/localization.js

@@ -39,9 +39,6 @@ i18n.init = function(cb) {
     });
     // This function should do the same things that the i18n.localizePage function below does.
     i18next.on('languageChanged', function (newLang) {
-      var translate = function(messageID) {
-        return i18n.getMessage(messageID);
-      };
       i18n.localizePage(true);
       updateStatusBarVersion();
     });