From 8171d44bf5b13a2672bab673e220a8bf9473e192 Mon Sep 17 00:00:00 2001 From: Asizon <43983086+Asizon@users.noreply.github.com> Date: Mon, 24 Feb 2020 10:12:04 +0100 Subject: [PATCH 1/3] Hide Esc Sensor for non digital protocols Move to CSS white space Css Fixing --- src/css/tabs/configuration.css | 7 +++++++ src/js/Features.js | 2 +- src/js/tabs/configuration.js | 1 + src/tabs/configuration.html | 7 ++++++- 4 files changed, 15 insertions(+), 2 deletions(-) diff --git a/src/css/tabs/configuration.css b/src/css/tabs/configuration.css index 6a6a899c..2d0be049 100644 --- a/src/css/tabs/configuration.css +++ b/src/css/tabs/configuration.css @@ -58,6 +58,13 @@ font-weight: bold; } +.tab-configuration .featuresMultiple { + border-spacing: 0px; + margin-bottom: 5px; + margin-top: -5px; + padding: 0px; +} + .tab-configuration dl.features dt { float: left; width: 10px; diff --git a/src/js/Features.js b/src/js/Features.js index e4dbc5f6..359215c0 100644 --- a/src/js/Features.js +++ b/src/js/Features.js @@ -78,7 +78,7 @@ var Features = function (config) { if (semver.gte(CONFIG.apiVersion, "1.31.0")) { features.push( {bit: 25, group: 'rxMode', mode: 'select', name: 'RX_SPI'}, - {bit: 27, group: 'esc', name: 'ESC_SENSOR'} + {bit: 27, group: 'escSensor', name: 'ESC_SENSOR'} ); } diff --git a/src/js/tabs/configuration.js b/src/js/tabs/configuration.js index d0708a36..e9c265e9 100644 --- a/src/js/tabs/configuration.js +++ b/src/js/tabs/configuration.js @@ -544,6 +544,7 @@ TABS.configuration.initialize = function (callback, scrollPosition) { $('div.unsyncedpwmfreq').toggle(!digitalProtocol); $('div.digitalIdlePercent').toggle(digitalProtocol); + $('.escSensor').toggle(digitalProtocol); $('div.checkboxDshotBidir').toggle(semver.gte(CONFIG.apiVersion, "1.42.0") && digitalProtocol); $('div.motorPoles').toggle(semver.gte(CONFIG.apiVersion, "1.42.0")); diff --git a/src/tabs/configuration.html b/src/tabs/configuration.html index 723e8ab0..2df1f04e 100644 --- a/src/tabs/configuration.html +++ b/src/tabs/configuration.html @@ -173,11 +173,16 @@ - +
+ + + + +
From bb2ff1b66eb0925460ce59a3090f9cd500f9bd48 Mon Sep 17 00:00:00 2001 From: Asizon <43983086+Asizon@users.noreply.github.com> Date: Thu, 27 Feb 2020 09:10:24 +0100 Subject: [PATCH 2/3] Fixed border collapse --- src/css/tabs/configuration.css | 2 +- src/tabs/configuration.html | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/css/tabs/configuration.css b/src/css/tabs/configuration.css index 2d0be049..dcaeaebc 100644 --- a/src/css/tabs/configuration.css +++ b/src/css/tabs/configuration.css @@ -59,7 +59,7 @@ } .tab-configuration .featuresMultiple { - border-spacing: 0px; + border-collapse: collapse; margin-bottom: 5px; margin-top: -5px; padding: 0px; diff --git a/src/tabs/configuration.html b/src/tabs/configuration.html index 2df1f04e..af1cd667 100644 --- a/src/tabs/configuration.html +++ b/src/tabs/configuration.html @@ -456,7 +456,7 @@

- +
From 346f33d9fb13df8fe44e7075426f0e9a45639c1c Mon Sep 17 00:00:00 2001 From: Asizon <43983086+Asizon@users.noreply.github.com> Date: Thu, 27 Feb 2020 09:50:52 +0100 Subject: [PATCH 3/3] Aplies to gps to fix it --- src/tabs/configuration.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tabs/configuration.html b/src/tabs/configuration.html index af1cd667..fe799191 100644 --- a/src/tabs/configuration.html +++ b/src/tabs/configuration.html @@ -523,7 +523,7 @@
-
+