From 2fcde1cbe8c4eb193c68899585cc9d30d6b3859c Mon Sep 17 00:00:00 2001 From: Michael Keller Date: Tue, 28 May 2019 20:56:24 +1200 Subject: [PATCH] Changed 'timer' output to list timers based on alternate function. (#8320) Changed 'timer' output to list timers based on alternate function. --- src/main/cli/cli.c | 45 ++-- unified_targets/configs/AIRBOTF7.config | 18 +- unified_targets/configs/ALIENFLIGHTF4.config | 40 +-- .../configs/ALIENFLIGHTNGF7.config | 40 +-- .../configs/ALIENFLIGHTNGF7_Dual.config | 40 +-- unified_targets/configs/BEEROTORF4.config | 230 +++++++++--------- unified_targets/configs/CLRACINGF4.config | 21 +- unified_targets/configs/CLRACINGF7.config | 18 +- unified_targets/configs/CRAZYBEEF4FR.config | 27 +- unified_targets/configs/DYSF4PRO.config | 42 ++-- unified_targets/configs/ELINF405.config | 26 +- unified_targets/configs/ELINF722.config | 24 +- unified_targets/configs/EXF722DUAL.config | 33 ++- unified_targets/configs/FF_RACEPIT.config | 18 +- unified_targets/configs/FLYWOOF405.config | 23 +- unified_targets/configs/FLYWOOF411.config | 30 ++- unified_targets/configs/FLYWOOF7DUAL.config | 28 ++- unified_targets/configs/FOXEERF722DUAL.config | 27 +- unified_targets/configs/FURYF4OSD.config | 21 +- .../configs/IFLIGHTF4_TWIN_G.config | 23 +- unified_targets/configs/JHEF7DUAL.config | 27 +- unified_targets/configs/KAKUTEF7.config | 24 +- unified_targets/configs/KAKUTEF7MINI.config | 24 +- unified_targets/configs/MAMBAF722.config | 23 +- unified_targets/configs/MATEKF405.config | 36 ++- unified_targets/configs/MATEKF411.config | 30 ++- unified_targets/configs/MATEKF722.config | 36 ++- unified_targets/configs/MATEKF722SE.config | 41 ++-- unified_targets/configs/NERO.config | 27 +- unified_targets/configs/OMNIBUSF4.config | 46 ++-- unified_targets/configs/OMNIBUSF4FW.config | 45 ++-- .../configs/OMNIBUSF4NANOV7.config | 18 +- unified_targets/configs/OMNIBUSF4SD.config | 45 ++-- unified_targets/configs/OMNIBUSF4V6.config | 42 ++-- .../configs/OMNIBUSF7NANOV7.config | 18 +- unified_targets/configs/OMNIBUSF7V2.config | 36 ++- unified_targets/configs/RUSHCORE7.config | 27 +- unified_targets/configs/SPRACINGF7DUAL.config | 51 ++-- unified_targets/configs/SYNERGYF4.config | 44 ++-- unified_targets/configs/TRANSTECF7.config | 24 +- unified_targets/configs/VGOODRCF4.config | 21 +- unified_targets/configs/VIVAF4AIO.config | 27 +- unified_targets/configs/XILOF4.config | 18 +- 43 files changed, 951 insertions(+), 553 deletions(-) mode change 100755 => 100644 unified_targets/configs/ELINF405.config mode change 100755 => 100644 unified_targets/configs/ELINF722.config mode change 100755 => 100644 unified_targets/configs/FLYWOOF405.config mode change 100755 => 100644 unified_targets/configs/FLYWOOF411.config mode change 100755 => 100644 unified_targets/configs/FLYWOOF7DUAL.config diff --git a/src/main/cli/cli.c b/src/main/cli/cli.c index eba72f7cca..ef1305e181 100644 --- a/src/main/cli/cli.c +++ b/src/main/cli/cli.c @@ -4987,27 +4987,28 @@ static void cliDmaopt(char *cmdline) } char optvalString[DMA_OPT_STRING_BUFSIZE]; - char orgvalString[DMA_OPT_STRING_BUFSIZE]; optToString(optval, optvalString); + + char orgvalString[DMA_OPT_STRING_BUFSIZE]; optToString(orgval, orgvalString); if (optval != orgval) { if (entry) { *optaddr = optval; - cliPrintLinef("dma %s %d: changed from %s to %s", entry->device, DMA_OPT_UI_INDEX(index), orgvalString, optvalString); + cliPrintLinef("# dma %s %d: changed from %s to %s", entry->device, DMA_OPT_UI_INDEX(index), orgvalString, optvalString); } else { #if defined(USE_TIMER_MGMT) timerIoConfig->dmaopt = optval; #endif - cliPrintLinef("dma pin %c%02d: changed from %s to %s", IO_GPIOPortIdxByTag(ioTag) + 'A', IO_GPIOPinIdxByTag(ioTag), orgvalString, optvalString); + cliPrintLinef("# dma pin %c%02d: changed from %s to %s", IO_GPIOPortIdxByTag(ioTag) + 'A', IO_GPIOPinIdxByTag(ioTag), orgvalString, optvalString); } } else { if (entry) { - cliPrintLinef("dma %s %d: no change: %s", entry->device, DMA_OPT_UI_INDEX(index), orgvalString); + cliPrintLinef("# dma %s %d: no change: %s", entry->device, DMA_OPT_UI_INDEX(index), orgvalString); } else { - cliPrintLinef("dma %c%02d: no change: %s", IO_GPIOPortIdxByTag(ioTag) + 'A', IO_GPIOPinIdxByTag(ioTag),orgvalString); + cliPrintLinef("# dma %c%02d: no change: %s", IO_GPIOPortIdxByTag(ioTag) + 'A', IO_GPIOPinIdxByTag(ioTag),orgvalString); } } } @@ -5129,17 +5130,17 @@ static void cliResource(char *cmdline) #ifdef USE_TIMER_MGMT static void printTimerDetails(const ioTag_t ioTag, const unsigned timerIndex, const bool equalsDefault, const dumpFlags_t dumpMask, printFn *printValue) { - const char *format = "timer %c%02d %d"; + const char *format = "timer %c%02d AF%d"; const char *emptyFormat = "timer %c%02d NONE"; if (timerIndex > 0) { + const timerHardware_t *timer = timerGetByTagAndIndex(ioTag, timerIndex); const bool printDetails = printValue(dumpMask, equalsDefault, format, IO_GPIOPortIdxByTag(ioTag) + 'A', IO_GPIOPinIdxByTag(ioTag), - timerIndex - 1 + timer->alternateFunction ); if (printDetails) { - const timerHardware_t *timer = timerGetByTagAndIndex(ioTag, timerIndex); printValue(dumpMask, false, "# pin %c%02d: TIM%d CH%d%s (AF%d)", IO_GPIOPortIdxByTag(ioTag) + 'A', IO_GPIOPinIdxByTag(ioTag), @@ -5214,6 +5215,17 @@ static void printTimer(dumpFlags_t dumpMask) } #define TIMER_INDEX_UNDEFINED -1 +#define TIMER_AF_STRING_BUFSIZE 5 + +static void alternateFunctionToString(const ioTag_t ioTag, const int index, char *buf) +{ + const timerHardware_t *timer = timerGetByTagAndIndex(ioTag, index + 1); + if (!timer) { + memcpy(buf, "NONE", TIMER_AF_STRING_BUFSIZE); + } else { + tfp_sprintf(buf, "AF%d", timer->alternateFunction); + } +} static void cliTimer(char *cmdline) { @@ -5278,12 +5290,11 @@ static void cliTimer(char *cmdline) /* output the list of available options */ const timerHardware_t *timer; for (unsigned index = 0; (timer = timerGetByTagAndIndex(ioTag, index + 1)); index++) { - cliPrintLinef("# %d: TIM%d CH%d%s (AF%d)", - index, + cliPrintLinef("# AF%d: TIM%d CH%d%s", + timer->alternateFunction, timerGetTIMNumber(timer->tim), CC_INDEX_FROM_CHANNEL(timer->channel) + 1, - timer->output & TIMER_OUTPUT_N_CHANNEL ? "N" : "", - timer->alternateFunction + timer->output & TIMER_OUTPUT_N_CHANNEL ? "N" : "" ); } @@ -5325,15 +5336,15 @@ static void cliTimer(char *cmdline) timerIOConfigMutable(timerIOIndex)->dmaopt = DMA_OPT_UNUSED; char optvalString[DMA_OPT_STRING_BUFSIZE]; - optToString(timerIndex, optvalString); + alternateFunctionToString(ioTag, timerIndex, optvalString); char orgvalString[DMA_OPT_STRING_BUFSIZE]; - optToString(oldTimerIndex, orgvalString); + alternateFunctionToString(ioTag, oldTimerIndex, orgvalString); if (timerIndex == oldTimerIndex) { - cliPrintLinef("timer %c%02d: no change: %s", IO_GPIOPortIdxByTag(ioTag) + 'A', IO_GPIOPinIdxByTag(ioTag), orgvalString); + cliPrintLinef("# timer %c%02d: no change: %s", IO_GPIOPortIdxByTag(ioTag) + 'A', IO_GPIOPinIdxByTag(ioTag), orgvalString); } else { - cliPrintLinef("timer %c%02d: changed from %s to %s", IO_GPIOPortIdxByTag(ioTag) + 'A', IO_GPIOPinIdxByTag(ioTag), orgvalString, optvalString); + cliPrintLinef("# timer %c%02d: changed from %s to %s", IO_GPIOPortIdxByTag(ioTag) + 'A', IO_GPIOPinIdxByTag(ioTag), orgvalString, optvalString); } return; @@ -5770,7 +5781,7 @@ const clicmd_t cmdTable[] = { CLI_COMMAND_DEF("tasks", "show task stats", NULL, cliTasks), #endif #ifdef USE_TIMER_MGMT - CLI_COMMAND_DEF("timer", "show/set timers", "<> | list | [