Mirror/betaflight
1
0
Fork 0
mirror of https://github.com/betaflight/betaflight.git synced 2025-07-13 03:20:00 +03:00
Code Issues Wiki Activity

Move DMA IRQ acknowledge to before the callback as it's edge triggered

Browse source
This commit is contained in:
Steve Evans 2025-07-05 14:59:06 +01:00
parent e2159bee89
commit 31e95667c2
1 changed files with 9 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

16
src/platform/PICO/dma_pico.c
View file

@ -63,21 +63,23 @@ void dma_irq_handler(bool isIrq1)
// channel equates to index in the dmaDescriptors array // channel equates to index in the dmaDescriptors array
for (uint8_t channel = 0; channel < DMA_LAST_HANDLER; channel++) { for (uint8_t channel = 0; channel < DMA_LAST_HANDLER; channel++) {
if (status & (1u << channel)) { if (status & (1u << channel)) {
uint8_t index = DMA_CHANNEL_TO_INDEX(channel); // Acknowledge the interrupt for this channel as it is edge, not
// Call the handler if it is set // level triggered and the callback may trigger another DMA
if (dmaDescriptors[index].irqHandlerCallback) {
dmaDescriptors[index].irqHandlerCallback(&dmaDescriptors[index]);
}
// Acknowledge the interrupt for this channel
if (isIrq1) { if (isIrq1) {
dma_channel_acknowledge_irq1(channel); dma_channel_acknowledge_irq1(channel);
} else { } else {
dma_channel_acknowledge_irq0(channel); dma_channel_acknowledge_irq0(channel);
} }
uint8_t index = DMA_CHANNEL_TO_INDEX(channel);
// Call the handler if it is set
if (dmaDescriptors[index].irqHandlerCallback) {
dmaDescriptors[index].irqHandlerCallback(&dmaDescriptors[index]);
}
} }
} }
} }
void dma_irq0_handler(void) void dma_irq0_handler(void)
{ {
dma_irq_handler(false); dma_irq_handler(false);