Mirror/betaflight
1
0
Fork 0
mirror of https://github.com/betaflight/betaflight.git synced 2025-07-20 06:45:16 +03:00
Code Issues Wiki Activity

Simplify blackbox header writing using new printf()

Browse source
This commit is contained in:
Nicholas Sherlock 2015-03-17 22:52:05 +13:00
parent bcadd0803a
commit 3e8ce5833f
2 changed files with 13 additions and 40 deletions
Download patch file Download diff file Expand all files Collapse all files

51
src/main/blackbox/blackbox.c
View file

@ -885,68 +885,41 @@ static bool blackboxWriteSysinfo()
xmitState.u.serialBudget -= blackboxPrint("H Firmware type:Cleanflight\n"); xmitState.u.serialBudget -= blackboxPrint("H Firmware type:Cleanflight\n");
break; break;
case 2: case 2:
blackboxPrintf("H Firmware revision:%s\n", shortGitRevision); xmitState.u.serialBudget -= blackboxPrintf("H Firmware revision:%s\n", shortGitRevision);
xmitState.u.serialBudget -= strlen("H Firmware revision:\n") + strlen(shortGitRevision);
break; break;
case 3: case 3:
blackboxPrintf("H Firmware date:%s %s\n", buildDate, buildTime); xmitState.u.serialBudget -= blackboxPrintf("H Firmware date:%s %s\n", buildDate, buildTime);
xmitState.u.serialBudget -= strlen("H Firmware date: \n") + strlen(buildDate) + strlen(buildTime);
break; break;
case 4: case 4:
blackboxPrintf("H P interval:%d/%d\n", masterConfig.blackbox_rate_num, masterConfig.blackbox_rate_denom); xmitState.u.serialBudget -= blackboxPrintf("H P interval:%d/%d\n", masterConfig.blackbox_rate_num, masterConfig.blackbox_rate_denom);
/* Don't need to be super exact about the budget so don't mind the fact that we're using the length of
* the placeholder "%d" instead of the actual integer size.
*/
xmitState.u.serialBudget -= strlen("H P interval:%d/%d\n");
break; break;
case 5: case 5:
blackboxPrintf("H rcRate:%d\n", masterConfig.controlRateProfiles[masterConfig.current_profile_index].rcRate8); xmitState.u.serialBudget -= blackboxPrintf("H rcRate:%d\n", masterConfig.controlRateProfiles[masterConfig.current_profile_index].rcRate8);
xmitState.u.serialBudget -= strlen("H rcRate:%d\n");
break; break;
case 6: case 6:
blackboxPrintf("H minthrottle:%d\n", masterConfig.escAndServoConfig.minthrottle); xmitState.u.serialBudget -= blackboxPrintf("H minthrottle:%d\n", masterConfig.escAndServoConfig.minthrottle);
xmitState.u.serialBudget -= strlen("H minthrottle:%d\n");
break; break;
case 7: case 7:
blackboxPrintf("H maxthrottle:%d\n", masterConfig.escAndServoConfig.maxthrottle); xmitState.u.serialBudget -= blackboxPrintf("H maxthrottle:%d\n", masterConfig.escAndServoConfig.maxthrottle);
xmitState.u.serialBudget -= strlen("H maxthrottle:%d\n");
break; break;
case 8: case 8:
blackboxPrintf("H gyro.scale:0x%x\n", castFloatBytesToInt(gyro.scale)); xmitState.u.serialBudget -= blackboxPrintf("H gyro.scale:0x%x\n", castFloatBytesToInt(gyro.scale));
xmitState.u.serialBudget -= strlen("H gyro.scale:0x\n") + 6;
break; break;
case 9: case 9:
blackboxPrintf("H acc_1G:%u\n", acc_1G); xmitState.u.serialBudget -= blackboxPrintf("H acc_1G:%u\n", acc_1G);
xmitState.u.serialBudget -= strlen("H acc_1G:%u\n");
break; break;
case 10: case 10:
blackboxPrintf("H vbatscale:%u\n", masterConfig.batteryConfig.vbatscale); xmitState.u.serialBudget -= blackboxPrintf("H vbatscale:%u\n", masterConfig.batteryConfig.vbatscale);
xmitState.u.serialBudget -= strlen("H vbatscale:%u\n");
break; break;
case 11: case 11:
blackboxPrintf("H vbatcellvoltage:%u,%u,%u\n", masterConfig.batteryConfig.vbatmincellvoltage, xmitState.u.serialBudget -= blackboxPrintf("H vbatcellvoltage:%u,%u,%u\n", masterConfig.batteryConfig.vbatmincellvoltage,
masterConfig.batteryConfig.vbatwarningcellvoltage, masterConfig.batteryConfig.vbatmaxcellvoltage); masterConfig.batteryConfig.vbatwarningcellvoltage, masterConfig.batteryConfig.vbatmaxcellvoltage);
xmitState.u.serialBudget -= strlen("H vbatcellvoltage:%u,%u,%u\n");
break; break;
case 12: case 12:
blackboxPrintf("H vbatref:%u\n", vbatReference); xmitState.u.serialBudget -= blackboxPrintf("H vbatref:%u\n", vbatReference);
xmitState.u.serialBudget -= strlen("H vbatref:%u\n");
break; break;
case 13: case 13:
blackboxPrintf("H currentMeter:%d,%d\n", masterConfig.batteryConfig.currentMeterOffset, masterConfig.batteryConfig.currentMeterScale); xmitState.u.serialBudget -= blackboxPrintf("H currentMeter:%d,%d\n", masterConfig.batteryConfig.currentMeterOffset, masterConfig.batteryConfig.currentMeterScale);
xmitState.u.serialBudget -= strlen("H currentMeter:%d,%d\n");
break; break;
default: default:
return true; return true;

2
src/main/common/printf.c
View file

@ -155,7 +155,7 @@ int tfp_format(void *putp, putcf putf, const char *fmt, va_list va)
} }
} }
} }
abort:; abort:
return written; return written;
} }