From 713ba21407959cbe73182a90471218a767da74d1 Mon Sep 17 00:00:00 2001
From: Mark Haslinghuis <mark@numloq.nl>
Date: Mon, 30 Sep 2024 16:11:06 +0200
Subject: [PATCH] Fix custom box names (#13935)

* Fix custom box names

* Review ledvinap
---
 src/main/msp/msp_box.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/src/main/msp/msp_box.c b/src/main/msp/msp_box.c
index 0b41ac1e11..ba70f2dab5 100644
--- a/src/main/msp/msp_box.c
+++ b/src/main/msp/msp_box.c
@@ -142,12 +142,15 @@ int serializeBoxNameFn(sbuf_t *dst, const box_t *box)
     const char* name = NULL;
     int len;
 #if defined(USE_CUSTOM_BOX_NAMES)
-    if (name == NULL
-        && box->boxId >= BOXUSER1 && box->boxId <= BOXUSER4) {
+    if (box->boxId >= BOXUSER1 && box->boxId <= BOXUSER4) {
         const int n = box->boxId - BOXUSER1;
         name = modeActivationConfig()->box_user_names[n];
         // possibly there is no '\0' in boxname
-        len = strnlen(name, sizeof(modeActivationConfig()->box_user_names[0]));
+        if (*name) {
+            len = strnlen(name, sizeof(modeActivationConfig()->box_user_names[n]));
+        } else {
+            name = NULL;
+        }
     }
 #endif
     if (name == NULL) {