From 834345a80c202b98f410da35da76295812188abb Mon Sep 17 00:00:00 2001 From: cTn Date: Wed, 22 Jan 2014 19:55:36 +0100 Subject: [PATCH] master slider, min/max limits, needs more testing fixes #19 --- tabs/motor_outputs.css | 17 +++++++++++++-- tabs/motor_outputs.html | 10 ++++++--- tabs/motor_outputs.js | 46 ++++++++++++++++++++++++++++++++++------- 3 files changed, 61 insertions(+), 12 deletions(-) diff --git a/tabs/motor_outputs.css b/tabs/motor_outputs.css index 26b4a19b66..8838a02281 100644 --- a/tabs/motor_outputs.css +++ b/tabs/motor_outputs.css @@ -64,10 +64,23 @@ .tab-motor_outputs .motor_testing .notice { float: right; - width: 480px; + width: 440px; margin-top: 20px; padding: 5px; border: 1px dotted silver; - } \ No newline at end of file + } + .tab-motor_outputs .motor_testing .notice input[type="number"] { + margin: 0 10px 0 5px; + width: 45px; + + text-align: center; + + border: 1px solid silver; + } + .tab-motor_outputs .motor_testing .notice input[type="checkbox"] { + margin-left: 5px; + + vertical-align: middle; + } \ No newline at end of file diff --git a/tabs/motor_outputs.html b/tabs/motor_outputs.html index 402b0082f0..c7c5e4a3b4 100644 --- a/tabs/motor_outputs.html +++ b/tabs/motor_outputs.html @@ -59,6 +59,7 @@ +
Motor Test Mode Notice:
Moving the sliders will cause the motors to spin up.
- In order to prevent injury you must remove ALL propellers before using this feature.
- If you understand these instructions check the box below to enable motor test mode.
+ In order to prevent injury remove ALL propellers before using this feature.
+ If you understand these instructions check the box below to enable motor test.

- + Min: + Max: + Check:
diff --git a/tabs/motor_outputs.js b/tabs/motor_outputs.js index f139eb1a94..68c94dfdc1 100644 --- a/tabs/motor_outputs.js +++ b/tabs/motor_outputs.js @@ -3,10 +3,23 @@ function tab_initialize_motor_outputs() { GUI.active_tab = 'motor_outputs'; // if CAP_DYNBALANCE is true - if (bit_check(CONFIG.capability, 2)) $('div.motor_testing').show(); + if (bit_check(CONFIG.capability, 2)) { + $('div.motor_testing').show(); + } + + send_message(MSP_codes.MSP_MISC, MSP_codes.MSP_MISC, false, function() { + $('input.min').val(MISC.minthrottle); + $('input.max').val(MISC.maxthrottle); + + + $('div.sliders input').prop('min', MISC.minthrottle); + $('div.sliders input').prop('max', MISC.maxthrottle); + $('div.sliders input').val(MISC.minthrottle); + $('div.values li:not(:last)').html(MISC.minthrottle); + }); // UI hooks - $('div.sliders input').change(function() { + $('div.sliders input:not(.master)').change(function() { var index = $(this).index(); $('div.values li').eq(index).html($(this).val()); @@ -24,22 +37,41 @@ function tab_initialize_motor_outputs() { send_message(MSP_codes.MSP_SET_MOTOR, buffer_out); }); - $('div.notice input').change(function() { + $('div.sliders input.master').change(function() { + var val = $(this).val(); + + $('div.sliders input').val(val); + $('div.sliders input:not(:last)').change(); + }); + + $('div.notice input[type="checkbox"]').change(function() { if ($(this).is(':checked')) { - $('div.sliders input').prop('disabled', false); + $('div.sliders input, .notice input[type="number"]').prop('disabled', false); } else { - // disable sliders - $('div.sliders input').prop('disabled', true); + // disable sliders / min max + $('div.sliders input, .notice input[type="number"]').prop('disabled', true); // change all values to default $('div.sliders input').val(1000); - $('div.values li').html(1000); + $('div.values li:not(:last)').html(1000); // trigger change event so values are sent to mcu $('div.sliders input').change(); } }); + $('div.notice input[type="number"]').change(function() { + var min = parseInt($('div.notice .min').val()); + var max = parseInt($('div.notice .max').val()); + + + $('div.sliders input').prop('min', min); + $('div.sliders input').prop('max', max); + + // trigger change event so values are sent to mcu + $('div.sliders input').change(); + }); + // enable Motor data pulling GUI.interval_add('motor_poll', function() { // Request New data