From 9ea45b7c37901c4c4ef943f2335b85262bf60c1d Mon Sep 17 00:00:00 2001 From: Dominic Clifton Date: Mon, 7 Mar 2022 15:41:20 +0100 Subject: [PATCH] NVIC - Remove outdated comment. Yes, there is a reason to use DMAIRQHandler, so that the WS2811 dma transfer complete handler can update the ws2811LedDataTransferInProgress flag. Potentially though the timer could be left running and restarted when the next led strip update occurs and the dma transfer 'numbers of bytes to transfer' field could be read instead of the ws2811LedDataTransferInProgress flag... --- src/main/drivers/nvic.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/drivers/nvic.h b/src/main/drivers/nvic.h index 1bfb5d5efc..d65e4a9600 100644 --- a/src/main/drivers/nvic.h +++ b/src/main/drivers/nvic.h @@ -36,7 +36,7 @@ #define NVIC_PRIO_MPU_INT_EXTI NVIC_BUILD_PRIORITY(0x0f, 0x0f) #define NVIC_PRIO_MAG_INT_EXTI NVIC_BUILD_PRIORITY(0x0f, 0x0f) -#define NVIC_PRIO_WS2811_DMA NVIC_BUILD_PRIORITY(1, 2) // TODO - is there some reason to use high priority? (or to use DMA IRQ at all?) +#define NVIC_PRIO_WS2811_DMA NVIC_BUILD_PRIORITY(1, 2) // TODO - is there some reason to use high priority? #define NVIC_PRIO_SERIALUART_TXDMA NVIC_BUILD_PRIORITY(1, 1) // Highest of all SERIALUARTx_TXDMA #define NVIC_PRIO_SERIALUART1_TXDMA NVIC_BUILD_PRIORITY(1, 1) #define NVIC_PRIO_SERIALUART1_RXDMA NVIC_BUILD_PRIORITY(1, 1)