mirror of
https://github.com/betaflight/betaflight.git
synced 2025-07-13 11:29:58 +03:00
Improve unittest build system (#13554)
* unittest - fix duplicate symbols in unittests Some symbols were declared again With clang -fcommon, this resulted in allocatin in common segment and prevented error. (tentative definitions in C standard). -fno-common (now default in clang https://reviews.llvm.org/D75056) causes compilation errors. Declarations are now marked extern. * unittest - fix scheduler array size for unittest Unittest needs extra space for canary * unittest - fix missing include (needed for clang-16) * unittest - remove unused varibles -Werror in clang 15+ * unittest - increase max supported version to clang-16 * unittest - conditionaly disable useless output in unittests * unittest - C++11 version of STATIC_ASSERT * unittest - fix initializers for g++ - Change order of initializers to match order in struct - make valueTable initializion consistent (necessary for C++) - adapt controlRateConfig * unittest - adapt scheduler_unitest for g++ scheduler_stubs.c is necessary to initialize task_attributes * unittest - fix ledstrip unittest only part of config was zeroed * unittest - fix g++ warnings - memcpy when length is known and \0 is not copied - isError is local stub, no extern - serialReadStub - don't memcpy into object, use initializer * cli - cleanup cliGetSettingIndex - compare only passed bytes (old version may read data after name) - input string is const * unittest - fix ld warning from PG sections move pg data sections after .rodata. Sections were marked as writable due to relocation (!?). That marked .text output section (containing .pg_data) as writable too and linker correctly complained that executable section is writable. * unittest - cleanup * unittest - adapt after code cleanup, add gcc - remove clang flags that are not necessary now (tested on clang-11 and clang-16) - add support for gcc ( make test CC=gcc CXX=g++ ) - add suport for different optimization level (detects some code problems) : make test OPTIMIZE=-O2 - fallback to clang on Linux too * fixup! unittest - conditionaly disable useless output in unittests
This commit is contained in:
parent
d20d42dd48
commit
d447d795f4
17 changed files with 247 additions and 179 deletions
|
@ -4384,13 +4384,13 @@ static uint8_t getWordLength(char *bufBegin, char *bufEnd)
|
|||
return bufEnd - bufBegin;
|
||||
}
|
||||
|
||||
uint16_t cliGetSettingIndex(char *name, uint8_t length)
|
||||
uint16_t cliGetSettingIndex(const char *name, size_t length)
|
||||
{
|
||||
for (uint32_t i = 0; i < valueTableEntryCount; i++) {
|
||||
const char *settingName = valueTable[i].name;
|
||||
|
||||
// ensure exact match when setting to prevent setting variables with shorter names
|
||||
if (strncasecmp(name, settingName, strlen(settingName)) == 0 && length == strlen(settingName)) {
|
||||
// ensure exact match when setting to prevent setting variables with longer names
|
||||
if (strncasecmp(name, settingName, length) == 0 && length == strlen(settingName)) {
|
||||
return i;
|
||||
}
|
||||
}
|
||||
|
@ -4580,7 +4580,7 @@ STATIC_UNIT_TESTED void cliSet(const char *cmdName, char *cmdline)
|
|||
if (updatable && len > 0 && len <= max) {
|
||||
memset((char *)cliGetValuePointer(val), 0, max);
|
||||
if (len >= min && strncmp(valPtr, emptyName, len)) {
|
||||
strncpy((char *)cliGetValuePointer(val), valPtr, len);
|
||||
memcpy((char *)cliGetValuePointer(val), valPtr, len);
|
||||
}
|
||||
valueChanged = true;
|
||||
} else {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue