From f1a097200265046faf7f4cf95f084eea1b515abe Mon Sep 17 00:00:00 2001 From: Petr Ledvina Date: Tue, 10 Mar 2015 08:32:36 +0100 Subject: [PATCH] Fix incorrect merge in battery_unittest batteryConfig initialization was merged twice, removing one version --- src/test/unit/battery_unittest.cc | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/src/test/unit/battery_unittest.cc b/src/test/unit/battery_unittest.cc index 9ea7131832..2f352f2420 100644 --- a/src/test/unit/battery_unittest.cc +++ b/src/test/unit/battery_unittest.cc @@ -37,10 +37,9 @@ typedef struct batteryAdcToVoltageExpectation_s { TEST(BatteryTest, BatteryADCToVoltage) { - // given - + // batteryInit() reads a bunch of fields including vbatscale, so set up the config with useful initial values: batteryConfig_t batteryConfig = { - .vbatscale = 110, + .vbatscale = VBAT_SCALE_DEFAULT, .vbatmaxcellvoltage = 43, .vbatmincellvoltage = 33, .vbatwarningcellvoltage = 35, @@ -51,14 +50,6 @@ TEST(BatteryTest, BatteryADCToVoltage) .batteryCapacity = 2200, }; - // batteryInit() reads a bunch of fields including vbatscale, so set up the config with useful initial values: - memset(&batteryConfig, 0, sizeof(batteryConfig)); - - batteryConfig.vbatmaxcellvoltage = 43; - batteryConfig.vbatmincellvoltage = 33; - batteryConfig.vbatwarningcellvoltage = 35; - batteryConfig.vbatscale = VBAT_SCALE_DEFAULT; - batteryInit(&batteryConfig); batteryAdcToVoltageExpectation_t batteryAdcToVoltageExpectations[] = {