Mirror/betaflight
1
0
Fork 0
mirror of https://github.com/betaflight/betaflight.git synced 2025-07-15 04:15:44 +03:00
Code Issues Wiki Activity

Updated mode logic to work more intuitively

Browse source 
Any OR macs OR all AND macs required to activate mode
This commit is contained in:
Dave Huber 2019-02-25 21:57:00 -06:00
parent 394807f558
commit fbe42a0646
1 changed files with 34 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

58
src/main/fc/rc_modes.c
View file

@ -78,15 +78,33 @@ bool isRangeActive(uint8_t auxChannelIndex, const channelRange_t *range) {
channelValue < 900 + (range->endStep * 25)); channelValue < 900 + (range->endStep * 25));
} }
void updateMasksForMac(const modeActivationCondition_t *mac, boxBitmask_t *andMask, boxBitmask_t *newMask) /*
* updateMasksForMac:
*
* The following are the possible logic states at each MAC update:
* AND NEW
* --- ---
* F F - no previous AND macs evaluated, no previous active OR macs
* F T - at least 1 previous active OR mac (***this state is latched True***)
* T F - all previous AND macs active, no previous active OR macs
* T T - at least 1 previous inactive AND mac, no previous active OR macs
*/
void updateMasksForMac(const modeActivationCondition_t *mac, boxBitmask_t *andMask, boxBitmask_t *newMask, bool bActive)
{ {
bool bAnd = (mac->modeLogic == MODELOGIC_AND) || bitArrayGet(andMask, mac->modeId); if (bitArrayGet(andMask, mac->modeId) || !bitArrayGet(newMask, mac->modeId)) {
bool bAct = isRangeActive(mac->auxChannelIndex, &mac->range); bool bAnd = mac->modeLogic == MODELOGIC_AND;
if (bAnd) {
bitArraySet(andMask, mac->modeId); if (!bAnd) { // OR mac
} if (bActive) {
if (bAnd != bAct) { bitArrayClr(andMask, mac->modeId);
bitArraySet(newMask, mac->modeId); bitArraySet(newMask, mac->modeId);
}
} else { // AND mac
bitArraySet(andMask, mac->modeId);
if (!bActive) {
bitArraySet(newMask, mac->modeId);
}
}
} }
} }
@ -96,28 +114,18 @@ void updateMasksForStickyModes(const modeActivationCondition_t *mac, boxBitmask_
bitArrayClr(andMask, mac->modeId); bitArrayClr(andMask, mac->modeId);
bitArraySet(newMask, mac->modeId); bitArraySet(newMask, mac->modeId);
} else { } else {
bool bActive = isRangeActive(mac->auxChannelIndex, &mac->range);
if (bitArrayGet(&stickyModesEverDisabled, mac->modeId)) { if (bitArrayGet(&stickyModesEverDisabled, mac->modeId)) {
updateMasksForMac(mac, andMask, newMask); updateMasksForMac(mac, andMask, newMask, bActive);
} else { } else {
if (micros() >= STICKY_MODE_BOOT_DELAY_US && !isRangeActive(mac->auxChannelIndex, &mac->range)) { if (micros() >= STICKY_MODE_BOOT_DELAY_US && !bActive) {
bitArraySet(&stickyModesEverDisabled, mac->modeId); bitArraySet(&stickyModesEverDisabled, mac->modeId);
} }
} }
} }
} }
void updateMasksForLinkedMac(const modeActivationCondition_t *mac, boxBitmask_t *andMask, boxBitmask_t *newMask)
{
bool bAnd = (mac->modeLogic == MODELOGIC_AND) || bitArrayGet(andMask, mac->modeId);
bool bAct = bitArrayGet(andMask, mac->linkedTo) != bitArrayGet(newMask, mac->linkedTo);
if (bAnd) {
bitArraySet(andMask, mac->modeId);
}
if (bAnd != bAct) {
bitArraySet(newMask, mac->modeId);
}
}
void updateActivatedModes(void) void updateActivatedModes(void)
{ {
boxBitmask_t newMask, andMask, stickyModes; boxBitmask_t newMask, andMask, stickyModes;
@ -133,15 +141,17 @@ void updateActivatedModes(void)
if (bitArrayGet(&stickyModes, mac->modeId)) { if (bitArrayGet(&stickyModes, mac->modeId)) {
updateMasksForStickyModes(mac, &andMask, &newMask); updateMasksForStickyModes(mac, &andMask, &newMask);
} else if (mac->modeId < CHECKBOX_ITEM_COUNT) { } else if (mac->modeId < CHECKBOX_ITEM_COUNT) {
updateMasksForMac(mac, &andMask, &newMask); bool bActive = isRangeActive(mac->auxChannelIndex, &mac->range);
updateMasksForMac(mac, &andMask, &newMask, bActive);
} }
} }
// Update linked modes // Update linked modes
for (int i = 0; i < activeLinkedMacCount; i++) { for (int i = 0; i < activeLinkedMacCount; i++) {
const modeActivationCondition_t *mac = modeActivationConditions(activeLinkedMacArray[i]); const modeActivationCondition_t *mac = modeActivationConditions(activeLinkedMacArray[i]);
bool bActive = bitArrayGet(&andMask, mac->linkedTo) != bitArrayGet(&newMask, mac->linkedTo);
updateMasksForLinkedMac(mac, &andMask, &newMask); updateMasksForMac(mac, &andMask, &newMask, bActive);
} }
bitArrayXor(&newMask, sizeof(&newMask), &newMask, &andMask); bitArrayXor(&newMask, sizeof(&newMask), &newMask, &andMask);