* VCP - zero-init USB port in usbVcpOpen
* Serial - serialPortIdentifier_e is signed
* UART - remove unused serialPortCount
* UART - allow compiling spectrum without UART
* UART - minor improvements
closeSerialPort tests for NULL,
no other functional changes
* serial - refactor serial resource handling
- port related resources (tx/rx/inverted,dma)
- are stored sequentially, with space in place of ports that are not
enabled (RESOURCE_UART_COUNT + RESOURCE_LPUART_COUNT +
RESOURCE_SOFTSERIAL_COUNT)
- RESOURCE_UART_OFFSET, RESOURCE_LPUART_OFFSET, RESOURCE_SOFTSERIAL_OFFSET
- resource entries are pointing into this array (UART, LPUART, SOFTSERIAL)
- both pins and DMA
- inverter is supproted only for UART + LPUART (makes sense only
for UART, to be removed)
- softSerialPinConfig is removed, it is no longer necessary
- serialResourceIndex(identifier) is used universally to get correct
index into resource array
- unified handling of resources where possible
- serialOwnerTxRx() + serialOwnerIndex() are used for displaying resources
correctly to user.
- serialType(identifier) implemented
- serialOwnerTxRx / serialOwnerIndex are trivial with it
- large switch() statemens are greatly simplified
* serial - merge code duplicated in all UART implementations
- drivers/serial_uart_hw.c contains merged serialUART code.
Code did not match exactly. Obvious cases are fixed, more complicated
use #ifs
- pin inversion unified
- uartOpen is refactored a bit
* serial - refactor uartDevice
- use 'compressed' enum from uartDeviceIdx_e. Only enabled ports are
in this enum.
- uartDeviceIdx directly indexes uartDevice (no search necessary, no
wasted space)
- use `serialPortIdentifier_e identifier;` for uartHardware
- for DMA remap, define only entries for enabled ports (uartDeviceIdx_e
does not exist disabled port)
* serial - apply changes to inverter
New implementation is trivial
* serial - HAL - rxIrq, txIrq replaces by irqn
There is only one IRQ for serial
* serial - serial_post.h
Generated code to normalize target configuration.
jinja2 template is used to generate header file. Port handling is
unified a lot.
SERIAL_<type><n>_USED 0/1 - always defined, value depends on target configuration
SERIAL_<type>_MASK - bitmask of used ports or given type. <port>1 is BIT(0)
SERIAL_<type>_COUNT - number of enabled ports of given type
SERIAL_<type>_MAX - <index of highest used port> + 1, 0 when no port is enabled
* targets - remove automatically calculated valued from configs
serial_post.h generated it
* serial - remove definitions replaced by serial_post.h
* serial - change LPUART to UART_LP1 in places
LPUART is mostly handled as another UART port, this change reflects it
* serial - use ARRAYLEN / ARRAYEND in some places
replaces constant that may not match actual array size
* serial - adapt softserial to changes
* serial - whitespace, comments
* softserial - fix serialTimerConfigureTimebase
* serial - suspicious code
* serial - unittests
* serial - cleanup
* serial - simpler port names
Is this useful ?
* serial - no port count for SITL necessary
* serial - fix unittests
include serial_post.h, some ports are defined, so normalization will
work fine
* timers - remove obsolete defines from SITL and unittests
* serial - cosmetic improvements
comments, whitespace, minor refactoring
* serial - fix serialInit bug
serialPortToDisable was preventing further tests
* serial - fix possible NULL pointer dereference
* serial - move serialResourceIndex to drivers
* serial - refactor pp/od and pulldown/pullup/nopull
Centralize serial options handling, decouple it from MCU type
Move some code into new drivers/serial_impl.c
* serial - make port.identifier valid early in port initialization
* serial - fix unittest
Code is moved around a bit to make unittests implementation easier
* serial - bug - fix off-by-one error
uart1/softserial1/lpuart was not working properly because of this
* serial - whipespace + formating + style + comments
No functional changes
* utils - add popcount functions
Wrap __builtin_popcount for easier use. Refactor existing code using
it. Update code using BITCOUNT macro in dynamic context (BITCOUNT is
for compile-time use only)
* serial - inverter - simplify code
* pinio - prevent array access overflow
* serial - refactor SERIAL_BIDIR_*
SERIAL_BIDIR_OD / SERIAL_BIDIR_PP
SERIAL_PULL_DEFAULT / SERIAL_PULL_NONE / SERIAL_PULL_PD
* serial - simplify code
minor refactoring
- cleaner AVOID_UARTx_FOR_PWM_PPM (unused anyway)
- serialFindPortConfiguration* - remove code duplication
- use serialType in smartaudio
* serial - add port names
- const string is assiociated with each compiled-in port (easy to pass around)
- findSerialPortByName
* cli - improve serialpassthrough
- support port options (in current mode argument)
- support port names (`serialpassthrough uart1`)
- improve error handling; check more parse errors
* cli - resources - minor refactor
- prevent SERIAL_TX_NONSENSE when parsing resource type
- fix possible NULL pointer dereference
- store resource tag only after checking all conditions
- slighty better error reporting
- `resource serial_tx 1` will print resource assignment
* serial - remane pulldown to SERIAL_PULL_SMARTAUDIO
Make sure nobody uses it by
mistake. SERIAL_PULL_SMARTAUDIO_SUPER_DANGEROUS_USE_AT_YOUR_OWN_RISK_THIS_WILL_BREAK_EVERYTHING_AND_KILL_YOUR_PET_FISH
would be better choice, but try shorter version first.
* smartaudio - minor refactor/improvement
- Fix softserial on AT32
- make it easier to handle SA on per-cpu basis
* softserial - minor refactoring
no functional changes
* UART - move AF handling before MCU dependent code
* UART - adapt APM32 / APM32F4 code
- Modeled after F4 where possible
- come code moved from APM32 to APM32F4, possbily not necessary, but
it improves similarity with STM32F4
* UART - APM32 - remove per-pin AF
* UART - APM32 - bugfix - fix pinswap #if conditions
* UART - apply some improvemnts from APM32 to STM32
* UART - add todo for F4 serial speed
* UART - fix typo
* UART - refactor support for USE_SMARTAUDIO_NOPULLDOWN
* UART - typos, comments, minor improvements
* UART - move code into enableRxIrq
TODO: split into mcu-specific filer (but in sepatate PR)
* UART - add UART_TRAIT_xx
makes #if test easier and more consistent
more traits shall follow
* UART - fix variable name
unused branch, would trigger compilation error otherwise
* UART - use tables instead of switch
* UART - smartaudio
minor style change + better comments
* UART - unify mspPorts iteration
* UART - fix spelling
* UART - another typo
* UART - fix serialResourceIndex
offset must be added, not subtracted
offset can be negative
* UART - fix typo
Bad day ...
* UART - use const table
GCC does optimize it better.
Should not cause functional change
* UART - use OwnerIndex for inverter
- 1 based
- only UART has inversion
* UART - refactor serial_resource a bit
Single table + helper function. New table is easier to read
* UART - serial_impl header is necessary
* UART - style-only changes
typos
unify whitespace
comment improvement
add some const modifiers
use cfg in uartConfigureDma
minor improvemnt of for loops
* UART - remove LPUART inverter
LPUART always supports internal inversion, code was incomplete and
unused
* UART - update jinja template, regenerate files
* UART - enable UART module RCC clk before configuring DMA
Does not change anything, UART RCCs are enabled unconditionally
* Yaw type rudder or diff_thrust for TPA calculations (for wings)
* Added yaw_type to blackbox header
* KarateBrot review
* KarateBrot break
Co-authored-by: Jan Post <Rm2k-Freak@web.de>
---------
Co-authored-by: Jan Post <Rm2k-Freak@web.de>
* use wasThrottleRaised in place of isAirmodeActivated where airmode isn't really needed
* fix unit test
* fix typo
* remove unnecessary check
* final changes and clarificartions
* Update src/main/flight/mixer.c
Co-authored-by: Ivan Efimov <gendalf44@yandex.ru>
---------
Co-authored-by: Mark Haslinghuis <mark@numloq.nl>
Co-authored-by: Ivan Efimov <gendalf44@yandex.ru>
* Altitude control code shared
fewer debugs
subtract D
* remove #include comments, simplify coding, restructuring
thanks JP and MH
* fix cms limits for throttle control
* Use altitude_control debug, fix throttle calculation
minor refactoring
* use AUTO_CONTROL_ALTITUDE debug in place of GPS Rescue throttle pid
* use autopilot for position control names
* fixes from reviews - thanks
* Re-organise included files and functions thanks Karate
* missed init and other typos
* remove old unused unit test file, tidy up thanks Mark
* fix indentation on one line
* tpa speed speed estimation (for wings)
* Some renaming based on Karatebrot review
* Fix with currentPidProfile
* Ledvinap's review
* minor fixes
* Karatebrot and ledvinap review
* Review by haslinghuis
* use idleOffset, simplify idle : check PWM idle
* remove get for dshot idle and calculate it once only
* fixes from reviews, thanks
* use motor_idle for CLI name
* use motorConfig->motorIdle not idleOffset
* rename dshotmotorIdle variable to motorIdlePercent
* small comment improvement
* stop motors after 90 degrees of rotation and with max rate
* handle no accelerometer data
* improve check for acc, although seems to be OK without it
* disable all attenuation if rate is set to zero
* refactoring thanks Karate
* use sensors.h
* remove unnecessary arming check
* exit crashFlip immediately switch is reverted if throttle is zero
* add Crashflip Rate to OSD
* Revert unnecessary changes in crashflip core.c code
and clarify comments about crashflip switch
* update / minimise comments, thanks Karate
* ensure all names say `crashflip` consistently
* Undo quick re-arm because motrors were not reversed
* fix issue with reversed motors, we must disarm
* ignore yaw rotation and set gyro limit to 1900 deg/s
* default attenuation to off (crashflip_rate = 0)
* refactoring, increase rate limit to allow stronger inhibition
* enable in race_pro mode
* don't attenuate on attitude until a significant change occurs
* no attenuation for small changes
* Updates from review by PL
* remove whitespace
* refactor motorOutput, update comments, renaming variables
thanks PL
* changes from review PL
* only permit fast re-arm if crashflip rate set and crashflip was successful
* properly exit turtle mode
* add crashFlipSuccessful to unit test extern c
* small updates from review
* improved crashflip switch handling
* remove unnecessary motors normal check
* RX task update rate to 22Hz, to improve 25Hz link stability
* modified Rx code
* add LQ to debug
* use max of frameAge or FrameDelta
* Require a dropouit of 200ms, not 100ms, before RXLOSS
* remove FrameAge, use 150ms timeout 50ms checks
* fix tests and tidy up the comments
* Handle NULL input as before, log frame time
* possible solutions to review comment about names
* Remove rxFrameTimeUs
- prepare for direct use of lastRcFrameTimeUs
- refactor rx_spi callback
* remove global currentRxRateHz
* simplify updateRcRefreshRate
* re-name to recheck interval, return frame time debug
* Calculate RxRate only once
* use rxReceivingSignal for consistency
* use signalReceived not rxDataReceived for consistency
* suggestions from review PL
* move defines, thanks K
* fixes from review, thanks MH
* review changes, undo task interval change
rename bool rxIsReceivingSignal to isRxReceivingSignal
thanks Steve for resolving that tasks changes are not needed
thanks PL for your feedback also
---------
Co-authored-by: Petr Ledvina <ledvinap@hp124.ekotip.cz>
* Give a -n option to exit CLI
- means you can set any serial port to MSP, and then activate CLI on it using #, with an "exit -n" to return to MSP mode without a reboot required.
- https://webserial.io is a great utility for using CLI outside the configurator.
- future changes will include possible multiple CLIs being active at the same time, along with debug printf from anywhere in the code to an active debug cli.
* Altered to strcasecmp, and changed param required to noreboot
* Adding additional details to the commands
* rename dMin, remove D_MIN_GAIN_MAX
* rename vars
* fix logic
* fix logic
* Revert "fix tests"
This reverts commit c518c9c444.
* Revert "add yaw and other adjustment cases"
This reverts commit 2cacd4b360.
* Revert "fix unit test"
This reverts commit 3d88f4158a.
* Revert "fix D adjustments change dmax instead of D"
This reverts commit 7ee4e7f8af.
* Revert "Fix telemetry for Spektrum/SRXL (#13814)"
This reverts commit 04fe4b4461.
* review adjustments and test fixes
* Reapply "Fix telemetry for Spektrum/SRXL (#13814)"
This reverts commit eb7f8ee0fd.
* fix logic
* Apply suggestions from code review
Co-authored-by: Jan Post <Rm2k-Freak@web.de>
Co-authored-by: Mark Haslinghuis <mark@numloq.nl>
* fix d_max slider
---------
Co-authored-by: Jan Post <Rm2k-Freak@web.de>
Co-authored-by: Mark Haslinghuis <mark@numloq.nl>
* added turn on 'storage device mode' action in OSD Blackbox menu
* Code style improvement
Co-authored-by: Mark Haslinghuis <mark@numloq.nl>
* Code style improvement
Co-authored-by: Mark Haslinghuis <mark@numloq.nl>
* text messages are edited in the usb mass storage osd menu
* The NO menu action is default by selecting ERASE or USB MASS STORAGE items in OSD menu
* improved cmsx_StorageDevice function code
* added check of define USE_USB_MSC for storage mass mode code
* USB mass storage OSD menu text messages placement improvement
* added return NULL after systemResetToMsc
* Code improvement
Co-authored-by: Mark Haslinghuis <mark@numloq.nl>
* Code style improvement src/main/cms/cms_menu_blackbox.c
Co-authored-by: Mark Haslinghuis <mark@numloq.nl>
---------
Co-authored-by: Mark Haslinghuis <mark@numloq.nl>
