diff --git a/radio/src/crc.cpp b/radio/src/crc.cpp index a5f1d09c13..26a1af5002 100644 --- a/radio/src/crc.cpp +++ b/radio/src/crc.cpp @@ -20,77 +20,6 @@ #include "crc.h" -// CRC16 implementation according to CCITT standards -static const unsigned short crc16tab_1021[256] = { - 0x0000,0x1021,0x2042,0x3063,0x4084,0x50a5,0x60c6,0x70e7, - 0x8108,0x9129,0xa14a,0xb16b,0xc18c,0xd1ad,0xe1ce,0xf1ef, - 0x1231,0x0210,0x3273,0x2252,0x52b5,0x4294,0x72f7,0x62d6, - 0x9339,0x8318,0xb37b,0xa35a,0xd3bd,0xc39c,0xf3ff,0xe3de, - 0x2462,0x3443,0x0420,0x1401,0x64e6,0x74c7,0x44a4,0x5485, - 0xa56a,0xb54b,0x8528,0x9509,0xe5ee,0xf5cf,0xc5ac,0xd58d, - 0x3653,0x2672,0x1611,0x0630,0x76d7,0x66f6,0x5695,0x46b4, - 0xb75b,0xa77a,0x9719,0x8738,0xf7df,0xe7fe,0xd79d,0xc7bc, - 0x48c4,0x58e5,0x6886,0x78a7,0x0840,0x1861,0x2802,0x3823, - 0xc9cc,0xd9ed,0xe98e,0xf9af,0x8948,0x9969,0xa90a,0xb92b, - 0x5af5,0x4ad4,0x7ab7,0x6a96,0x1a71,0x0a50,0x3a33,0x2a12, - 0xdbfd,0xcbdc,0xfbbf,0xeb9e,0x9b79,0x8b58,0xbb3b,0xab1a, - 0x6ca6,0x7c87,0x4ce4,0x5cc5,0x2c22,0x3c03,0x0c60,0x1c41, - 0xedae,0xfd8f,0xcdec,0xddcd,0xad2a,0xbd0b,0x8d68,0x9d49, - 0x7e97,0x6eb6,0x5ed5,0x4ef4,0x3e13,0x2e32,0x1e51,0x0e70, - 0xff9f,0xefbe,0xdfdd,0xcffc,0xbf1b,0xaf3a,0x9f59,0x8f78, - 0x9188,0x81a9,0xb1ca,0xa1eb,0xd10c,0xc12d,0xf14e,0xe16f, - 0x1080,0x00a1,0x30c2,0x20e3,0x5004,0x4025,0x7046,0x6067, - 0x83b9,0x9398,0xa3fb,0xb3da,0xc33d,0xd31c,0xe37f,0xf35e, - 0x02b1,0x1290,0x22f3,0x32d2,0x4235,0x5214,0x6277,0x7256, - 0xb5ea,0xa5cb,0x95a8,0x8589,0xf56e,0xe54f,0xd52c,0xc50d, - 0x34e2,0x24c3,0x14a0,0x0481,0x7466,0x6447,0x5424,0x4405, - 0xa7db,0xb7fa,0x8799,0x97b8,0xe75f,0xf77e,0xc71d,0xd73c, - 0x26d3,0x36f2,0x0691,0x16b0,0x6657,0x7676,0x4615,0x5634, - 0xd94c,0xc96d,0xf90e,0xe92f,0x99c8,0x89e9,0xb98a,0xa9ab, - 0x5844,0x4865,0x7806,0x6827,0x18c0,0x08e1,0x3882,0x28a3, - 0xcb7d,0xdb5c,0xeb3f,0xfb1e,0x8bf9,0x9bd8,0xabbb,0xbb9a, - 0x4a75,0x5a54,0x6a37,0x7a16,0x0af1,0x1ad0,0x2ab3,0x3a92, - 0xfd2e,0xed0f,0xdd6c,0xcd4d,0xbdaa,0xad8b,0x9de8,0x8dc9, - 0x7c26,0x6c07,0x5c64,0x4c45,0x3ca2,0x2c83,0x1ce0,0x0cc1, - 0xef1f,0xff3e,0xcf5d,0xdf7c,0xaf9b,0xbfba,0x8fd9,0x9ff8, - 0x6e17,0x7e36,0x4e55,0x5e74,0x2e93,0x3eb2,0x0ed1,0x1ef0 -}; - -static const unsigned short crc16tab_1189[256] = { - 0x0000,0x1189,0x2312,0x329b,0x4624,0x57ad,0x6536,0x74bf, - 0x8c48,0x9dc1,0xaf5a,0xbed3,0xca6c,0xdbe5,0xe97e,0xf8f7, - 0x1081,0x0108,0x3393,0x221a,0x56a5,0x472c,0x75b7,0x643e, - 0x9cc9,0x8d40,0xbfdb,0xae52,0xdaed,0xcb64,0xf9ff,0xe876, - 0x2102,0x308b,0x0210,0x1399,0x6726,0x76af,0x4434,0x55bd, - 0xad4a,0xbcc3,0x8e58,0x9fd1,0xeb6e,0xfae7,0xc87c,0xd9f5, - 0x3183,0x200a,0x1291,0x0318,0x77a7,0x662e,0x54b5,0x453c, - 0xbdcb,0xac42,0x9ed9,0x8f50,0xfbef,0xea66,0xd8fd,0xc974, - 0x4204,0x538d,0x6116,0x709f,0x0420,0x15a9,0x2732,0x36bb, - 0xce4c,0xdfc5,0xed5e,0xfcd7,0x8868,0x99e1,0xab7a,0xbaf3, - 0x5285,0x430c,0x7197,0x601e,0x14a1,0x0528,0x37b3,0x263a, - 0xdecd,0xcf44,0xfddf,0xec56,0x98e9,0x8960,0xbbfb,0xaa72, - 0x6306,0x728f,0x4014,0x519d,0x2522,0x34ab,0x0630,0x17b9, - 0xef4e,0xfec7,0xcc5c,0xddd5,0xa96a,0xb8e3,0x8a78,0x9bf1, - 0x7387,0x620e,0x5095,0x411c,0x35a3,0x242a,0x16b1,0x0738, - 0xffcf,0xee46,0xdcdd,0xcd54,0xb9eb,0xa862,0x9af9,0x8b70, - 0x8408,0x9581,0xa71a,0xb693,0xc22c,0xd3a5,0xe13e,0xf0b7, - 0x0840,0x19c9,0x2b52,0x3adb,0x4e64,0x5fed,0x6d76,0x7cff, - 0x9489,0x8500,0xb79b,0xa612,0xd2ad,0xc324,0xf1bf,0xe036, - 0x18c1,0x0948,0x3bd3,0x2a5a,0x5ee5,0x4f6c,0x7df7,0x6c7e, - 0xa50a,0xb483,0x8618,0x9791,0xe32e,0xf2a7,0xc03c,0xd1b5, - 0x2942,0x38cb,0x0a50,0x1bd9,0x6f66,0x7eef,0x4c74,0x5dfd, - 0xb58b,0xa402,0x9699,0x8710,0xf3af,0xe226,0xd0bd,0xc134, - 0x39c3,0x284a,0x1ad1,0x0b58,0x7fe7,0x6e6e,0x5cf5,0x4d7c, - 0xc60c,0xd785,0xe51e,0xf497,0x8028,0x91a1,0xa33a,0xb2b3, - 0x4a44,0x5bcd,0x6956,0x78df,0x0c60,0x1de9,0x2f72,0x3efb, - 0xd68d,0xc704,0xf59f,0xe416,0x90a9,0x8120,0xb3bb,0xa232, - 0x5ac5,0x4b4c,0x79d7,0x685e,0x1ce1,0x0d68,0x3ff3,0x2e7a, - 0xe70e,0xf687,0xc41c,0xd595,0xa12a,0xb0a3,0x8238,0x93b1, - 0x6b46,0x7acf,0x4854,0x59dd,0x2d62,0x3ceb,0x0e70,0x1ff9, - 0xf78f,0xe606,0xd49d,0xc514,0xb1ab,0xa022,0x92b9,0x8330, - 0x7bc7,0x6a4e,0x58d5,0x495c,0x3de3,0x2c6a,0x1ef1,0x0f78 -}; - static const unsigned short * crc16tab[] = { crc16tab_1021, crc16tab_1189 diff --git a/radio/src/crc.h b/radio/src/crc.h index 7f6c46d264..025abaf574 100644 --- a/radio/src/crc.h +++ b/radio/src/crc.h @@ -31,4 +31,75 @@ enum { uint8_t crc8(const uint8_t * ptr, uint32_t len); uint16_t crc16(uint8_t index, const uint8_t * buf, uint32_t len, uint16_t start = 0); +// CRC16 implementation according to CCITT standards +static const unsigned short crc16tab_1021[256] = { + 0x0000,0x1021,0x2042,0x3063,0x4084,0x50a5,0x60c6,0x70e7, + 0x8108,0x9129,0xa14a,0xb16b,0xc18c,0xd1ad,0xe1ce,0xf1ef, + 0x1231,0x0210,0x3273,0x2252,0x52b5,0x4294,0x72f7,0x62d6, + 0x9339,0x8318,0xb37b,0xa35a,0xd3bd,0xc39c,0xf3ff,0xe3de, + 0x2462,0x3443,0x0420,0x1401,0x64e6,0x74c7,0x44a4,0x5485, + 0xa56a,0xb54b,0x8528,0x9509,0xe5ee,0xf5cf,0xc5ac,0xd58d, + 0x3653,0x2672,0x1611,0x0630,0x76d7,0x66f6,0x5695,0x46b4, + 0xb75b,0xa77a,0x9719,0x8738,0xf7df,0xe7fe,0xd79d,0xc7bc, + 0x48c4,0x58e5,0x6886,0x78a7,0x0840,0x1861,0x2802,0x3823, + 0xc9cc,0xd9ed,0xe98e,0xf9af,0x8948,0x9969,0xa90a,0xb92b, + 0x5af5,0x4ad4,0x7ab7,0x6a96,0x1a71,0x0a50,0x3a33,0x2a12, + 0xdbfd,0xcbdc,0xfbbf,0xeb9e,0x9b79,0x8b58,0xbb3b,0xab1a, + 0x6ca6,0x7c87,0x4ce4,0x5cc5,0x2c22,0x3c03,0x0c60,0x1c41, + 0xedae,0xfd8f,0xcdec,0xddcd,0xad2a,0xbd0b,0x8d68,0x9d49, + 0x7e97,0x6eb6,0x5ed5,0x4ef4,0x3e13,0x2e32,0x1e51,0x0e70, + 0xff9f,0xefbe,0xdfdd,0xcffc,0xbf1b,0xaf3a,0x9f59,0x8f78, + 0x9188,0x81a9,0xb1ca,0xa1eb,0xd10c,0xc12d,0xf14e,0xe16f, + 0x1080,0x00a1,0x30c2,0x20e3,0x5004,0x4025,0x7046,0x6067, + 0x83b9,0x9398,0xa3fb,0xb3da,0xc33d,0xd31c,0xe37f,0xf35e, + 0x02b1,0x1290,0x22f3,0x32d2,0x4235,0x5214,0x6277,0x7256, + 0xb5ea,0xa5cb,0x95a8,0x8589,0xf56e,0xe54f,0xd52c,0xc50d, + 0x34e2,0x24c3,0x14a0,0x0481,0x7466,0x6447,0x5424,0x4405, + 0xa7db,0xb7fa,0x8799,0x97b8,0xe75f,0xf77e,0xc71d,0xd73c, + 0x26d3,0x36f2,0x0691,0x16b0,0x6657,0x7676,0x4615,0x5634, + 0xd94c,0xc96d,0xf90e,0xe92f,0x99c8,0x89e9,0xb98a,0xa9ab, + 0x5844,0x4865,0x7806,0x6827,0x18c0,0x08e1,0x3882,0x28a3, + 0xcb7d,0xdb5c,0xeb3f,0xfb1e,0x8bf9,0x9bd8,0xabbb,0xbb9a, + 0x4a75,0x5a54,0x6a37,0x7a16,0x0af1,0x1ad0,0x2ab3,0x3a92, + 0xfd2e,0xed0f,0xdd6c,0xcd4d,0xbdaa,0xad8b,0x9de8,0x8dc9, + 0x7c26,0x6c07,0x5c64,0x4c45,0x3ca2,0x2c83,0x1ce0,0x0cc1, + 0xef1f,0xff3e,0xcf5d,0xdf7c,0xaf9b,0xbfba,0x8fd9,0x9ff8, + 0x6e17,0x7e36,0x4e55,0x5e74,0x2e93,0x3eb2,0x0ed1,0x1ef0 +}; + +static const unsigned short crc16tab_1189[256] = { + 0x0000,0x1189,0x2312,0x329b,0x4624,0x57ad,0x6536,0x74bf, + 0x8c48,0x9dc1,0xaf5a,0xbed3,0xca6c,0xdbe5,0xe97e,0xf8f7, + 0x1081,0x0108,0x3393,0x221a,0x56a5,0x472c,0x75b7,0x643e, + 0x9cc9,0x8d40,0xbfdb,0xae52,0xdaed,0xcb64,0xf9ff,0xe876, + 0x2102,0x308b,0x0210,0x1399,0x6726,0x76af,0x4434,0x55bd, + 0xad4a,0xbcc3,0x8e58,0x9fd1,0xeb6e,0xfae7,0xc87c,0xd9f5, + 0x3183,0x200a,0x1291,0x0318,0x77a7,0x662e,0x54b5,0x453c, + 0xbdcb,0xac42,0x9ed9,0x8f50,0xfbef,0xea66,0xd8fd,0xc974, + 0x4204,0x538d,0x6116,0x709f,0x0420,0x15a9,0x2732,0x36bb, + 0xce4c,0xdfc5,0xed5e,0xfcd7,0x8868,0x99e1,0xab7a,0xbaf3, + 0x5285,0x430c,0x7197,0x601e,0x14a1,0x0528,0x37b3,0x263a, + 0xdecd,0xcf44,0xfddf,0xec56,0x98e9,0x8960,0xbbfb,0xaa72, + 0x6306,0x728f,0x4014,0x519d,0x2522,0x34ab,0x0630,0x17b9, + 0xef4e,0xfec7,0xcc5c,0xddd5,0xa96a,0xb8e3,0x8a78,0x9bf1, + 0x7387,0x620e,0x5095,0x411c,0x35a3,0x242a,0x16b1,0x0738, + 0xffcf,0xee46,0xdcdd,0xcd54,0xb9eb,0xa862,0x9af9,0x8b70, + 0x8408,0x9581,0xa71a,0xb693,0xc22c,0xd3a5,0xe13e,0xf0b7, + 0x0840,0x19c9,0x2b52,0x3adb,0x4e64,0x5fed,0x6d76,0x7cff, + 0x9489,0x8500,0xb79b,0xa612,0xd2ad,0xc324,0xf1bf,0xe036, + 0x18c1,0x0948,0x3bd3,0x2a5a,0x5ee5,0x4f6c,0x7df7,0x6c7e, + 0xa50a,0xb483,0x8618,0x9791,0xe32e,0xf2a7,0xc03c,0xd1b5, + 0x2942,0x38cb,0x0a50,0x1bd9,0x6f66,0x7eef,0x4c74,0x5dfd, + 0xb58b,0xa402,0x9699,0x8710,0xf3af,0xe226,0xd0bd,0xc134, + 0x39c3,0x284a,0x1ad1,0x0b58,0x7fe7,0x6e6e,0x5cf5,0x4d7c, + 0xc60c,0xd785,0xe51e,0xf497,0x8028,0x91a1,0xa33a,0xb2b3, + 0x4a44,0x5bcd,0x6956,0x78df,0x0c60,0x1de9,0x2f72,0x3efb, + 0xd68d,0xc704,0xf59f,0xe416,0x90a9,0x8120,0xb3bb,0xa232, + 0x5ac5,0x4b4c,0x79d7,0x685e,0x1ce1,0x0d68,0x3ff3,0x2e7a, + 0xe70e,0xf687,0xc41c,0xd595,0xa12a,0xb0a3,0x8238,0x93b1, + 0x6b46,0x7acf,0x4854,0x59dd,0x2d62,0x3ceb,0x0e70,0x1ff9, + 0xf78f,0xe606,0xd49d,0xc514,0xb1ab,0xa022,0x92b9,0x8330, + 0x7bc7,0x6a4e,0x58d5,0x495c,0x3de3,0x2c6a,0x1ef1,0x0f78 +}; + #endif diff --git a/radio/src/gui/128x64/model_setup.cpp b/radio/src/gui/128x64/model_setup.cpp index 192dacbfc9..abf9a9bda0 100644 --- a/radio/src/gui/128x64/model_setup.cpp +++ b/radio/src/gui/128x64/model_setup.cpp @@ -100,6 +100,7 @@ enum MenuModelSetupItems { ITEM_MODEL_SETUP_EXTERNAL_MODULE_LABEL, ITEM_MODEL_SETUP_EXTERNAL_MODULE_TYPE, + ITEM_MODEL_SETUP_EXTERNAL_MODULE_POWER, #if defined(MULTIMODULE) ITEM_MODEL_SETUP_EXTERNAL_MODULE_SUBTYPE, ITEM_MODEL_SETUP_EXTERNAL_MODULE_STATUS, @@ -115,7 +116,6 @@ enum MenuModelSetupItems { #if defined(MULTIMODULE) ITEM_MODEL_SETUP_EXTERNAL_MODULE_AUTOBIND, #endif - ITEM_MODEL_SETUP_EXTERNAL_MODULE_POWER, ITEM_MODEL_SETUP_EXTERNAL_MODULE_FAILSAFE, ITEM_MODEL_SETUP_EXTERNAL_MODULE_PXX2_REGISTER_RANGE, ITEM_MODEL_SETUP_EXTERNAL_MODULE_PXX2_OPTIONS, @@ -321,6 +321,7 @@ void menuModelSetup(event_t event) LABEL(ExternalModule), EXTERNAL_MODULE_TYPE_ROWS, + EXTERNAL_MODULE_POWER_ROW, MULTIMODULE_SUBTYPE_ROWS(EXTERNAL_MODULE) MULTIMODULE_STATUS_ROWS EXTERNAL_MODULE_CHANNELS_ROWS, @@ -328,7 +329,6 @@ void menuModelSetup(event_t event) IF_ACCESS_MODULE_RF(EXTERNAL_MODULE, 0), // RxNum IF_NOT_PXX2_MODULE(EXTERNAL_MODULE, EXTERNAL_MODULE_OPTION_ROW), MULTIMODULE_MODULE_ROWS - EXTERNAL_MODULE_POWER_ROW, FAILSAFE_ROWS(EXTERNAL_MODULE), IF_ACCESS_MODULE_RF(EXTERNAL_MODULE, 1), // Range check and Register buttons IF_PXX2_MODULE(EXTERNAL_MODULE, 0), // Module options @@ -776,7 +776,7 @@ void menuModelSetup(event_t event) } } else if (isModuleXJT(INTERNAL_MODULE)) { - g_model.moduleData[INTERNAL_MODULE].rfProtocol = checkIncDec(event, g_model.moduleData[INTERNAL_MODULE].subType, 0, MODULE_SUBTYPE_PXX1_LAST, EE_MODEL, isRfProtocolAvailable); + g_model.moduleData[INTERNAL_MODULE].subType = checkIncDec(event, g_model.moduleData[INTERNAL_MODULE].subType, 0, MODULE_SUBTYPE_PXX1_LAST, EE_MODEL, isRfProtocolAvailable); if (checkIncDec_Ret) { g_model.moduleData[0].type = MODULE_TYPE_XJT_PXX1; g_model.moduleData[0].channelsStart = 0; @@ -840,7 +840,8 @@ void menuModelSetup(event_t event) if (attr) { if (s_editMode > 0) { switch (menuHorizontalPosition) { - case 0: { + case 0: + { uint8_t moduleType = checkIncDec(event, g_model.moduleData[EXTERNAL_MODULE].type, MODULE_TYPE_NONE, @@ -872,6 +873,11 @@ void menuModelSetup(event_t event) MODULE_SUBTYPE_R9M_LAST, EE_MODEL, isR9MModeAvailable); + if (checkIncDec_Ret) { + g_model.moduleData[EXTERNAL_MODULE].pxx.power = 0; + g_model.moduleData[EXTERNAL_MODULE].channelsStart = 0; + g_model.moduleData[EXTERNAL_MODULE].channelsCount = defaultModuleChannels_M8(EXTERNAL_MODULE); + } } #if defined(MULTIMODULE) @@ -1342,7 +1348,7 @@ void menuModelSetup(event_t event) if (attr && l_posHorz > 0) { if (s_editMode > 0) { if (l_posHorz == 1) { - if (isModuleR9MNonAccess(moduleIdx) || isModuleXJTD16(moduleIdx) || (isModuleISRM(moduleIdx) && g_model.moduleData[moduleIdx].subType == MODULE_SUBTYPE_ISRM_PXX2_ACCST_D16) || (isModuleR9MAccess(moduleIdx) && g_model.moduleData[moduleIdx].subType != MODULE_SUBTYPE_R9M_PXX2_ACCESS)) { + if (isModuleR9MNonAccess(moduleIdx) || isModuleD16(moduleIdx)) { #if defined(PCBXLITE) if (EVT_KEY_MASK(event) == KEY_ENTER) { #elif defined(PCBSKY9X) || defined(PCBAR9X) @@ -1351,27 +1357,7 @@ void menuModelSetup(event_t event) if (event == EVT_KEY_BREAK(KEY_ENTER)) { #endif killEvents(event); - uint8_t default_selection = 0; // R9M_LBT should default to 0 as available options are variables - if (isModuleR9M_LBT(moduleIdx)) { - if (BIND_TELEM_ALLOWED(moduleIdx)) - POPUP_MENU_ADD_ITEM(STR_BINDING_1_8_TELEM_ON); - POPUP_MENU_ADD_ITEM(STR_BINDING_1_8_TELEM_OFF); - if (BIND_TELEM_ALLOWED(moduleIdx) && BIND_CH9TO16_ALLOWED(moduleIdx)) - POPUP_MENU_ADD_ITEM(STR_BINDING_9_16_TELEM_ON); - if (BIND_CH9TO16_ALLOWED(moduleIdx)) - POPUP_MENU_ADD_ITEM(STR_BINDING_9_16_TELEM_OFF); - } - else { - if (BIND_TELEM_ALLOWED(moduleIdx)) - POPUP_MENU_ADD_ITEM(STR_BINDING_1_8_TELEM_ON); - POPUP_MENU_ADD_ITEM(STR_BINDING_1_8_TELEM_OFF); - if (BIND_TELEM_ALLOWED(moduleIdx)) - POPUP_MENU_ADD_ITEM(STR_BINDING_9_16_TELEM_ON); - POPUP_MENU_ADD_ITEM(STR_BINDING_9_16_TELEM_OFF); - default_selection = g_model.moduleData[moduleIdx].pxx.receiver_telem_off + (g_model.moduleData[moduleIdx].pxx.receiver_channel_9_16 << 1); - } - POPUP_MENU_SELECT_ITEM(default_selection); - POPUP_MENU_START(onBindMenu); + startBindMenu(moduleIdx); continue; } if (moduleState[moduleIdx].mode == MODULE_MODE_BIND) { @@ -1438,8 +1424,9 @@ void menuModelSetup(event_t event) menuHorizontalPosition = 0; if (menuHorizontalPosition == 0) { if (s_editMode > 0) { - CHECK_INCDEC_MODELVAR_ZERO(event, moduleData.failsafeMode, FAILSAFE_LAST); - if (checkIncDec_Ret) SEND_FAILSAFE_NOW(moduleIdx); + CHECK_INCDEC_MODELVAR_ZERO(event, moduleData.failsafeMode, isModuleR9M(moduleIdx) ? FAILSAFE_NOPULSES : FAILSAFE_LAST); + if (checkIncDec_Ret) + SEND_FAILSAFE_NOW(moduleIdx); } } else if (menuHorizontalPosition == 1) { @@ -1512,12 +1499,10 @@ void menuModelSetup(event_t event) #endif if (isModuleR9MNonAccess(moduleIdx)) { lcdDrawTextAlignedLeft(y, STR_MODULE_TELEMETRY); - if (IS_TELEMETRY_INTERNAL_MODULE()) { + if (isSportLineUsedByInternalModule()) lcdDrawText(MODEL_SETUP_2ND_COLUMN, y, STR_DISABLE_INTERNAL); - } - else { + else lcdDrawText(MODEL_SETUP_2ND_COLUMN, y, STR_MODULE_TELEM_ON); - } } else if (isModuleSBUS(moduleIdx)) { lcdDrawTextAlignedLeft(y, STR_WARN_BATTVOLTAGE); @@ -1530,10 +1515,11 @@ void menuModelSetup(event_t event) { uint8_t moduleIdx = CURRENT_MODULE_EDITED(k); auto & module = g_model.moduleData[moduleIdx]; - + // Lite FCC / Lite FLEX / Lite Pro Flex if (isModuleTypeR9MNonAccess(module.type)) { lcdDrawTextAlignedLeft(y, STR_RFPOWER); if (isModuleR9M_FCC_VARIANT(moduleIdx)) { + // FCC and FLEX modes ... if (isModuleTypeR9MLiteNonPro(module.type)) { // R9M lite FCC has only one power value, so displayed for info only lcdDrawTextAtIndex(MODEL_SETUP_2ND_COLUMN, y, STR_R9M_LITE_FCC_POWER_VALUES, 0, LEFT); if (attr) { @@ -1541,37 +1527,51 @@ void menuModelSetup(event_t event) } } else { - module.pxx.power = min((uint8_t)module.pxx.power, (uint8_t)R9M_FCC_POWER_MAX); // Sanitize + module.pxx.power = min(module.pxx.power, R9M_FCC_POWER_MAX); // Sanitize lcdDrawTextAtIndex(MODEL_SETUP_2ND_COLUMN, y, STR_R9M_FCC_POWER_VALUES, module.pxx.power, LEFT | attr); if (attr) { CHECK_INCDEC_MODELVAR_ZERO(event, module.pxx.power, R9M_FCC_POWER_MAX); + if (s_editMode == 0 && reusableBuffer.moduleSetup.r9mPower != module.pxx.power) { + module.channelsStart = 0; + module.channelsCount = maxModuleChannels_M8(moduleIdx); + } } } } - else if (isModuleTypeR9MLiteNonPro(module.type)) { - module.pxx.power = min((uint8_t)module.pxx.power, (uint8_t)R9M_LITE_LBT_POWER_MAX); // Sanitize - lcdDrawTextAtIndex(MODEL_SETUP_2ND_COLUMN, y, STR_R9M_LITE_LBT_POWER_VALUES, module.pxx.power, LEFT | attr); - if (attr) { - CHECK_INCDEC_MODELVAR_ZERO(event, module.pxx.power, R9M_LITE_LBT_POWER_MAX); - } - if (attr && s_editMode == 0 && reusableBuffer.moduleSetup.r9mPower != module.pxx.power) { - if (reusableBuffer.moduleSetup.r9mPower + module.pxx.power < 5) { //switching between mode 2 and 3 does not require rebind - POPUP_WARNING(STR_REBIND); - } - reusableBuffer.moduleSetup.r9mPower = module.pxx.power; - } - } else { - module.pxx.power = min((uint8_t)module.pxx.power, (uint8_t)R9M_LBT_POWER_MAX); // Sanitize - lcdDrawTextAtIndex(MODEL_SETUP_2ND_COLUMN, y, STR_R9M_LBT_POWER_VALUES, module.pxx.power, LEFT | attr); - if (attr) { - CHECK_INCDEC_MODELVAR_ZERO(event, module.pxx.power, R9M_LBT_POWER_MAX); - } - if (attr && s_editMode == 0 && reusableBuffer.moduleSetup.r9mPower != module.pxx.power) { - if (reusableBuffer.moduleSetup.r9mPower + module.pxx.power < 5) { //switching between mode 2 and 3 does not require rebind - POPUP_WARNING(STR_REBIND); + // EU-LBT mode ... + if (isModuleTypeR9MLiteNonPro(module.type)) { + // R9M Lite in EU-LBT mode ... + module.pxx.power = min(module.pxx.power, R9M_LITE_LBT_POWER_MAX); // Sanitize + lcdDrawTextAtIndex(MODEL_SETUP_2ND_COLUMN, y, STR_R9M_LITE_LBT_POWER_VALUES, module.pxx.power, LEFT | attr); + if (attr) { + CHECK_INCDEC_MODELVAR_ZERO(event, module.pxx.power, R9M_LITE_LBT_POWER_MAX); + if (s_editMode == 0 && reusableBuffer.moduleSetup.r9mPower != module.pxx.power) { + module.channelsStart = 0; + module.channelsCount = maxModuleChannels_M8(moduleIdx); + if (reusableBuffer.moduleSetup.r9mPower + module.pxx.power < 5) { // switching between mode 2 and 3 does not require rebind + POPUP_WARNING(STR_REBIND); + } + reusableBuffer.moduleSetup.r9mPower = module.pxx.power; + } + } + } + else { + // R9M (full size) or R9M Lite Pro in EU-LBT mode ... + module.pxx.power = min((uint8_t) module.pxx.power, (uint8_t) R9M_LBT_POWER_MAX); // Sanitize + lcdDrawTextAtIndex(MODEL_SETUP_2ND_COLUMN, y, STR_R9M_LBT_POWER_VALUES, module.pxx.power, LEFT | attr); + if (attr) { + CHECK_INCDEC_MODELVAR_ZERO(event, module.pxx.power, R9M_LBT_POWER_MAX); + if (s_editMode == 0 && reusableBuffer.moduleSetup.r9mPower != module.pxx.power) { + TRACE("ON Y PASSE"); + module.channelsStart = 0; + module.channelsCount = maxModuleChannels_M8(moduleIdx); + if (reusableBuffer.moduleSetup.r9mPower + module.pxx.power < 5) { //switching between mode 2 and 3 does not require rebind + POPUP_WARNING(STR_REBIND); + } + reusableBuffer.moduleSetup.r9mPower = module.pxx.power; + } } - reusableBuffer.moduleSetup.r9mPower = module.pxx.power; } } } diff --git a/radio/src/gui/212x64/model_setup.cpp b/radio/src/gui/212x64/model_setup.cpp index 400910488e..f99e0d3596 100644 --- a/radio/src/gui/212x64/model_setup.cpp +++ b/radio/src/gui/212x64/model_setup.cpp @@ -1069,29 +1069,9 @@ void menuModelSetup(event_t event) if (attr && l_posHorz>0) { if (s_editMode>0) { if (l_posHorz == 1) { - if (isModuleR9MNonAccess(moduleIdx) || (isModuleXJT(moduleIdx) && g_model.moduleData[moduleIdx].rfProtocol == MODULE_SUBTYPE_PXX1_ACCST_D16)) { + if (isModuleR9MNonAccess(moduleIdx) || isModuleD16(moduleIdx)) { if (event == EVT_KEY_BREAK(KEY_ENTER)) { - uint8_t default_selection = 0; // R9M_LBT should default to 0 as available options are variables - if (isModuleR9M_LBT(moduleIdx)) { - if (BIND_TELEM_ALLOWED(moduleIdx)) - POPUP_MENU_ADD_ITEM(STR_BINDING_1_8_TELEM_ON); - POPUP_MENU_ADD_ITEM(STR_BINDING_1_8_TELEM_OFF); - if (BIND_TELEM_ALLOWED(moduleIdx) && BIND_CH9TO16_ALLOWED(moduleIdx)) - POPUP_MENU_ADD_ITEM(STR_BINDING_9_16_TELEM_ON); - if (BIND_CH9TO16_ALLOWED(moduleIdx)) - POPUP_MENU_ADD_ITEM(STR_BINDING_9_16_TELEM_OFF); - } - else { - if (BIND_TELEM_ALLOWED(moduleIdx)) - POPUP_MENU_ADD_ITEM(STR_BINDING_1_8_TELEM_ON); - POPUP_MENU_ADD_ITEM(STR_BINDING_1_8_TELEM_OFF); - if (BIND_TELEM_ALLOWED(moduleIdx)) - POPUP_MENU_ADD_ITEM(STR_BINDING_9_16_TELEM_ON); - POPUP_MENU_ADD_ITEM(STR_BINDING_9_16_TELEM_OFF); - default_selection = g_model.moduleData[moduleIdx].pxx.receiver_telem_off + (g_model.moduleData[moduleIdx].pxx.receiver_channel_9_16 << 1); - } - POPUP_MENU_SELECT_ITEM(default_selection); - POPUP_MENU_START(onBindMenu); + startBindMenu(moduleIdx); continue; } if (moduleState[moduleIdx].mode == MODULE_MODE_BIND) { @@ -1136,7 +1116,7 @@ void menuModelSetup(event_t event) } if (menuHorizontalPosition == 0) { if (s_editMode > 0) { - CHECK_INCDEC_MODELVAR_ZERO(event, moduleData.failsafeMode, FAILSAFE_LAST); + CHECK_INCDEC_MODELVAR_ZERO(event, moduleData.failsafeMode, isModuleR9M(moduleIdx) ? FAILSAFE_NOPULSES : FAILSAFE_LAST); if (checkIncDec_Ret) SEND_FAILSAFE_NOW(moduleIdx); } } @@ -1196,7 +1176,7 @@ void menuModelSetup(event_t event) #endif if (isModuleR9MNonAccess(moduleIdx)) { lcdDrawTextAlignedLeft(y, STR_MODULE_TELEMETRY); - if (IS_TELEMETRY_INTERNAL_MODULE()) { + if (isSportLineUsedByInternalModule()) { lcdDrawText(MODEL_SETUP_2ND_COLUMN, y, STR_DISABLE_INTERNAL); } else { diff --git a/radio/src/gui/480x272/gui.h b/radio/src/gui/480x272/gui.h index faceac2b9d..a096fabf69 100644 --- a/radio/src/gui/480x272/gui.h +++ b/radio/src/gui/480x272/gui.h @@ -28,6 +28,8 @@ #include "bitmaps.h" #include "theme.h" +#define HEADER_LINE 0 + #define MENU_TOOLTIPS #define MENU_HEADER_HEIGHT 45 #define MENU_TITLE_TOP 48 diff --git a/radio/src/gui/480x272/model_setup.cpp b/radio/src/gui/480x272/model_setup.cpp index f85fe8e6f6..67434c5bd2 100644 --- a/radio/src/gui/480x272/model_setup.cpp +++ b/radio/src/gui/480x272/model_setup.cpp @@ -84,6 +84,7 @@ enum MenuModelSetupItems { ITEM_MODEL_SETUP_EXTERNAL_MODULE_LABEL, ITEM_MODEL_SETUP_EXTERNAL_MODULE_TYPE, + ITEM_MODEL_SETUP_EXTERNAL_MODULE_POWER, #if defined(MULTIMODULE) ITEM_MODEL_SETUP_EXTERNAL_MODULE_STATUS, ITEM_MODEL_SETUP_EXTERNAL_MODULE_SYNCSTATUS, @@ -95,7 +96,6 @@ enum MenuModelSetupItems { #if defined(MULTIMODULE) ITEM_MODEL_SETUP_EXTERNAL_MODULE_AUTOBIND, #endif - ITEM_MODEL_SETUP_EXTERNAL_MODULE_POWER, ITEM_MODEL_SETUP_TRAINER_LABEL, ITEM_MODEL_SETUP_TRAINER_MODE, #if defined(BLUETOOTH) @@ -117,6 +117,8 @@ enum MenuModelSetupItems { #define CURRENT_MODULE_EDITED(k) (k >= ITEM_MODEL_SETUP_EXTERNAL_MODULE_LABEL ? EXTERNAL_MODULE : INTERNAL_MODULE) #define CURRENT_RECEIVER_EDITED(k) (k - (k >= ITEM_MODEL_SETUP_EXTERNAL_MODULE_LABEL ? k : ITEM_MODEL_SETUP_INTERNAL_MODULE_PXX2_RECEIVER_1)) +#include "common/stdlcd/model_setup_pxx1.cpp" + bool isPXX2ReceiverEmpty(uint8_t moduleIdx, uint8_t receiverIdx) { return is_memclear(g_model.moduleData[moduleIdx].pxx2.receiverName[receiverIdx], PXX2_LEN_RX_NAME); @@ -178,7 +180,6 @@ void onPXX2R9MBindModeMenu(const char * result) #endif } -#define HEADER_LINE 0 // TODO code duplicated @@ -388,33 +389,6 @@ void checkModelIdUnique(uint8_t moduleIdx) } } -void onBindMenu(const char * result) -{ - uint8_t moduleIdx = CURRENT_MODULE_EDITED(menuVerticalPosition); - - if (result == STR_BINDING_1_8_TELEM_ON) { - g_model.moduleData[moduleIdx].pxx.receiver_telem_off = false; - g_model.moduleData[moduleIdx].pxx.receiver_channel_9_16 = false; - } - else if (result == STR_BINDING_1_8_TELEM_OFF) { - g_model.moduleData[moduleIdx].pxx.receiver_telem_off = true; - g_model.moduleData[moduleIdx].pxx.receiver_channel_9_16 = false; - } - else if (result == STR_BINDING_9_16_TELEM_ON) { - g_model.moduleData[moduleIdx].pxx.receiver_telem_off = false; - g_model.moduleData[moduleIdx].pxx.receiver_channel_9_16 = true; - } - else if (result == STR_BINDING_9_16_TELEM_OFF) { - g_model.moduleData[moduleIdx].pxx.receiver_telem_off = true; - g_model.moduleData[moduleIdx].pxx.receiver_channel_9_16 = true; - } - else { - return; - } - - moduleState[moduleIdx].mode = MODULE_MODE_BIND; -} - void onModelSetupBitmapMenu(const char * result) { if (result == STR_UPDATE_LIST) { @@ -622,13 +596,13 @@ bool menuModelSetup(event_t event) LABEL(ExternalModule), EXTERNAL_MODULE_MODE_ROWS, + EXTERNAL_MODULE_POWER_ROW, MULTIMODULE_STATUS_ROWS EXTERNAL_MODULE_CHANNELS_ROWS, EXTERNAL_MODULE_BIND_ROWS, FAILSAFE_ROWS(EXTERNAL_MODULE), EXTERNAL_MODULE_OPTION_ROW, MULTIMODULE_MODULE_ROWS - EXTERNAL_MODULE_POWER_ROW, TRAINER_ROWS }); @@ -1468,29 +1442,9 @@ bool menuModelSetup(event_t event) if (attr && l_posHorz>0) { if (s_editMode>0) { if (l_posHorz == 1) { - if (isModuleR9MNonAccess(moduleIdx) || (isModuleXJT(moduleIdx) && g_model.moduleData[moduleIdx].rfProtocol == MODULE_SUBTYPE_PXX1_ACCST_D16)) { + if (isModuleR9MNonAccess(moduleIdx) || isModuleD16(moduleIdx)) { if (event == EVT_KEY_BREAK(KEY_ENTER)) { - uint8_t default_selection = 0; // R9M_LBT should default to 0 as available options are variables - if (isModuleR9M_LBT(moduleIdx)) { - if (BIND_TELEM_ALLOWED(moduleIdx)) - POPUP_MENU_ADD_ITEM(STR_BINDING_1_8_TELEM_ON); - POPUP_MENU_ADD_ITEM(STR_BINDING_1_8_TELEM_OFF); - if (BIND_TELEM_ALLOWED(moduleIdx) && BIND_CH9TO16_ALLOWED(moduleIdx)) - POPUP_MENU_ADD_ITEM(STR_BINDING_9_16_TELEM_ON); - if (BIND_CH9TO16_ALLOWED(moduleIdx)) - POPUP_MENU_ADD_ITEM(STR_BINDING_9_16_TELEM_OFF); - } - else { - if (BIND_TELEM_ALLOWED(moduleIdx)) - POPUP_MENU_ADD_ITEM(STR_BINDING_1_8_TELEM_ON); - POPUP_MENU_ADD_ITEM(STR_BINDING_1_8_TELEM_OFF); - if (BIND_TELEM_ALLOWED(moduleIdx)) - POPUP_MENU_ADD_ITEM(STR_BINDING_9_16_TELEM_ON); - POPUP_MENU_ADD_ITEM(STR_BINDING_9_16_TELEM_OFF); - default_selection = g_model.moduleData[moduleIdx].pxx.receiver_telem_off + (g_model.moduleData[moduleIdx].pxx.receiver_channel_9_16 << 1); - } - POPUP_MENU_SELECT_ITEM(default_selection); - POPUP_MENU_START(onBindMenu); + startBindMenu(moduleIdx); continue; } if (moduleState[moduleIdx].mode == MODULE_MODE_BIND) { @@ -1536,7 +1490,7 @@ bool menuModelSetup(event_t event) menuHorizontalPosition = 0; if (menuHorizontalPosition==0) { if (s_editMode>0) { - CHECK_INCDEC_MODELVAR_ZERO(event, moduleData.failsafeMode, FAILSAFE_LAST); + CHECK_INCDEC_MODELVAR_ZERO(event, moduleData.failsafeMode, isModuleR9M(moduleIdx) ? FAILSAFE_NOPULSES : FAILSAFE_LAST); if (checkIncDec_Ret) SEND_FAILSAFE_NOW(moduleIdx); } } @@ -1592,12 +1546,19 @@ bool menuModelSetup(event_t event) } } #endif - if (isModuleSBUS(moduleIdx)) { + if (isModuleR9MNonAccess(moduleIdx)) { + lcdDrawText(MENUS_MARGIN_LEFT, y, STR_MODULE_TELEMETRY); + if (isSportLineUsedByInternalModule()) + lcdDrawText(MODEL_SETUP_2ND_COLUMN, y, STR_DISABLE_INTERNAL); + else + lcdDrawText(MODEL_SETUP_2ND_COLUMN, y, STR_MODULE_TELEM_ON); + } + else if (isModuleSBUS(moduleIdx)) { lcdDrawText(MENUS_MARGIN_LEFT, y, STR_WARN_BATTVOLTAGE); drawValueWithUnit(MODEL_SETUP_4TH_COLUMN, y, getBatteryVoltage(), UNIT_VOLTS, attr|PREC2|LEFT); } - } break; + } case ITEM_MODEL_SETUP_EXTERNAL_MODULE_POWER: { diff --git a/radio/src/gui/common/stdlcd/model_setup_pxx1.cpp b/radio/src/gui/common/stdlcd/model_setup_pxx1.cpp index c7eb39f8f4..f0e027a989 100644 --- a/radio/src/gui/common/stdlcd/model_setup_pxx1.cpp +++ b/radio/src/gui/common/stdlcd/model_setup_pxx1.cpp @@ -27,14 +27,14 @@ void onBindMenu(const char * result) g_model.moduleData[moduleIdx].pxx.receiver_telem_off = false; g_model.moduleData[moduleIdx].pxx.receiver_channel_9_16 = false; if (isModuleR9MLiteNonPro(moduleIdx) && isModuleR9M_LBT(moduleIdx)) { - g_model.moduleData[moduleIdx].pxx.power = R9M_LITE_LBT_POWER_25_TELEM; + g_model.moduleData[moduleIdx].pxx.power = R9M_LITE_LBT_POWER_25_8CH; } } else if (result == STR_BINDING_1_8_TELEM_OFF) { g_model.moduleData[moduleIdx].pxx.receiver_telem_off = true; g_model.moduleData[moduleIdx].pxx.receiver_channel_9_16 = false; if (isModuleR9MLiteNonPro(moduleIdx) && isModuleR9M_LBT(moduleIdx)) { - g_model.moduleData[moduleIdx].pxx.power = R9M_LITE_LBT_POWER_100_NOTELEM; + g_model.moduleData[moduleIdx].pxx.power = R9M_LITE_LBT_POWER_100_16CH_NOTELEM; } } else if (result == STR_BINDING_9_16_TELEM_ON) { @@ -50,4 +50,32 @@ void onBindMenu(const char * result) } moduleState[moduleIdx].mode = MODULE_MODE_BIND; -} \ No newline at end of file +} + +void startBindMenu(uint8_t moduleIdx) +{ + uint8_t selection = 0; // R9M_LBT should default to 0 as available options are variables + + if (isTelemAllowedOnBind(moduleIdx)) + POPUP_MENU_ADD_ITEM(STR_BINDING_1_8_TELEM_ON); + POPUP_MENU_ADD_ITEM(STR_BINDING_1_8_TELEM_OFF); + + if (isBindCh9To16Allowed(moduleIdx)) { + if (isTelemAllowedOnBind(moduleIdx)) + POPUP_MENU_ADD_ITEM(STR_BINDING_9_16_TELEM_ON); + POPUP_MENU_ADD_ITEM(STR_BINDING_9_16_TELEM_OFF); + } + + if (isBindCh9To16Allowed(moduleIdx) && g_model.moduleData[moduleIdx].pxx.receiver_channel_9_16) { + selection += 1; + if (isTelemAllowedOnBind(moduleIdx)) + selection += 1; + } + + if (isTelemAllowedOnBind(moduleIdx) && g_model.moduleData[moduleIdx].pxx.receiver_telem_off) + selection += 1; + + + POPUP_MENU_SELECT_ITEM(selection); + POPUP_MENU_START(onBindMenu); +} diff --git a/radio/src/gui/gui_common.cpp b/radio/src/gui/gui_common.cpp index 4a1e201f56..c95d938dee 100644 --- a/radio/src/gui/gui_common.cpp +++ b/radio/src/gui/gui_common.cpp @@ -548,6 +548,9 @@ bool isModuleUsingSport(uint8_t moduleBay, uint8_t moduleType) return false; case MODULE_TYPE_XJT_PXX1: + // External XJT has a physical switch to disable S.PORT + case MODULE_TYPE_R9M_PXX1: + // R9M telemetry is disabled by pulses (pxx1.cpp) if (moduleBay == EXTERNAL_MODULE) return false; diff --git a/radio/src/gui/gui_common.h b/radio/src/gui/gui_common.h index 6a3fa510b5..419134caa6 100644 --- a/radio/src/gui/gui_common.h +++ b/radio/src/gui/gui_common.h @@ -150,7 +150,7 @@ const mm_protocol_definition *getMultiProtocolDefinition (uint8_t protocol); #define FAILSAFE_ROWS(x) isModuleFailsafeAvailable(x) ? (g_model.moduleData[x].failsafeMode==FAILSAFE_CUSTOM ? (uint8_t)1 : (uint8_t)0) : HIDDEN_ROW #define EXTERNAL_MODULE_OPTION_ROW (isModuleR9MNonAccess(EXTERNAL_MODULE) || isModuleSBUS(EXTERNAL_MODULE) ? TITLE_ROW : MULTIMODULE_OPTIONS_ROW) -#define EXTERNAL_MODULE_POWER_ROW (isModuleMultimodule(EXTERNAL_MODULE) || isModuleR9MNonAccess(EXTERNAL_MODULE)) ? (isModuleR9MLiteNonPro(EXTERNAL_MODULE) ? TITLE_ROW : (uint8_t) 0) : HIDDEN_ROW +#define EXTERNAL_MODULE_POWER_ROW (isModuleMultimodule(EXTERNAL_MODULE) || isModuleR9MNonAccess(EXTERNAL_MODULE)) ? (isModuleR9MLiteNonPro(EXTERNAL_MODULE) ? (isModuleR9M_FCC_VARIANT(EXTERNAL_MODULE) ? READONLY_ROW : (uint8_t)0) : (uint8_t)0) : HIDDEN_ROW void editStickHardwareSettings(coord_t x, coord_t y, int idx, event_t event, LcdFlags flags); diff --git a/radio/src/pulses/modules_constants.h b/radio/src/pulses/modules_constants.h index 93e9caae17..00ac471e0a 100644 --- a/radio/src/pulses/modules_constants.h +++ b/radio/src/pulses/modules_constants.h @@ -36,15 +36,27 @@ enum ModuleSubtypeISRM_PXX2 { MODULE_SUBTYPE_ISRM_PXX2_LAST = MODULE_SUBTYPE_ISRM_PXX2_ACCST_D8 }; -enum ModuleSubtypeR9M_PXX2 { - MODULE_SUBTYPE_R9M_PXX2_ACCESS, - MODULE_SUBTYPE_R9M_PXX2_FCC, - MODULE_SUBTYPE_R9M_PXX2_EU, -#if defined(R9M_PROTO_FLEX) - MODULE_SUBTYPE_R9M_PXX2_FLEX, -#endif - MODULE_SUBTYPE_R9M_PXX2_COUNT, - MODULE_SUBTYPE_R9M_PXX2_LAST = MODULE_SUBTYPE_R9M_PXX2_COUNT - 1 +enum R9MLiteLBTPowerValues { + R9M_LITE_LBT_POWER_25_8CH = 0, + R9M_LITE_LBT_POWER_25_16CH, + R9M_LITE_LBT_POWER_100_16CH_NOTELEM, + R9M_LITE_LBT_POWER_MAX = R9M_LITE_LBT_POWER_100_16CH_NOTELEM +}; + +enum R9MFCCPowerValues { + R9M_FCC_POWER_10 = 0, + R9M_FCC_POWER_100, + R9M_FCC_POWER_500, + R9M_FCC_POWER_1000, + R9M_FCC_POWER_MAX = R9M_FCC_POWER_1000 +}; + +enum R9MLBTPowerValues { + R9M_LBT_POWER_25_8CH = 0, + R9M_LBT_POWER_25_16CH, + R9M_LBT_POWER_200_16CH_NOTELEM, + R9M_LBT_POWER_500_16CH_NOTELEM, + R9M_LBT_POWER_MAX = R9M_LBT_POWER_500_16CH_NOTELEM }; enum AntennaTypes { diff --git a/radio/src/pulses/modules_helpers.h b/radio/src/pulses/modules_helpers.h index 634f91db30..a2f0bd1634 100644 --- a/radio/src/pulses/modules_helpers.h +++ b/radio/src/pulses/modules_helpers.h @@ -23,6 +23,7 @@ #include "bitfield.h" #include "definitions.h" +#include "telemetry/telemetry.h" #if defined(MULTIMODULE) #include "telemetry/multi.h" #endif @@ -81,6 +82,16 @@ inline bool isModuleISRM(uint8_t idx) return g_model.moduleData[idx].type == MODULE_TYPE_ISRM_PXX2; } +inline bool isModuleISRMD16(uint8_t idx) +{ + return g_model.moduleData[idx].type == MODULE_TYPE_ISRM_PXX2 && g_model.moduleData[idx].subType == MODULE_SUBTYPE_ISRM_PXX2_ACCST_D16; +} + +inline bool isModuleD16(uint8_t idx) +{ + return isModuleXJTD16(idx) || isModuleISRMD16(idx); +} + inline bool isModuleISRMAccess(uint8_t idx) { return g_model.moduleData[idx].type == MODULE_TYPE_ISRM_PXX2 && g_model.moduleData[idx].subType == MODULE_SUBTYPE_ISRM_PXX2_ACCESS; @@ -181,7 +192,7 @@ inline bool isModuleR9MLite(uint8_t idx) inline bool isModuleR9M_FCC(uint8_t idx) { - return isModuleR9MNonAccess(idx) && g_model.moduleData[idx].rfProtocol == MODULE_SUBTYPE_R9M_FCC; + return isModuleR9MNonAccess(idx) && g_model.moduleData[idx].subType == MODULE_SUBTYPE_R9M_FCC; } inline bool isModuleTypeLite(uint8_t type) @@ -191,22 +202,22 @@ inline bool isModuleTypeLite(uint8_t type) inline bool isModuleR9M_LBT(uint8_t idx) { - return isModuleR9MNonAccess(idx) && g_model.moduleData[idx].rfProtocol == MODULE_SUBTYPE_R9M_EU; + return isModuleR9MNonAccess(idx) && g_model.moduleData[idx].subType == MODULE_SUBTYPE_R9M_EU; } inline bool isModuleR9M_FCC_VARIANT(uint8_t idx) { - return isModuleR9MNonAccess(idx) && g_model.moduleData[idx].rfProtocol != MODULE_SUBTYPE_R9M_EU; + return isModuleR9MNonAccess(idx) && g_model.moduleData[idx].subType != MODULE_SUBTYPE_R9M_EU; } inline bool isModuleR9M_EUPLUS(uint8_t idx) { - return isModuleR9MNonAccess(idx) && g_model.moduleData[idx].rfProtocol == MODULE_SUBTYPE_R9M_EUPLUS; + return isModuleR9MNonAccess(idx) && g_model.moduleData[idx].subType == MODULE_SUBTYPE_R9M_EUPLUS; } inline bool isModuleR9M_AU_PLUS(uint8_t idx) { - return isModuleR9MNonAccess(idx) && g_model.moduleData[idx].rfProtocol == MODULE_SUBTYPE_R9M_AUPLUS; + return isModuleR9MNonAccess(idx) && g_model.moduleData[idx].subType == MODULE_SUBTYPE_R9M_AUPLUS; } inline bool isModuleTypePXX1(uint8_t type) @@ -270,12 +281,26 @@ constexpr int8_t MAX_EXTRA_MODULE_CHANNELS_M8 = 8; // only 16ch PPM inline int8_t maxModuleChannels_M8(uint8_t idx) { - if (isExtraModule(idx)) + if (isExtraModule(idx)) { return MAX_EXTRA_MODULE_CHANNELS_M8; - else if (isModuleXJT(idx)) + } + else if (isModuleXJT(idx)) { return maxChannelsXJT[1 + g_model.moduleData[idx].subType]; - else + } + else if (isModuleR9M(idx)) { + if (isModuleR9M_LBT(idx)) { + if (isModuleR9MLite(idx)) + return g_model.moduleData[idx].pxx.power == R9M_LITE_LBT_POWER_25_8CH ? 0 : 8; + else + return g_model.moduleData[idx].pxx.power == R9M_LBT_POWER_25_8CH ? 0 : 8; + } + else { + return 8; // always 16 channels in FCC / FLEX + } + } + else { return maxChannelsModules[g_model.moduleData[idx].type]; + } } inline int8_t defaultModuleChannels_M8(uint8_t idx) @@ -483,4 +508,47 @@ inline const char * getModuleDelay(uint8_t idx) return nullptr; } +inline bool isBindCh9To16Allowed(uint8_t moduleIndex) +{ + if (g_model.moduleData[moduleIndex].channelsCount <= 0) { + return false; + } + + if (isModuleR9M_LBT(moduleIndex)) { + if (isModuleR9MLite(moduleIndex)) + return g_model.moduleData[moduleIndex].pxx.power != R9M_LBT_POWER_25_8CH; + else + return g_model.moduleData[moduleIndex].pxx.power != R9M_LITE_LBT_POWER_25_8CH; + } + else { + return true; + } +} + +inline bool isTelemAllowedOnBind(uint8_t moduleIndex) +{ +#if defined(HARDWARE_INTERNAL_MODULE) + if (moduleIndex == INTERNAL_MODULE) + return isSportLineUsedByInternalModule(); + + if (isSportLineUsedByInternalModule()) + return false; +#endif + + if (g_model.moduleData[EXTERNAL_MODULE].type == MODULE_TYPE_R9M_LITE_PXX1) { + if (isModuleR9M_LBT(EXTERNAL_MODULE)) + return g_model.moduleData[EXTERNAL_MODULE].pxx.power < R9M_LITE_LBT_POWER_100_16CH_NOTELEM; + else + return true; + } + + if (g_model.moduleData[EXTERNAL_MODULE].type == MODULE_TYPE_R9M_PXX1 || g_model.moduleData[EXTERNAL_MODULE].type == MODULE_TYPE_R9M_LITE_PRO_PXX1) { + if (isModuleR9M_LBT(EXTERNAL_MODULE)) + return g_model.moduleData[EXTERNAL_MODULE].pxx.power < R9M_LBT_POWER_200_16CH_NOTELEM; + else + return true; + } + + return true; +} #endif // _MODULES_H_ diff --git a/radio/src/pulses/pulses.h b/radio/src/pulses/pulses.h index 8c0ae36b9c..1402af0605 100644 --- a/radio/src/pulses/pulses.h +++ b/radio/src/pulses/pulses.h @@ -409,28 +409,5 @@ inline void SEND_FAILSAFE_1S() // for channels not set previously to HOLD or NOPULSE void setCustomFailsafe(uint8_t moduleIndex); -enum R9MLiteLBTPowerValues { - R9M_LITE_LBT_POWER_25_TELEM = 0, - R9M_LITE_LBT_POWER_100_NOTELEM, - R9M_LITE_LBT_POWER_MAX = R9M_LITE_LBT_POWER_100_NOTELEM -}; -enum R9MFCCPowerValues { - R9M_FCC_POWER_10 = 0, - R9M_FCC_POWER_100, - R9M_FCC_POWER_500, - R9M_FCC_POWER_1000, - R9M_FCC_POWER_MAX = R9M_FCC_POWER_1000 -}; - -enum R9MLBTPowerValues { - R9M_LBT_POWER_25 = 0, - R9M_LBT_POWER_25_16, - R9M_LBT_POWER_200, - R9M_LBT_POWER_500, - R9M_LBT_POWER_MAX = R9M_LBT_POWER_500 -}; - -#define BIND_CH9TO16_ALLOWED(idx) (!isModuleR9M_LBT(idx) || g_model.moduleData[idx].pxx.power != R9M_LBT_POWER_25) -#define BIND_TELEM_ALLOWED(idx) (g_model.moduleData[EXTERNAL_MODULE].type == MODULE_TYPE_R9M_PXX1) ? (!(IS_TELEMETRY_INTERNAL_MODULE() && moduleIdx == EXTERNAL_MODULE) && (!isModuleR9M_LBT(idx) || g_model.moduleData[idx].pxx.power < R9M_LBT_POWER_200)) : (!(IS_TELEMETRY_INTERNAL_MODULE() && moduleIdx == EXTERNAL_MODULE) && (!isModuleR9M_LBT(idx) || g_model.moduleData[idx].pxx.power < R9M_LITE_LBT_POWER_100_NOTELEM)) #endif // _PULSES_H_ diff --git a/radio/src/pulses/pxx1.cpp b/radio/src/pulses/pxx1.cpp index 084ebe0be7..96c4cc558c 100644 --- a/radio/src/pulses/pxx1.cpp +++ b/radio/src/pulses/pxx1.cpp @@ -21,45 +21,10 @@ #include "opentx.h" #include "pulses/pxx1.h" -const uint16_t Pxx1CrcMixin::CRCTable[] = { - 0x0000,0x1189,0x2312,0x329b,0x4624,0x57ad,0x6536,0x74bf, - 0x8c48,0x9dc1,0xaf5a,0xbed3,0xca6c,0xdbe5,0xe97e,0xf8f7, - 0x1081,0x0108,0x3393,0x221a,0x56a5,0x472c,0x75b7,0x643e, - 0x9cc9,0x8d40,0xbfdb,0xae52,0xdaed,0xcb64,0xf9ff,0xe876, - 0x2102,0x308b,0x0210,0x1399,0x6726,0x76af,0x4434,0x55bd, - 0xad4a,0xbcc3,0x8e58,0x9fd1,0xeb6e,0xfae7,0xc87c,0xd9f5, - 0x3183,0x200a,0x1291,0x0318,0x77a7,0x662e,0x54b5,0x453c, - 0xbdcb,0xac42,0x9ed9,0x8f50,0xfbef,0xea66,0xd8fd,0xc974, - 0x4204,0x538d,0x6116,0x709f,0x0420,0x15a9,0x2732,0x36bb, - 0xce4c,0xdfc5,0xed5e,0xfcd7,0x8868,0x99e1,0xab7a,0xbaf3, - 0x5285,0x430c,0x7197,0x601e,0x14a1,0x0528,0x37b3,0x263a, - 0xdecd,0xcf44,0xfddf,0xec56,0x98e9,0x8960,0xbbfb,0xaa72, - 0x6306,0x728f,0x4014,0x519d,0x2522,0x34ab,0x0630,0x17b9, - 0xef4e,0xfec7,0xcc5c,0xddd5,0xa96a,0xb8e3,0x8a78,0x9bf1, - 0x7387,0x620e,0x5095,0x411c,0x35a3,0x242a,0x16b1,0x0738, - 0xffcf,0xee46,0xdcdd,0xcd54,0xb9eb,0xa862,0x9af9,0x8b70, - 0x8408,0x9581,0xa71a,0xb693,0xc22c,0xd3a5,0xe13e,0xf0b7, - 0x0840,0x19c9,0x2b52,0x3adb,0x4e64,0x5fed,0x6d76,0x7cff, - 0x9489,0x8500,0xb79b,0xa612,0xd2ad,0xc324,0xf1bf,0xe036, - 0x18c1,0x0948,0x3bd3,0x2a5a,0x5ee5,0x4f6c,0x7df7,0x6c7e, - 0xa50a,0xb483,0x8618,0x9791,0xe32e,0xf2a7,0xc03c,0xd1b5, - 0x2942,0x38cb,0x0a50,0x1bd9,0x6f66,0x7eef,0x4c74,0x5dfd, - 0xb58b,0xa402,0x9699,0x8710,0xf3af,0xe226,0xd0bd,0xc134, - 0x39c3,0x284a,0x1ad1,0x0b58,0x7fe7,0x6e6e,0x5cf5,0x4d7c, - 0xc60c,0xd785,0xe51e,0xf497,0x8028,0x91a1,0xa33a,0xb2b3, - 0x4a44,0x5bcd,0x6956,0x78df,0x0c60,0x1de9,0x2f72,0x3efb, - 0xd68d,0xc704,0xf59f,0xe416,0x90a9,0x8120,0xb3bb,0xa232, - 0x5ac5,0x4b4c,0x79d7,0x685e,0x1ce1,0x0d68,0x3ff3,0x2e7a, - 0xe70e,0xf687,0xc41c,0xd595,0xa12a,0xb0a3,0x8238,0x93b1, - 0x6b46,0x7acf,0x4854,0x59dd,0x2d62,0x3ceb,0x0e70,0x1ff9, - 0xf78f,0xe606,0xd49d,0xc514,0xb1ab,0xa022,0x92b9,0x8330, - 0x7bc7,0x6a4e,0x58d5,0x495c,0x3de3,0x2c6a,0x1ef1,0x0f78 -}; - template uint8_t Pxx1Pulses::addFlag1(uint8_t module) { - uint8_t flag1 = (g_model.moduleData[module].rfProtocol << 6); + uint8_t flag1 = (g_model.moduleData[module].subType << 6); if (moduleState[module].mode == MODULE_MODE_BIND) { flag1 |= (g_eeGeneral.countryCode << 1) | PXX_SEND_BIND; } @@ -104,7 +69,7 @@ void Pxx1Pulses::addExtraFlags(uint8_t module) } // Disable S.PORT if internal module is active - if (IS_TELEMETRY_INTERNAL_MODULE()) { + if (module == EXTERNAL_MODULE && isSportLineUsedByInternalModule()) { extra_flags |= (1 << 5); } PxxTransport::addByte(extra_flags); diff --git a/radio/src/pulses/pxx1.h b/radio/src/pulses/pxx1.h index 3d605de75c..80dde1d5a4 100644 --- a/radio/src/pulses/pxx1.h +++ b/radio/src/pulses/pxx1.h @@ -22,6 +22,7 @@ #define _PULSES_PXX1_H_ #include "pxx.h" +#include "crc.h" struct HeartbeatCapture { uint32_t timestamp; @@ -40,7 +41,7 @@ class Pxx1CrcMixin { void addToCrc(uint8_t byte) { - crc = (crc << 8) ^ (CRCTable[((crc >> 8) ^ byte) & 0xFF]); + crc = (crc << 8) ^ (crc16tab_1189[((crc >> 8) ^ byte) & 0xFF]); } uint16_t crc; diff --git a/radio/src/telemetry/telemetry.h b/radio/src/telemetry/telemetry.h index 5998527b8f..2c9a8f6927 100644 --- a/radio/src/telemetry/telemetry.h +++ b/radio/src/telemetry/telemetry.h @@ -237,10 +237,16 @@ extern OutputTelemetryBuffer outputTelemetryBuffer __DMA; extern Fifo * luaInputTelemetryFifo; #endif -#if defined(STM32) -#define IS_TELEMETRY_INTERNAL_MODULE() (g_model.moduleData[INTERNAL_MODULE].type == MODULE_TYPE_XJT_PXX1) +#if defined(PCBTARANIS) || defined(PCBHORUS) +inline bool isSportLineUsedByInternalModule() +{ + return g_model.moduleData[INTERNAL_MODULE].type == MODULE_TYPE_XJT_PXX1; +} #else -#define IS_TELEMETRY_INTERNAL_MODULE() (false) +inline bool isSportLineUsedByInternalModule() +{ + return false; +} #endif void processPXX2Frame(uint8_t module, uint8_t *frame); diff --git a/radio/src/translations/untranslated.h b/radio/src/translations/untranslated.h index ede2a62a59..d3b44ddebd 100644 --- a/radio/src/translations/untranslated.h +++ b/radio/src/translations/untranslated.h @@ -114,14 +114,14 @@ #define LEN_R9M_LITE_FCC_POWER_VALUES "\010" #define TR_R9M_LITE_FCC_POWER_VALUES "(100mW)" -#define LEN_R9M_LITE_LBT_POWER_VALUES "\017" -#define TR_R9M_LITE_LBT_POWER_VALUES "25mW 8CH Tel\0 ""100mW 8CH NoTel" +#define LEN_R9M_LITE_LBT_POWER_VALUES "\014" +#define TR_R9M_LITE_LBT_POWER_VALUES "25mW 8CH\0 ""25mW 16CH\0 ""100mW NoTele" -#define LEN_R9M_FCC_POWER_VALUES "\012" -#define TR_R9M_FCC_POWER_VALUES "10 mW\0 " "100 mW\0 " "500 mW\0 " "1 W (auto)" +#define LEN_R9M_FCC_POWER_VALUES "\011" +#define TR_R9M_FCC_POWER_VALUES "10mW\0 " "100mW\0 " "500mW\0 " "1W (auto)" -#define LEN_R9M_LBT_POWER_VALUES "\013" -#define TR_R9M_LBT_POWER_VALUES "25 mW 8ch\0 ""25 mW 16ch\0" "200 mW 16ch" "500 mW 16ch" +#define LEN_R9M_LBT_POWER_VALUES "\014" +#define TR_R9M_LBT_POWER_VALUES "25mW 8CH\0 ""25mW 16CH\0 ""200mW NoTele""500mW NoTele" #define LEN_DSM_PROTOCOLS "\004" #define TR_DSM_PROTOCOLS "LP45""DSM2""DSMX"