From 4c40cc457a717050a4a15a991516e9b11445283e Mon Sep 17 00:00:00 2001 From: "Pawel Spychalski (DzikuVx)" Date: Tue, 4 Feb 2020 21:04:26 +0100 Subject: [PATCH] Remove and cleanup on Confuration tab --- _locales/en/messages.json | 6 --- src/css/tabs/configuration.css | 28 +++--------- tabs/configuration.html | 83 +++++++++------------------------- tabs/configuration.js | 81 +-------------------------------- 4 files changed, 30 insertions(+), 168 deletions(-) diff --git a/_locales/en/messages.json b/_locales/en/messages.json index d9ede8de..9294dcc4 100755 --- a/_locales/en/messages.json +++ b/_locales/en/messages.json @@ -654,12 +654,6 @@ "configurationBoardAlignmentYaw": { "message": "Yaw Degrees" }, - "configurationSensorAlignmentGyro": { - "message": "GYRO Alignment" - }, - "configurationSensorAlignmentAcc": { - "message": "ACCEL Alignment" - }, "configurationSensorAlignmentMag": { "message": "MAG Alignment" }, diff --git a/src/css/tabs/configuration.css b/src/css/tabs/configuration.css index e7ec5481..9ef596ba 100644 --- a/src/css/tabs/configuration.css +++ b/src/css/tabs/configuration.css @@ -156,11 +156,14 @@ hr { } .tab-configuration .alignicon { + display: inline-block; + position: relative; width: 20px; height: 20px; - float: left; - margin-left: -5px; - margin-right: 3px; + margin-top: 0px; + margin-left: 6px; + margin-right: 2px; + top: 6px; } .tab-configuration .pitch { @@ -179,24 +182,7 @@ hr { } .tab-configuration .board select { - width: 45%; - height: 20px; - margin: 0 0 2px 0; -} - -.tab-configuration .sensoralignment { - width: 50%; - float: left; -} - -.tab-configuration .board_align_content { - width: 50%; - float: left; -} - -.tab-configuration .sensoralignment span { - width: 55%; - float: left; + width: 110px; } @media only screen and (max-width: 1055px) , only screen and (max-device-width: 1055px) { diff --git a/tabs/configuration.html b/tabs/configuration.html index efa62ace..9bc7e613 100644 --- a/tabs/configuration.html +++ b/tabs/configuration.html @@ -22,21 +22,6 @@
-
- - -
- -
- - -
-
-
@@ -90,54 +75,28 @@
-
-
- -
-
-
- -
-
-
- -
-
+
+ +
+
-
-
- -
-
- -
-
- -
+
+ +
+ +
+
+ +
+ +
+
+ +
+
diff --git a/tabs/configuration.js b/tabs/configuration.js index ffc0d4bc..261a1c47 100644 --- a/tabs/configuration.js +++ b/tabs/configuration.js @@ -189,19 +189,12 @@ TABS.configuration.initialize = function (callback, scrollPosition) { // translate to user-selected language localize(); - var alignments = FC.getSensorAlignments(); - - var orientation_gyro_e = $('select.gyroalign'); - var orientation_acc_e = $('select.accalign'); - var orientation_mag_e = $('select.magalign'); + let alignments = FC.getSensorAlignments(); + let orientation_mag_e = $('select.magalign'); for (i = 0; i < alignments.length; i++) { - orientation_gyro_e.append(''); - orientation_acc_e.append(''); orientation_mag_e.append(''); } - orientation_gyro_e.val(SENSOR_ALIGNMENT.align_gyro); - orientation_acc_e.val(SENSOR_ALIGNMENT.align_acc); orientation_mag_e.val(SENSOR_ALIGNMENT.align_mag); // generate GPS @@ -368,11 +361,6 @@ TABS.configuration.initialize = function (callback, scrollPosition) { var $looptime = $("#looptime"); var $gyroLpf = $("#gyro-lpf"), - $gyroSync = $("#gyro-sync-checkbox"), - $asyncMode = $('#async-mode'), - $gyroFrequency = $('#gyro-frequency'), - $accelerometerFrequency = $('#accelerometer-frequency'), - $attitudeFrequency = $('#attitude-frequency'), $gyroLpfMessage = $('#gyrolpf-info'); var values = FC.getGyroLpfValues(); @@ -385,7 +373,6 @@ TABS.configuration.initialize = function (callback, scrollPosition) { } $gyroLpf.val(INAV_PID_CONFIG.gyroscopeLpf); - $gyroSync.prop("checked", ADVANCED_CONFIG.gyroSync); $gyroLpf.change(function () { INAV_PID_CONFIG.gyroscopeLpf = $gyroLpf.val(); @@ -399,10 +386,6 @@ TABS.configuration.initialize = function (callback, scrollPosition) { $looptime.val(FC.getLooptimes()[FC.getGyroLpfValues()[INAV_PID_CONFIG.gyroscopeLpf].tick].defaultLooptime); $looptime.change(); - GUI.fillSelect($gyroFrequency, FC.getGyroFrequencies()[FC.getGyroLpfValues()[INAV_PID_CONFIG.gyroscopeLpf].tick].looptimes); - $gyroFrequency.val(FC.getLooptimes()[FC.getGyroLpfValues()[INAV_PID_CONFIG.gyroscopeLpf].tick].defaultLooptime); - $gyroFrequency.change(); - $gyroLpfMessage.hide(); $gyroLpfMessage.removeClass('ok-box'); $gyroLpfMessage.removeClass('info-box'); @@ -460,63 +443,6 @@ TABS.configuration.initialize = function (callback, scrollPosition) { }); $looptime.change(); - $gyroFrequency.val(ADVANCED_CONFIG.gyroSyncDenominator * FC.getGyroLpfValues()[INAV_PID_CONFIG.gyroscopeLpf].tick); - $gyroFrequency.change(function () { - ADVANCED_CONFIG.gyroSyncDenominator = Math.floor($gyroFrequency.val() / FC.getGyroLpfValues()[INAV_PID_CONFIG.gyroscopeLpf].tick); - }); - - $gyroSync.change(function () { - if ($(this).is(":checked")) { - ADVANCED_CONFIG.gyroSync = 1; - } else { - ADVANCED_CONFIG.gyroSync = 0; - } - }); - - $gyroSync.change(); - - /* - * Async mode select - */ - GUI.fillSelect($asyncMode, FC.getAsyncModes()); - $asyncMode.val(INAV_PID_CONFIG.asynchronousMode); - $asyncMode.change(function () { - INAV_PID_CONFIG.asynchronousMode = $asyncMode.val(); - - if (INAV_PID_CONFIG.asynchronousMode == 0) { - $('#gyro-sync-wrapper').show(); - $('#gyro-frequency-wrapper').hide(); - $('#accelerometer-frequency-wrapper').hide(); - $('#attitude-frequency-wrapper').hide(); - } else if (INAV_PID_CONFIG.asynchronousMode == 1) { - $('#gyro-sync-wrapper').hide(); - $('#gyro-frequency-wrapper').show(); - $('#accelerometer-frequency-wrapper').hide(); - $('#attitude-frequency-wrapper').hide(); - ADVANCED_CONFIG.gyroSync = 1; - } else { - $('#gyro-sync-wrapper').hide(); - $('#gyro-frequency-wrapper').show(); - $('#accelerometer-frequency-wrapper').show(); - $('#attitude-frequency-wrapper').show(); - ADVANCED_CONFIG.gyroSync = 1; - } - }); - $asyncMode.change(); - - GUI.fillSelect($accelerometerFrequency, FC.getAccelerometerTaskFrequencies(), INAV_PID_CONFIG.accelerometerTaskFrequency, 'Hz'); - $accelerometerFrequency.val(INAV_PID_CONFIG.accelerometerTaskFrequency); - $accelerometerFrequency.change(function () { - INAV_PID_CONFIG.accelerometerTaskFrequency = $accelerometerFrequency.val(); - }); - - GUI.fillSelect($attitudeFrequency, FC.getAttitudeTaskFrequencies(), INAV_PID_CONFIG.attitudeTaskFrequency, 'Hz'); - $attitudeFrequency.val(INAV_PID_CONFIG.attitudeTaskFrequency); - $attitudeFrequency.change(function () { - INAV_PID_CONFIG.attitudeTaskFrequency = $attitudeFrequency.val(); - }); - - var $sensorAcc = $('#sensor-acc'), $sensorMag = $('#sensor-mag'), $sensorBaro = $('#sensor-baro'), @@ -604,9 +530,6 @@ TABS.configuration.initialize = function (callback, scrollPosition) { _3D.deadband3d_throttle = ($('#3ddeadbandthrottle').val()); } - - SENSOR_ALIGNMENT.align_gyro = parseInt(orientation_gyro_e.val()); - SENSOR_ALIGNMENT.align_acc = parseInt(orientation_acc_e.val()); SENSOR_ALIGNMENT.align_mag = parseInt(orientation_mag_e.val()); craftName = $('input[name="craft_name"]').val();