mirror of
https://github.com/iNavFlight/inav-configurator.git
synced 2025-07-24 00:35:20 +03:00
b9fef4e25c
Current MSP handling groups callbacks by their MSP command and when a response comes back it calls all the pending handlers with the same response object. This works fine when all MSP calls are either pure input or pure output (e.g. the have a non-empty payload in just one direction). However, we've had some calls that have a payload in both directions for some time, like MSPV2_SETTING. For those MSP commands, the response will depend on the request, so calling all handlers on the first response received produces the wrong results. It's also problematic on handlers that expect any kind of response, since the DataView object is reused, but its offset was never reset which would result in the second handler getting an empty response. Change this strategy to call just the first pending handlers for the MSP command received in the response. While this is still a theoretical race condition (there's no guarantee a sequence of the same command with different payloads will be replied in the same order as they were issued to the FC), it's the best we can do unless we add some kind of nonce/token system to each MSP request, which would incur a significant overhead. |
||
|---|---|---|
| .. | ||
| libraries | ||
| msp | ||
| protocols | ||
| workers | ||
| appUpdater.js | ||
| boards.js | ||
| data_storage.js | ||
| debug_trace.js | ||
| defaults_dialog.js | ||
| eventFrequencyAnalyzer.js | ||
| fc.js | ||
| feature_framework.js | ||
| gui.js | ||
| helpers.js | ||
| injected_methods.js | ||
| intervals.js | ||
| localization.js | ||
| logicCondition.js | ||
| logicConditionsCollection.js | ||
| logicConditionsStatus.js | ||
| model.js | ||
| motorMixerRuleCollection.js | ||
| motorMixRule.js | ||
| msp.js | ||
| msp_balanced_interval.js | ||
| outputMapping.js | ||
| periodicStatusUpdater.js | ||
| peripherals.js | ||
| pid_controller.js | ||
| port_handler.js | ||
| serial.js | ||
| serial_backend.js | ||
| serial_queue.js | ||
| servoMixerRuleCollection.js | ||
| servoMixRule.js | ||
| settings.js | ||
| simple_smooth_filter.js | ||
| tabs.js | ||
| tasks.js | ||
| timeouts.js | ||
| vtx.js | ||
| walking_average_filter.js | ||