Fix a bunch more compilation warnings

src/main/common/filter.c

@@ -148,16 +148,18 @@ void biquadFilterInit(biquadFilter_t *filter, uint16_t filterFreq, uint32_t samp
 
         float b0, b1, b2;
         switch (filterType) {
-        case FILTER_LPF:
+            case FILTER_LPF:
-            b0 = (1 - cs) / 2;
+                b0 = (1 - cs) / 2;
-            b1 = 1 - cs;
+                b1 = 1 - cs;
-            b2 = (1 - cs) / 2;
+                b2 = (1 - cs) / 2;
-            break;
+                break;
-        case FILTER_NOTCH:
+            case FILTER_NOTCH:
-            b0 =  1;
+                b0 = 1;
-            b1 = -2 * cs;
+                b1 = -2 * cs;
-            b2 =  1;
+                b2 = 1;
-            break;
+                break;
+            default:
+                goto initError;
         }
         const float a0 =  1 + alpha;
         const float a1 = -2 * cs;
@@ -172,16 +174,23 @@ void biquadFilterInit(biquadFilter_t *filter, uint16_t filterFreq, uint32_t samp
     }
     else {
         // Not possible to filter frequencies above Nyquist frequency - passthrough
-        filter->b0 = 1.0f;
+        goto initError;
-        filter->b1 = 0.0f;
-        filter->b2 = 0.0f;
-        filter->a1 = 0.0f;
-        filter->a2 = 0.0f;
     }
 
     // zero initial samples
     filter->x1 = filter->x2 = 0;
     filter->y1 = filter->y2 = 0;
+
+    return;
+
+    initError:
+
+    // passthrough
+    filter->b0 = 1.0f;
+    filter->b1 = 0.0f;
+    filter->b2 = 0.0f;
+    filter->a1 = 0.0f;
+    filter->a2 = 0.0f;
 }
 
 FAST_CODE float biquadFilterApplyDF1(biquadFilter_t *filter, float input)
@@ -231,4 +240,4 @@ FAST_CODE void biquadFilterUpdate(biquadFilter_t *filter, float filterFreq, uint
     filter->x2 = x2;
     filter->y1 = y1;
     filter->y2 = y2;
-}
+}

src/main/io/asyncfatfs/asyncfatfs.c

@@ -1694,6 +1694,8 @@ static afatfsOperationStatus_e afatfs_appendSuperclusterContinue(afatfsFile_t *f
             // Update the fileSize/firstCluster in the directory entry for the file
             status = afatfs_saveDirectoryEntry(file, AFATFS_SAVE_DIRECTORY_NORMAL);
         break;
+        default:
+            status = AFATFS_OPERATION_FAILURE;
     }
 
     if ((status == AFATFS_OPERATION_FAILURE || status == AFATFS_OPERATION_SUCCESS) && file->operation.operation == AFATFS_FILE_OPERATION_APPEND_SUPERCLUSTER) {
@@ -2487,6 +2489,8 @@ static afatfsOperationStatus_e afatfs_ftruncateContinue(afatfsFilePtr_t file, bo
 
             return AFATFS_OPERATION_SUCCESS;
         break;
+        default:
+            status = AFATFS_OPERATION_FAILURE;
     }
 
     if (status == AFATFS_OPERATION_FAILURE && file->operation.operation == AFATFS_FILE_OPERATION_TRUNCATE) {

src/main/io/osd.c

@@ -417,6 +417,7 @@ static void osdFormatWindSpeedStr(char *buff, int32_t ws, bool isValid)
             centivalue = (ws * 224) / 100;
             suffix = SYM_MPH;
             break;
+        default:
         case OSD_UNIT_METRIC:
             centivalue = (ws * 36) / 10;
             suffix = SYM_KMH;
@@ -1011,6 +1012,7 @@ static void osdDrawMap(int referenceHeading, uint8_t referenceSym, uint8_t cente
             break;
         case OSD_UNIT_UK:
             FALLTHROUGH;
+        default:
         case OSD_UNIT_METRIC:
             initialScale = 10; // 10m as initial scale
             break;
@@ -1844,6 +1846,7 @@ static bool osdDrawSingleElement(uint8_t item)
                     value = CENTIMETERS_TO_CENTIFEET(value);
                     sym = SYM_FTS;
                     break;
+                default:
                 case OSD_UNIT_METRIC:
                     // Already in cm/s
                     sym = SYM_MS;
@@ -2325,6 +2328,7 @@ static bool osdDrawSingleElement(uint8_t item)
                 break;
             case OSD_UNIT_UK:
                 FALLTHROUGH;
+            default:
             case OSD_UNIT_METRIC:
                 scaleToUnit = 100; // scale to cm for osdFormatCentiNumber()
                 scaleUnitDivisor = 1000; // Convert to km when scale gets bigger than 999m

src/main/io/osd_grid.c

@@ -225,7 +225,7 @@ static uint8_t osdUpdateSidebar(osd_sidebar_scroll_e scroll, osd_sidebar_t *side
     // Scroll between SYM_AH_DECORATION_MIN and SYM_AH_DECORATION_MAX.
     // Zero scrolling should draw SYM_AH_DECORATION.
     uint8_t decoration = SYM_AH_DECORATION;
-    int offset;
+    int offset = 0;
     int steps;
     switch (scroll) {
         case OSD_SIDEBAR_SCROLL_NONE:
@@ -240,8 +240,6 @@ static uint8_t osdUpdateSidebar(osd_sidebar_scroll_e scroll, osd_sidebar_t *side
         case OSD_SIDEBAR_SCROLL_GROUND_SPEED:
 #if defined(USE_GPS)
             offset = gpsSol.groundSpeed;
-#else
-            offset = 0;
 #endif
             // Move 1 char for every 20 cm/s
             steps = offset / 20;
@@ -249,8 +247,6 @@ static uint8_t osdUpdateSidebar(osd_sidebar_scroll_e scroll, osd_sidebar_t *side
         case OSD_SIDEBAR_SCROLL_HOME_DISTANCE:
 #if defined(USE_GPS)
             offset = GPS_distanceToHome;
-#else
-            offset = 0;
 #endif
             // Move 1 char for every 5m
             steps = offset / 5;

src/main/io/smartport_master.c

@@ -300,6 +300,9 @@ static void smartportMasterPoll(void)
                 break;
             }
 
+            default: // should not happen
+                return;
+
         }
 
     }