Mirror/inav
1
0
Fork 0
mirror of https://github.com/iNavFlight/inav.git synced 2025-07-19 06:15:14 +03:00
Code Issues Wiki Activity

NAV: More consistent detection of good GPS on arming. BEEPER_ARMING_GPS_FIX will be triggered based on position estimation status, not satellite count

Browse source
This commit is contained in:
Konstantin Sharlaimov (DigitalEntity) 2016-04-10 22:28:03 +10:00
parent e5726c3c35
commit 2131daf42e
3 changed files with 10 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/main/flight/navigation_rewrite.c
View file

@ -2109,6 +2109,12 @@ bool naivationBlockArming(void)
return shouldBlockArming;
}
bool navigationPositionEstimateIsHealthy(void)
{
return posControl.flags.hasValidPositionSensor && STATE(GPS_FIX_HOME);
}
/**
* Indicate ready/not ready status
*/
@ -2117,7 +2123,7 @@ static void updateReadyStatus(void)
static bool posReadyBeepDone = false;
/* Beep out READY_BEEP once when position lock is firstly acquired and HOME set */
if (posControl.flags.hasValidPositionSensor && STATE(GPS_FIX_HOME) && !posReadyBeepDone) {
if (navigationPositionEstimateIsHealthy() && !posReadyBeepDone) {
beeper(BEEPER_READY_BEEP);
posReadyBeepDone = true;
}

1
src/main/flight/navigation_rewrite.h
View file

@ -241,6 +241,7 @@ bool naivationRequiresAngleMode(void);
bool navigationRequiresThrottleTiltCompensation(void);
int8_t naivationGetHeadingControlState(void);
bool naivationBlockArming(void);
bool navigationPositionEstimateIsHealthy(void);
/* Access to estimated position and velocity */
float getEstimatedActualVelocity(int axis);

4
src/main/mw.c
View file

@ -260,8 +260,8 @@ void mwArm(void)
disarmAt = millis() + masterConfig.auto_disarm_delay * 1000; // start disarm timeout, will be extended when throttle is nonzero
//beep to indicate arming
#ifdef GPS
if (feature(FEATURE_GPS) && STATE(GPS_FIX) && gpsSol.numSat >= 5)
#ifdef NAV
if (navigationPositionEstimateIsHealthy())
beeper(BEEPER_ARMING_GPS_FIX);
else
beeper(BEEPER_ARMING);