Mirror/libcamera
1
0
Fork 0
mirror of https://git.libcamera.org/libcamera/libcamera.git synced 2025-07-13 07:19:45 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

android: camera_device: Mark abortRequest() and notifyError() as const

Browse source 
abortRequest() and notifyError() do not modify any members of
CameraDevice hence, these functions can be const.

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
This commit is contained in:
Umang Jain 2021-09-29 19:00:29 +05:30
parent 8e7feeb5e7
commit 05c87a36cb
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/android/camera_device.cpp
View file

@ -860,7 +860,7 @@ int CameraDevice::processControls(Camera3RequestDescriptor *descriptor)
return 0; return 0;
} }
void CameraDevice::abortRequest(camera3_capture_request_t *request) void CameraDevice::abortRequest(camera3_capture_request_t *request) const
{ {
notifyError(request->frame_number, nullptr, CAMERA3_MSG_ERROR_REQUEST); notifyError(request->frame_number, nullptr, CAMERA3_MSG_ERROR_REQUEST);
@ -1258,7 +1258,7 @@ void CameraDevice::notifyShutter(uint32_t frameNumber, uint64_t timestamp)
} }
void CameraDevice::notifyError(uint32_t frameNumber, camera3_stream_t *stream, void CameraDevice::notifyError(uint32_t frameNumber, camera3_stream_t *stream,
camera3_error_msg_code code) camera3_error_msg_code code) const
{ {
camera3_notify_msg_t notify = {}; camera3_notify_msg_t notify = {};

4
src/android/camera_device.h
View file

@ -99,11 +99,11 @@ private:
createFrameBuffer(const buffer_handle_t camera3buffer, createFrameBuffer(const buffer_handle_t camera3buffer,
libcamera::PixelFormat pixelFormat, libcamera::PixelFormat pixelFormat,
const libcamera::Size &size); const libcamera::Size &size);
void abortRequest(camera3_capture_request_t *request); void abortRequest(camera3_capture_request_t *request) const;
bool isValidRequest(camera3_capture_request_t *request) const; bool isValidRequest(camera3_capture_request_t *request) const;
void notifyShutter(uint32_t frameNumber, uint64_t timestamp); void notifyShutter(uint32_t frameNumber, uint64_t timestamp);
void notifyError(uint32_t frameNumber, camera3_stream_t *stream, void notifyError(uint32_t frameNumber, camera3_stream_t *stream,
camera3_error_msg_code code); camera3_error_msg_code code) const;
int processControls(Camera3RequestDescriptor *descriptor); int processControls(Camera3RequestDescriptor *descriptor);
std::unique_ptr<CameraMetadata> getResultMetadata( std::unique_ptr<CameraMetadata> getResultMetadata(
const Camera3RequestDescriptor &descriptor) const; const Camera3RequestDescriptor &descriptor) const;