Mirror/libcamera
1
0
Fork 0
mirror of https://git.libcamera.org/libcamera/libcamera.git synced 2025-07-24 17:15:07 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

controls: Add boolean constructors for ControlInfo

Browse source 
It would be convenient to be able to iterate over available boolean
values, for example for controls that designate if some function can be
enabled/disabled. The current min/max/def constructor is insufficient,
as .values() is empty, so the values cannot be easily iterated over, and
creating a Span of booleans does not work for the values constructor.

Add new constructors to ControlInfo that takes a set of booleans (if
both booleans are valid values) plus a default, and another that takes
only one boolean (if only one boolean is a valid value).

Update the ControlInfo test accordingly.

Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
This commit is contained in:
Paul Elder 2021-07-02 19:37:45 +09:00
parent fba85e6901
commit 10cdc914da
3 changed files with 65 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

33
test/controls/control_info.cpp
View file

@ -44,6 +44,39 @@ protected:
return TestFail;
}
/*
* Test information retrieval from a control with boolean
* values.
*/
ControlInfo aeEnable({ false, true }, false);
if (aeEnable.min().get<bool>() != false ||
aeEnable.def().get<bool>() != false ||
aeEnable.max().get<bool>() != true) {
cout << "Invalid control range for AeEnable" << endl;
return TestFail;
}
if (aeEnable.values()[0].get<bool>() != false ||
aeEnable.values()[1].get<bool>() != true) {
cout << "Invalid control values for AeEnable" << endl;
return TestFail;
}
ControlInfo awbEnable(true);
if (awbEnable.min().get<bool>() != true ||
awbEnable.def().get<bool>() != true ||
awbEnable.max().get<bool>() != true) {
cout << "Invalid control range for AwbEnable" << endl;
return TestFail;
}
if (awbEnable.values()[0].get<bool>() != true) {
cout << "Invalid control values for AwbEnable" << endl;
return TestFail;
}
return TestPass;
}
};