Mirror/libcamera
1
0
Fork 0
mirror of https://git.libcamera.org/libcamera/libcamera.git synced 2025-07-13 15:29:45 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

ipa: raspberrypi: Code refactoring to match style guidelines

Browse source 
Refactor all the source files in src/ipa/raspberrypi/ to match the recommended
formatting guidelines for the libcamera project. The vast majority of changes
in this commit comprise of switching from snake_case to CamelCase, and starting
class member functions with a lower case character.

Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
Naushir Patuck 2022-07-27 09:55:17 +01:00 • committed by Laurent Pinchart
parent b4a3eb6b98
commit 177df04d2b
63 changed files with 2093 additions and 2161 deletions
Download patch file Download diff file Expand all files Collapse all files

42
src/ipa/raspberrypi/controller/rpi/sharpen.cpp
View file

@ -21,23 +21,23 @@ LOG_DEFINE_CATEGORY(RPiSharpen)
#define NAME "rpi.sharpen"
Sharpen::Sharpen(Controller *controller)
: SharpenAlgorithm(controller), user_strength_(1.0)
: SharpenAlgorithm(controller), userStrength_(1.0)
{
}
char const *Sharpen::Name() const
char const *Sharpen::name() const
{
return NAME;
}
void Sharpen::SwitchMode(CameraMode const &camera_mode,
void Sharpen::switchMode(CameraMode const &cameraMode,
[[maybe_unused]] Metadata *metadata)
{
// can't be less than one, right?
mode_factor_ = std::max(1.0, camera_mode.noise_factor);
modeFactor_ = std::max(1.0, cameraMode.noiseFactor);
}
void Sharpen::Read(boost::property_tree::ptree const &params)
void Sharpen::read(boost::property_tree::ptree const &params)
{
threshold_ = params.get<double>("threshold", 1.0);
strength_ = params.get<double>("strength", 1.0);
@ -48,38 +48,38 @@ void Sharpen::Read(boost::property_tree::ptree const &params)
<< " limit " << limit_;
}
void Sharpen::SetStrength(double strength)
void Sharpen::setStrength(double strength)
{
// Note that this function is how an application sets the overall
// sharpening "strength". We call this the "user strength" field
// as there already is a strength_ field - being an internal gain
// parameter that gets passed to the ISP control code. Negative
// values are not allowed - coerce them to zero (no sharpening).
user_strength_ = std::max(0.0, strength);
userStrength_ = std::max(0.0, strength);
}
void Sharpen::Prepare(Metadata *image_metadata)
void Sharpen::prepare(Metadata *imageMetadata)
{
// The user_strength_ affects the algorithm's internal gain directly, but
// The userStrength_ affects the algorithm's internal gain directly, but
// we adjust the limit and threshold less aggressively. Using a sqrt
// function is an arbitrary but gentle way of accomplishing this.
double user_strength_sqrt = sqrt(user_strength_);
double userStrengthSqrt = sqrt(userStrength_);
struct SharpenStatus status;
// Binned modes seem to need the sharpening toned down with this
// pipeline, thus we use the mode_factor here. Also avoid
// divide-by-zero with the user_strength_sqrt.
status.threshold = threshold_ * mode_factor_ /
std::max(0.01, user_strength_sqrt);
status.strength = strength_ / mode_factor_ * user_strength_;
status.limit = limit_ / mode_factor_ * user_strength_sqrt;
// Finally, report any application-supplied parameters that were used.
status.user_strength = user_strength_;
image_metadata->Set("sharpen.status", status);
// pipeline, thus we use the modeFactor_ here. Also avoid
// divide-by-zero with the userStrengthSqrt.
status.threshold = threshold_ * modeFactor_ /
std::max(0.01, userStrengthSqrt);
status.strength = strength_ / modeFactor_ * userStrength_;
status.limit = limit_ / modeFactor_ * userStrengthSqrt;
/* Finally, report any application-supplied parameters that were used. */
status.userStrength = userStrength_;
imageMetadata->set("sharpen.status", status);
}
// Register algorithm with the system.
static Algorithm *Create(Controller *controller)
static Algorithm *create(Controller *controller)
{
return new Sharpen(controller);
}
static RegisterAlgorithm reg(NAME, &Create);
static RegisterAlgorithm reg(NAME, &create);