Mirror/libcamera
1
0
Fork 0
mirror of https://git.libcamera.org/libcamera/libcamera.git synced 2025-07-13 15:29:45 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

android: camera_device: Use YUV post-processor

Browse source 
When creating the list of StreamConfiguration to be requested to the camera,
map NV12 streams of equal size and format together, so that they will be
generated by using the YUV post-processor.

Signed-off-by: Hirokazu Honda <hiroh@chromium.org>
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
Hirokazu Honda 2022-05-27 18:34:39 +09:00 • committed by Jacopo Mondi
parent 7ea83eba0d
commit 246d3f631b
1 changed files with 29 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

32
src/android/camera_device.cpp
View file

@ -605,14 +605,40 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)
continue;
}
/*
* While gralloc usage flags are supposed to report usage
* patterns to select a suitable buffer allocation strategy, in
* practice they're also used to make other decisions, such as
* selecting the actual format for the IMPLEMENTATION_DEFINED
* HAL pixel format. To avoid issues, we thus have to set the
* GRALLOC_USAGE_HW_CAMERA_WRITE flag unconditionally, even for
* streams that will be produced in software.
*/
stream->usage |= GRALLOC_USAGE_HW_CAMERA_WRITE;
/*
* If a CameraStream with the same size and format as the
* current stream has already been requested, associate the two.
*/
auto iter = std::find_if(
streamConfigs.begin(), streamConfigs.end(),
[&size, &format](const Camera3StreamConfig &streamConfig) {
return streamConfig.config.size == size &&
streamConfig.config.pixelFormat == format;
});
if (iter != streamConfigs.end()) {
/* Add usage to copy the buffer in streams[0] to stream. */
iter->streams[0].stream->usage |= GRALLOC_USAGE_SW_READ_OFTEN;
stream->usage |= GRALLOC_USAGE_SW_WRITE_OFTEN;
iter->streams.push_back({ stream, CameraStream::Type::Mapped });
continue;
}
Camera3StreamConfig streamConfig;
streamConfig.streams = { { stream, CameraStream::Type::Direct } };
streamConfig.config.size = size;
streamConfig.config.pixelFormat = format;
streamConfigs.push_back(std::move(streamConfig));
/* This stream will be produced by hardware. */
stream->usage |= GRALLOC_USAGE_HW_CAMERA_WRITE;
}
/* Now handle the MJPEG streams, adding a new stream if required. */