Mirror/libcamera
1
0
Fork 0
mirror of https://git.libcamera.org/libcamera/libcamera.git synced 2025-07-23 16:45:07 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

ipa: rpi: agc: Fix bug where AeLocked was never getting set

Browse source 
The recent change where time-filtering is done before sorting out the
digital gain means that the target exposure without digital gain is no
longer set, breaking the 'AeLocked' calculation.

We can use the regular (full) target exposure instead.

Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
Fixes: 84b6327789 ("ipa: rpi: agc: Filter exposures before dealing with digital gain")
Reviewed-by: Naushir Patuck <naush@raspberrypi.com>
Acked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
This commit is contained in:
David Plowman 2023-11-10 10:45:20 +00:00 • committed by Kieran Bingham
parent cbfbab48a7
commit 2905eabad9
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/ipa/rpi/controller/rpi/agc_channel.cpp
View file

@ -977,7 +977,7 @@ void AgcChannel::divideUpExposure()
void AgcChannel::writeAndFinish(Metadata *imageMetadata, bool desaturate) void AgcChannel::writeAndFinish(Metadata *imageMetadata, bool desaturate)
{ {
status_.totalExposureValue = filtered_.totalExposure; status_.totalExposureValue = filtered_.totalExposure;
status_.targetExposureValue = desaturate ? 0s : target_.totalExposureNoDG; status_.targetExposureValue = desaturate ? 0s : target_.totalExposure;
status_.shutterTime = filtered_.shutter; status_.shutterTime = filtered_.shutter;
status_.analogueGain = filtered_.analogueGain; status_.analogueGain = filtered_.analogueGain;
/* /*