Mirror/libcamera
1
0
Fork 0
mirror of https://git.libcamera.org/libcamera/libcamera.git synced 2025-07-12 23:09:45 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

ipa: rpi: controller: Autofocus CAF/PDAF stability tweak

Browse source 
When in Continuous AF mode using PDAF, only move the lens when
phase has had the same sign for at least 4 frames. This reduces
lens wobble in e.g. noisy conditions.

Signed-off-by: Nick Hollinghurst <nick.hollinghurst@raspberrypi.com>
Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
Reviewed-by: Naushir Patuck <naush@raspberrypi.com>
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
This commit is contained in:
Nick Hollinghurst 2025-06-20 13:42:25 +01:00 • committed by Kieran Bingham
parent 0fa2b05a86
commit 429a5ab48f
2 changed files with 13 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/ipa/rpi/controller/rpi/af.cpp
View file

@ -181,9 +181,11 @@ Af::Af(Controller *controller)
ftarget_(-1.0), ftarget_(-1.0),
fsmooth_(-1.0), fsmooth_(-1.0),
prevContrast_(0.0), prevContrast_(0.0),
prevPhase_(0.0),
skipCount_(0), skipCount_(0),
stepCount_(0), stepCount_(0),
dropCount_(0), dropCount_(0),
sameSignCount_(0),
scanMaxContrast_(0.0), scanMaxContrast_(0.0),
scanMinContrast_(1.0e9), scanMinContrast_(1.0e9),
scanData_(), scanData_(),
@ -513,6 +515,13 @@ void Af::doAF(double contrast, double phase, double conf)
return; return;
} }
/* Count frames for which PDAF phase has had same sign */
if (phase * prevPhase_ <= 0.0)
sameSignCount_ = 0;
else
sameSignCount_++;
prevPhase_ = phase;
if (scanState_ == ScanState::Pdaf) { if (scanState_ == ScanState::Pdaf) {
/* /*
* Use PDAF closed-loop control whenever available, in both CAF * Use PDAF closed-loop control whenever available, in both CAF
@ -522,7 +531,8 @@ void Af::doAF(double contrast, double phase, double conf)
* scan only after a number of frames with low PDAF confidence. * scan only after a number of frames with low PDAF confidence.
*/ */
if (conf > (dropCount_ ? 1.0 : 0.25) * cfg_.confEpsilon) { if (conf > (dropCount_ ? 1.0 : 0.25) * cfg_.confEpsilon) {
doPDAF(phase, conf); if (mode_ == AfModeAuto || sameSignCount_ >= 3)
doPDAF(phase, conf);
if (stepCount_ > 0) if (stepCount_ > 0)
stepCount_--; stepCount_--;
else if (mode_ != AfModeContinuous) else if (mode_ != AfModeContinuous)

2
src/ipa/rpi/controller/rpi/af.h
View file

@ -158,7 +158,9 @@ private:
bool initted_; bool initted_;
double ftarget_, fsmooth_; double ftarget_, fsmooth_;
double prevContrast_; double prevContrast_;
double prevPhase_;
unsigned skipCount_, stepCount_, dropCount_; unsigned skipCount_, stepCount_, dropCount_;
unsigned sameSignCount_;
unsigned scanMaxIndex_; unsigned scanMaxIndex_;
double scanMaxContrast_, scanMinContrast_; double scanMaxContrast_, scanMinContrast_;
std::vector<ScanRecord> scanData_; std::vector<ScanRecord> scanData_;