Mirror/libcamera
1
0
Fork 0
mirror of https://git.libcamera.org/libcamera/libcamera.git synced 2025-07-15 00:19:44 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

libcamera: ipa: raspberrypi: agc: Remove unnecessary locking

Browse source 
On the libcamera/VC4 platform the AGC Prepare/Process methods, and any
changes to the AGC settings, run synchronously - so a number of
mutexes and copies are unnecessary and can be removed.

Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
Reviewed-by: Naushir Patuck <naush@raspberrypi.com>
Acked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
This commit is contained in:
David Plowman 2020-11-23 07:37:56 +00:00 • committed by Kieran Bingham
parent dbe573979c
commit 42f4e313af
2 changed files with 36 additions and 67 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/ipa/raspberrypi/controller/rpi/agc.hpp
View file

@ -106,12 +106,9 @@ private:
ExposureValues current_; // values for the current frame
ExposureValues target_; // calculate the values we want here
ExposureValues filtered_; // these values are filtered towards target
AgcStatus status_; // to "latch" settings so they can't change
AgcStatus output_status_; // the status we will write out
std::mutex output_mutex_;
AgcStatus status_;
int lock_count_;
// Below here the "settings" that applications can change.
std::mutex settings_mutex_;
std::string metering_mode_name_;
std::string exposure_mode_name_;
std::string constraint_mode_name_;