Mirror/libcamera
1
0
Fork 0
mirror of https://git.libcamera.org/libcamera/libcamera.git synced 2025-07-12 23:09:45 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

treewide: Avoid some copies in range-based for loops

Browse source 
Most of these have been found by the `performance-for-range-copy`
check of `clang-tidy`.

Signed-off-by: Barnabás Pőcze <pobrn@protonmail.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
Barnabás Pőcze 2024-11-26 18:03:10 +00:00 • committed by Laurent Pinchart
parent 4e557e544b
commit 493f198e94
5 changed files with 8 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/libcamera/camera_manager.cpp
View file

@ -388,7 +388,7 @@ std::shared_ptr<Camera> CameraManager::get(const std::string &id)
MutexLocker locker(d->mutex_);
for (std::shared_ptr<Camera> camera : d->cameras_) {
for (const std::shared_ptr<Camera> &camera : d->cameras_) {
if (camera->id() == id)
return camera;
}

5
src/libcamera/converter.cpp
View file

@ -325,8 +325,9 @@ std::vector<std::string> ConverterFactoryBase::names()
for (ConverterFactoryBase *factory : factories) {
list.push_back(factory->name_);
for (auto alias : factory->compatibles())
list.push_back(alias);
const auto &compatibles = factory->compatibles();
list.insert(list.end(), compatibles.begin(), compatibles.end());
}
return list;

2
src/libcamera/pipeline/virtual/image_frame_generator.cpp
View file

@ -39,7 +39,7 @@ ImageFrameGenerator::create(ImageFrames &imageFrames)
* For each file in the directory, load the image,
* convert it to NV12, and store the pointer.
*/
for (std::filesystem::path path : imageFrames.files) {
for (const auto &path : imageFrames.files) {
File file(path);
if (!file.open(File::OpenModeFlag::ReadOnly)) {
LOG(Virtual, Error) << "Failed to open image file " << file.fileName()

2
src/libcamera/pipeline_handler.cpp
View file

@ -74,7 +74,7 @@ PipelineHandler::PipelineHandler(CameraManager *manager)
PipelineHandler::~PipelineHandler()
{
for (std::shared_ptr<MediaDevice> media : mediaDevices_)
for (std::shared_ptr<MediaDevice> &media : mediaDevices_)
media->release();
}

11
test/gstreamer/gstreamer_device_provider_test.cpp
View file

@ -52,19 +52,12 @@ protected:
for (l = devices; l != NULL; l = g_list_next(l)) {
GstDevice *device = GST_DEVICE(l->data);
g_autofree gchar *gst_name;
bool matched = false;
g_autoptr(GstElement) element = gst_device_create_element(device, NULL);
g_object_get(element, "camera-name", &gst_name, NULL);
for (auto name : cameraNames) {
if (strcmp(name.c_str(), gst_name) == 0) {
matched = true;
break;
}
}
if (!matched)
if (std::find(cameraNames.begin(), cameraNames.end(), gst_name) ==
cameraNames.end())
return TestFail;
}