mirror of
https://git.libcamera.org/libcamera/libcamera.git
synced 2025-07-13 23:39:44 +03:00
utils: checkstyle.py: Add a check for hex values
libcamera uses lowercase hex values. Add a corresponding checker. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Paul Elder <paul.elder@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Tested-by: Milan Zamazal <mzamazal@redhat.com>
This commit is contained in:
parent
5d2c8fa11b
commit
4a7c9ce467
1 changed files with 28 additions and 0 deletions
|
@ -562,6 +562,34 @@ class StyleIssue(object):
|
||||||
self.msg = msg
|
self.msg = msg
|
||||||
|
|
||||||
|
|
||||||
|
class HexValueChecker(StyleChecker):
|
||||||
|
patterns = ('*.c', '*.cpp', '*.h')
|
||||||
|
|
||||||
|
regex = re.compile(r'\b0[xX][0-9a-fA-F]+\b')
|
||||||
|
|
||||||
|
def __init__(self, content):
|
||||||
|
super().__init__()
|
||||||
|
self.__content = content
|
||||||
|
|
||||||
|
def check(self, line_numbers):
|
||||||
|
issues = []
|
||||||
|
|
||||||
|
for line_number in line_numbers:
|
||||||
|
line = self.__content[line_number - 1]
|
||||||
|
match = HexValueChecker.regex.search(line)
|
||||||
|
if not match:
|
||||||
|
continue
|
||||||
|
|
||||||
|
value = match.group(0)
|
||||||
|
if value == value.lower():
|
||||||
|
continue
|
||||||
|
|
||||||
|
issues.append(StyleIssue(line_number, line,
|
||||||
|
f'Use lowercase hex constant {value.lower()}'))
|
||||||
|
|
||||||
|
return issues
|
||||||
|
|
||||||
|
|
||||||
class IncludeChecker(StyleChecker):
|
class IncludeChecker(StyleChecker):
|
||||||
patterns = ('*.cpp', '*.h')
|
patterns = ('*.cpp', '*.h')
|
||||||
|
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue