Mirror/libcamera
1
0
Fork 0
mirror of https://git.libcamera.org/libcamera/libcamera.git synced 2025-07-25 17:45:06 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

libcamera: v4l2_subdevice: Drop V4L2SubdeviceFormat::bitsPerPixel()

Browse source 
The V4L2SubdeviceFormat::bitsPerPixel() function is just a wrapper
around a MediaBusFormatInfo lookup. It made sense when the
MediaBusFormatInfo class was not exposed outside of the compilation
unit, but is now redundant. Drop it and use MediaBusFormatInfo in the
only caller.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
This commit is contained in:
Laurent Pinchart 2024-02-26 13:15:18 +02:00
parent 7941903d62
commit 4c82481fc4
3 changed files with 2 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

1
include/libcamera/internal/v4l2_subdevice.h
View file

@ -66,7 +66,6 @@ struct V4L2SubdeviceFormat {
std::optional<ColorSpace> colorSpace; std::optional<ColorSpace> colorSpace;
const std::string toString() const; const std::string toString() const;
uint8_t bitsPerPixel() const;
}; };
std::ostream &operator<<(std::ostream &out, const V4L2SubdeviceFormat &f); std::ostream &operator<<(std::ostream &out, const V4L2SubdeviceFormat &f);

3
src/libcamera/camera_sensor.cpp
View file

@ -1060,7 +1060,8 @@ int CameraSensor::sensorInfo(IPACameraSensorInfo *info) const
ret = subdev_->getFormat(pad_, &format); ret = subdev_->getFormat(pad_, &format);
if (ret) if (ret)
return ret; return ret;
info->bitsPerPixel = format.bitsPerPixel();
info->bitsPerPixel = MediaBusFormatInfo::info(format.mbus_code).bitsPerPixel;
info->outputSize = format.size; info->outputSize = format.size;
std::optional<int32_t> cfa = properties_.get(properties::draft::ColorFilterArrangement); std::optional<int32_t> cfa = properties_.get(properties::draft::ColorFilterArrangement);

10
src/libcamera/v4l2_subdevice.cpp
View file

@ -793,16 +793,6 @@ const std::string V4L2SubdeviceFormat::toString() const
return ss.str(); return ss.str();
} }
/**
* \brief Retrieve the number of bits per pixel for the V4L2 subdevice format
* \return The number of bits per pixel for the format, or 0 if the format is
* not supported
*/
uint8_t V4L2SubdeviceFormat::bitsPerPixel() const
{
return MediaBusFormatInfo::info(mbus_code).bitsPerPixel;
}
/** /**
* \brief Insert a text representation of a V4L2SubdeviceFormat into an output * \brief Insert a text representation of a V4L2SubdeviceFormat into an output
* stream * stream