Mirror/libcamera
1
0
Fork 0
mirror of https://git.libcamera.org/libcamera/libcamera.git synced 2025-07-23 08:35:07 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

ipa: vimc: Establish logical order of operations

Browse source 
It is preferred that the interface definition should represent
the logical order in which the operations will be called.

The patch has no functional changes.

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
This commit is contained in:
Umang Jain 2022-04-08 15:51:45 +05:30
parent 1724077225
commit 52cd4dacd0
2 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
include/libcamera/ipa/vimc.mojom
View file

@ -30,6 +30,7 @@ interface IPAVimcInterface {
mapBuffers(array<libcamera.IPABuffer> buffers); mapBuffers(array<libcamera.IPABuffer> buffers);
unmapBuffers(array<uint32> ids); unmapBuffers(array<uint32> ids);
[async] queueRequest(uint32 frame, libcamera.ControlList controls);
/* /*
* The vimc driver doesn't use parameters buffers. To maximize coverage * The vimc driver doesn't use parameters buffers. To maximize coverage
* of unit tests that rely on the VIMC pipeline handler, we still define * of unit tests that rely on the VIMC pipeline handler, we still define
@ -37,7 +38,6 @@ interface IPAVimcInterface {
* handle parameters at runtime. * handle parameters at runtime.
*/ */
[async] fillParams(uint32 frame, uint32 bufferId); [async] fillParams(uint32 frame, uint32 bufferId);
[async] queueRequest(uint32 frame, libcamera.ControlList controls);
}; };
interface IPAVimcEventInterface { interface IPAVimcEventInterface {

12
src/ipa/vimc/vimc.cpp
View file

@ -43,8 +43,8 @@ public:
void mapBuffers(const std::vector<IPABuffer> &buffers) override; void mapBuffers(const std::vector<IPABuffer> &buffers) override;
void unmapBuffers(const std::vector<unsigned int> &ids) override; void unmapBuffers(const std::vector<unsigned int> &ids) override;
void fillParams(uint32_t frame, uint32_t bufferId) override;
void queueRequest(uint32_t frame, const ControlList &controls) override; void queueRequest(uint32_t frame, const ControlList &controls) override;
void fillParams(uint32_t frame, uint32_t bufferId) override;
private: private:
void initTrace(); void initTrace();
@ -129,6 +129,11 @@ void IPAVimc::unmapBuffers(const std::vector<unsigned int> &ids)
} }
} }
void IPAVimc::queueRequest([[maybe_unused]] uint32_t frame,
[[maybe_unused]] const ControlList &controls)
{
}
void IPAVimc::fillParams([[maybe_unused]] uint32_t frame, uint32_t bufferId) void IPAVimc::fillParams([[maybe_unused]] uint32_t frame, uint32_t bufferId)
{ {
auto it = buffers_.find(bufferId); auto it = buffers_.find(bufferId);
@ -140,11 +145,6 @@ void IPAVimc::fillParams([[maybe_unused]] uint32_t frame, uint32_t bufferId)
paramsFilled.emit(bufferId); paramsFilled.emit(bufferId);
} }
void IPAVimc::queueRequest([[maybe_unused]] uint32_t frame,
[[maybe_unused]] const ControlList &controls)
{
}
void IPAVimc::initTrace() void IPAVimc::initTrace()
{ {
struct stat fifoStat; struct stat fifoStat;