Mirror/libcamera
1
0
Fork 0
mirror of https://git.libcamera.org/libcamera/libcamera.git synced 2025-07-23 16:45:07 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

libcamera: camera_sensor: Default analogue crop rectangle

Browse source 
As support for the V4L2_SEL_TGT_CROP selection target used to read the
sensor analogue crop rectangle is schedule to become mandatory but is
still optional, use the sensor's active area size as fallback value to
allow the creation of the CameraSensorInfo in the case the driver does
not support it.

Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
This commit is contained in:
Jacopo Mondi 2021-01-02 12:18:17 +01:00
parent 125ee6ddd6
commit 8deb7e4331
1 changed files with 7 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/libcamera/camera_sensor.cpp
View file

@ -643,13 +643,16 @@ int CameraSensor::sensorInfo(CameraSensorInfo *info) const
*/
info->activeAreaSize = { activeArea_.width, activeArea_.height };
/* It's mandatory for the subdevice to report its crop rectangle. */
/*
* \todo Support for retreiving the crop rectangle is scheduled to
* become mandatory. For the time being use the default value if it has
* been initialized at sensor driver validation time.
*/
int ret = subdev_->getSelection(pad_, V4L2_SEL_TGT_CROP, &info->analogCrop);
if (ret) {
info->analogCrop = activeArea_;
LOG(CameraSensor, Error)
<< "Failed to construct camera sensor info: "
<< "the camera sensor does not report the crop rectangle";
return ret;
<< "The analogue crop rectangle has been defaulted to the active area size";
}
/*