Mirror/libcamera
1
0
Fork 0
mirror of https://git.libcamera.org/libcamera/libcamera.git synced 2025-07-13 23:39:44 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

libcamera: software_isp: Use RGB type to represent gains

Browse source 
Rather than using a custom struct to represent RGB values, let's use the
corresponding type and its facilities.

Signed-off-by: Milan Zamazal <mzamazal@redhat.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Milan Zamazal <mzamazal@redhat.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
This commit is contained in:
Milan Zamazal 2025-03-26 10:08:39 +01:00 • committed by Kieran Bingham
parent 84f82c6b3c
commit 94e849bcf7
3 changed files with 16 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

16
src/ipa/simple/algorithms/awb.cpp
View file

@ -25,7 +25,7 @@ int Awb::configure(IPAContext &context,
[[maybe_unused]] const IPAConfigInfo &configInfo)
{
auto &gains = context.activeState.awb.gains;
gains.red = gains.green = gains.blue = 1.0;
gains = { { 1.0, 1.0, 1.0 } };
return 0;
}
@ -56,16 +56,18 @@ void Awb::process(IPAContext &context,
* Clamp max gain at 4.0, this also avoids 0 division.
*/
auto &gains = context.activeState.awb.gains;
gains.red = sumR <= sumG / 4 ? 4.0 : static_cast<double>(sumG) / sumR;
gains.blue = sumB <= sumG / 4 ? 4.0 : static_cast<double>(sumG) / sumB;
/* Green gain is fixed to 1.0 */
gains = { {
sumR <= sumG / 4 ? 4.0 : static_cast<double>(sumG) / sumR,
1.0,
sumB <= sumG / 4 ? 4.0 : static_cast<double>(sumG) / sumB,
} };
RGB<double> rgbGains{ { 1 / gains.red, 1 / gains.green, 1 / gains.blue } };
RGB<double> rgbGains{ { 1 / gains.r(), 1 / gains.g(), 1 / gains.b() } };
context.activeState.awb.temperatureK = estimateCCT(rgbGains);
LOG(IPASoftAwb, Debug)
<< "gain R/B: " << gains.red << "/" << gains.blue
<< "; temperature: " << context.activeState.awb.temperatureK;
<< "gain R/B: " << gains << "; temperature: "
<< context.activeState.awb.temperatureK;
}
REGISTER_IPA_ALGORITHM(Awb, "Awb")